Re: [U-Boot] [PATCH v3 40/40] common: Add a note about the effort to reduce common.h

2019-08-13 Thread Tom Rini
On Fri, Aug 02, 2019 at 09:44:27AM -0600, Simon Glass wrote:

> This file has quite a lot of general definitions and include files. Add a
> note about our intent to remove more of this.
> 
> The file should ultimately include the configuration and perhaps a very
> other very common things used by most U-Boot files.
> 
> Signed-off-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH v3 40/40] common: Add a note about the effort to reduce common.h

2019-08-02 Thread Simon Glass
This file has quite a lot of general definitions and include files. Add a
note about our intent to remove more of this.

The file should ultimately include the configuration and perhaps a very
other very common things used by most U-Boot files.

Signed-off-by: Simon Glass 
---

Changes in v3:
- Rebase to master

Changes in v2:
- Rebase to master

 include/common.h | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/include/common.h b/include/common.h
index 2645ac9615..d8f302ea92 100644
--- a/include/common.h
+++ b/include/common.h
@@ -1,5 +1,11 @@
 /* SPDX-License-Identifier: GPL-2.0+ */
 /*
+ * Common header file for U-Boot
+ *
+ * This file still includes quite a bit of stuff that should be in separate
+ * headers like command.h, cpu.h and timer.h. Please think before adding more
+ * things. Patches to remove things are welcome.
+ *
  * (C) Copyright 2000-2009
  * Wolfgang Denk, DENX Software Engineering, w...@denx.de.
  */
-- 
2.22.0.770.g0f2c4a37fd-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot