Re: [U-Boot] [PATCH v4] Marvell MV88F6281GTW_GE Board support
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090503083923.gs25...@game.jcrosoft.org> you wrote: > > 3) I'm in favor as Mike to have the tool to build the final flashable bin > in the tree as done for the blackfin with a new target and a new extention > as .kwd (or any other) You know my opinion about this; it has not changed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Technology is dominated by those who manage what they do not under- stand. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] Marvell MV88F6281GTW_GE Board support
On 14:32 Sat 02 May , Prafulla Wadaskar wrote: > Thanks Jean... > > > > + > > > +#include > > > +#include <../drivers/net/phy/mv88e61xx.h> > > Ben I not sure it's clean > > any better idea? > > > +#include > > > +#include "mv88f6281gtw_ge.h" > > > + > > > index 000..9695f3f > > > --- /dev/null > > > +++ b/board/Marvell/mv88f6281gtw_ge/u-boot.lds > > please move to cpu/arm/kirkwood/ > I tried it, If we move it to Kirkwood there is build error, how do we invoke > it for the build? > currently it provides boot from DRAM since doimage (utility to convert > u-boot.bin to flashable bin) is outside. I think this is board specific and > each board will have different configuration, for ex. Board with boot from > NAND will have different info 3 thinks 1) to boot from DRAM you normaly do not need to change it for nand maybe but it will be normaly the same for all kirkwood 2) do you update your arch confif.mk cat cpu/arm926ejs/kirwood/config.mk LDSCRIPT := $(SRCTREE)/cpu/arm926ejs/kirwood/u-boot.lds 3) I'm in favor as Mike to have the tool to build the final flashable bin in the tree as done for the blackfin with a new target and a new extention as .kwd (or any other) Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] Marvell MV88F6281GTW_GE Board support
Thanks Jean...
> > +
> > +#include
> > +#include <../drivers/net/phy/mv88e61xx.h>
> Ben I not sure it's clean
> any better idea?
> > +#include
> > +#include "mv88f6281gtw_ge.h"
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +int board_init(void)
> > +{
> please add comment
Okay
> > + kw_config_gpio(MV88F6281GTW_GE_OE_VAL_LOW,
> > + MV88F6281GTW_GE_OE_VAL_HIGH,
> > + MV88F6281GTW_GE_OE_LOW, MV88F6281GTW_GE_OE_HIGH);
> > +
> > + /* Multi-Purpose Pins Functionality configuration */
> > + kw_config_mpp(MV88F6281GTW_GE_MPP0_7,
> > + MV88F6281GTW_GE_MPP8_15,
> > + MV88F6281GTW_GE_MPP16_23,
> > + MV88F6281GTW_GE_MPP24_31,
> > + MV88F6281GTW_GE_MPP32_39,
> > + MV88F6281GTW_GE_MPP40_47,
> MV88F6281GTW_GE_MPP48_55);
> > +
> From
> > + /* serial config */
> > + gd->baudrate = CONFIG_BAUDRATE;
> againt please remove
Okay
> > index 000..9695f3f
> > --- /dev/null
> > +++ b/board/Marvell/mv88f6281gtw_ge/u-boot.lds
> please move to cpu/arm/kirkwood/
I tried it, If we move it to Kirkwood there is build error, how do we invoke it
for the build?
currently it provides boot from DRAM since doimage (utility to convert
u-boot.bin to flashable bin) is outside. I think this is board specific and
each board will have different configuration, for ex. Board with boot from NAND
will have different info
> > +#define CONFIG_KIRKWOOD1 /* SOC Family Name */
> > +#define CONFIG_KW88F6281 1 /* SOC Name */
> please define the CONFIG_MACH
Okay I will check this and do the needful
> > +
> > +#ifdef CONFIG_KIRKWOOD
> as I guess it will be always KIRKWOOD please remove
Sounds good, I will remove it
Regards..
Prafulla . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] Marvell MV88F6281GTW_GE Board support
> +# (C) Copyright 2009
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +#include
> +#include <../drivers/net/phy/mv88e61xx.h>
Ben I not sure it's clean
any better idea?
> +#include
> +#include "mv88f6281gtw_ge.h"
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +int board_init(void)
> +{
please add comment
> + kw_config_gpio(MV88F6281GTW_GE_OE_VAL_LOW,
> +MV88F6281GTW_GE_OE_VAL_HIGH,
> +MV88F6281GTW_GE_OE_LOW, MV88F6281GTW_GE_OE_HIGH);
> +
> + /* Multi-Purpose Pins Functionality configuration */
> + kw_config_mpp(MV88F6281GTW_GE_MPP0_7,
> + MV88F6281GTW_GE_MPP8_15,
> + MV88F6281GTW_GE_MPP16_23,
> + MV88F6281GTW_GE_MPP24_31,
> + MV88F6281GTW_GE_MPP32_39,
> + MV88F6281GTW_GE_MPP40_47, MV88F6281GTW_GE_MPP48_55);
> +
From
> + /* serial config */
> + gd->baudrate = CONFIG_BAUDRATE;
againt please remove
> + /*
> + * arch number of USED SOC
> + */
> + gd->bd->bi_arch_number = MACH_TYPE_MV88F6281GTW_GE;
> +
> + /* adress of boot parameters */
> + gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
> +
> + return 0;
> +}
> +
> +int dram_init(void)
> +{
> + int i;
> +
> + for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
> + gd->bd->bi_dram[i].start = kw_sdram_bar(i);
> + gd->bd->bi_dram[i].size = kw_sdram_bs(i);
> + }
> + return 0;
> +}
> +
> index 000..9695f3f
> --- /dev/null
> +++ b/board/Marvell/mv88f6281gtw_ge/u-boot.lds
please move to cpu/arm/kirkwood/
> @@ -0,0 +1,53 @@
> +/*
> + * (C) Copyright 2009
> + * Marvell Semiconductor
> + * Prafulla Wadaskar
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> + * MA 02110-1301 USA
> + */
> +
> +OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm")
> +OUTPUT_ARCH(arm)
> +ENTRY(_start)
> +SECTIONS
> +{
> + . = _start;
> + . = ALIGN(4);
> + .text :
> + {
> + cpu/arm926ejs/start.o (.text)
> + *(.text)
> + }
> + .rodata : { *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata))) }
> + . = ALIGN(4);
> + .data : { *(.data) }
> + . = ALIGN(4);
> + .got : { *(.got) }
> + * MA 02110-1301 USA
> + */
> +
> +#ifndef _CONFIG_MV88F6281GTW_GE_H
> +#define _CONFIG_MV88F6281GTW_GE_H
> +
> +/*
> + * Version number information
> + */
> +#define CONFIG_IDENT_STRING "\nMarvell-MV88F6281GTW_GE-A0"
> +
> +/*
> + * High Level Configuration Options (easy to change)
> + */
> +#define CONFIG_MARVELL 1
> +#define CONFIG_ARM926EJS 1 /* Basic Architecture */
> +#define CONFIG_FEROCEON_88FR131 1 /* CPU Core subversion */
> +#define CONFIG_KIRKWOOD 1 /* SOC Family Name */
> +#define CONFIG_KW88F6281 1 /* SOC Name */
please define the CONFIG_MACH
> +
> +#ifdef CONFIG_KIRKWOOD
as I guess it will be always KIRKWOOD please remove
> +#define CONFIG_MD5 /* get_random_hex on krikwood needs MD5 support
> */
> +#define CONFIG_ARCH_LOWLEVEL_INIT/* enable arch_lowlevel_init */
> +#define CONFIG_SKIP_LOWLEVEL_INIT/* disable board lowlevel_init */
> +#define CONFIG_KIRKWOOD_EGIGA_INIT /* Enable GbePort0/1 for kernel */
> +#define CONFIG_KIRKWOOD_PCIE_INIT/* Enable PCIE Port0 for kernel */
> +#define CONFIG_KIRKWOOD_RGMII_PAD_1V8/* Set RGMII Pad voltage to
> 1.8V */
> +#endif
> +
otherwise fine
Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4] Marvell MV88F6281GTW_GE Board support
From: prafulla_wadaskar This is Marvell's 88F6281_A0 based custom board developed for wireless access point product This patch is tested for- 1. Boot from DRAM/SPI flash/NFS 2. File transfer using tftp and loadb 3. SPI flash read/write/erase 4. Booting Linux kernel and RFS from SPI flash Reviewed-by: Ronen Shitrit Signed-off-by: Prafulla Wadaskar --- Change log v2: updated as per first review comments debug_prints updated to debug v3: updaed as per review comments for v2 added mv88f6281gtw_ge.h file removed BITxx macros v4: updated as per review comments for v3 arch_misc_init support is added and used from kirkwood MAKEALL |1 + Makefile|3 + board/Marvell/mv88f6281gtw_ge/Makefile | 51 +++ board/Marvell/mv88f6281gtw_ge/config.mk | 25 +++ board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 86 +++ board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h | 51 +++ board/Marvell/mv88f6281gtw_ge/u-boot.lds| 53 +++ include/configs/mv88f6281gtw_ge.h | 180 +++ 8 files changed, 450 insertions(+), 0 deletions(-) create mode 100644 board/Marvell/mv88f6281gtw_ge/Makefile create mode 100644 board/Marvell/mv88f6281gtw_ge/config.mk create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h create mode 100644 board/Marvell/mv88f6281gtw_ge/u-boot.lds create mode 100644 include/configs/mv88f6281gtw_ge.h diff --git a/MAKEALL b/MAKEALL index e4eb42b..1caf81d 100755 --- a/MAKEALL +++ b/MAKEALL @@ -504,6 +504,7 @@ LIST_ARM9=" \ cp946es \ cp966 \ lpd7a400\ + mv88f6281gtw_ge \ mx1ads \ mx1fs2 \ netstar \ diff --git a/Makefile b/Makefile index d2c7c3f..709e4be 100644 --- a/Makefile +++ b/Makefile @@ -2792,6 +2792,9 @@ lpd7a400_config \ lpd7a404_config: unconfig @$(MKCONFIG) $(@:_config=) arm lh7a40x lpd7a40x +mv88f6281gtw_ge_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood + mx1ads_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm920t mx1ads NULL imx diff --git a/board/Marvell/mv88f6281gtw_ge/Makefile b/board/Marvell/mv88f6281gtw_ge/Makefile new file mode 100644 index 000..8c49a3e --- /dev/null +++ b/board/Marvell/mv88f6281gtw_ge/Makefile @@ -0,0 +1,51 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor +# Prafulla Wadaskar +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS := mv88f6281gtw_ge.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/Marvell/mv88f6281gtw_ge/config.mk b/board/Marvell/mv88f6281gtw_ge/config.mk new file mode 100644 index 000..fb29a1b --- /dev/null +++ b/board/Marvell/mv88f6281gtw_ge/config.mk @@ -0,0 +1,25 @@ +# +# (C) Copyright 2009 +# Marvell Semiconductor +# Prafulla Wadaskar +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more de
