Re: [U-Boot] [PATCH v4 0/3] usb:gadget:composite: Support for composite gadget framework

2012-04-25 Thread Lukasz Majewski
Hi Marek,

 This patch set provides support for composite gadget framework.
 Files from Linux kernel (2.6.36) - namely composite.{c|h} have been
 ported to u-boot.
 
 Code supporting this framework has been added to gadget.h and
 Samsung's UDC driver as well.
 
 ---
 Changes for v2:
 - Squash the kernel files with u-boot compatibility layer.
 - Removal of dead/kernel specific code.
 - Comments corrected according to u-boot coding style.
 - Two separate patches regarding gadget.h file squashed together.
 Changes for v3:
 - Remove unlikely function call
 - Code indentation fixup
 Changes for v4:
 - Move variables definition to function beginning
 - CaMeL case declaration fixed
 
 Lukasz Majewski (3):
   usb:gadget:composite USB composite gadget support
   usb:gadget:composite: Support for composite at gadget.h
   usb:udc:samsung Add functions for storing private gadget data in UDC
 driver

Can you look into this code? Since the 2012.04.01 is out (stable
u-boot), I would like to improve the USB subsystem.

Moreover one commit:
http://patchwork.ozlabs.org/patch/151983/

has been acked-by you, but it hasn't been added to u-boot-usb/next.
Would it be possible to pull this code?

-- 
Best regards,

Lukasz Majewski

Samsung Poland RD Center | Linux Platform Group
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v4 0/3] usb:gadget:composite: Support for composite gadget framework

2012-04-25 Thread Marek Vasut
Dear Lukasz Majewski,

 Hi Marek,
 
  This patch set provides support for composite gadget framework.
  Files from Linux kernel (2.6.36) - namely composite.{c|h} have been
  ported to u-boot.
  
  Code supporting this framework has been added to gadget.h and
  Samsung's UDC driver as well.
  
  ---
  
  Changes for v2:
  - Squash the kernel files with u-boot compatibility layer.
  - Removal of dead/kernel specific code.
  - Comments corrected according to u-boot coding style.
  - Two separate patches regarding gadget.h file squashed together.
  
  Changes for v3:
  - Remove unlikely function call
  - Code indentation fixup
  
  Changes for v4:
  - Move variables definition to function beginning
  - CaMeL case declaration fixed
  
  Lukasz Majewski (3):
usb:gadget:composite USB composite gadget support
usb:gadget:composite: Support for composite at gadget.h
usb:udc:samsung Add functions for storing private gadget data in UDC

  driver
 
 Can you look into this code? Since the 2012.04.01 is out (stable
 u-boot), I would like to improve the USB subsystem.
 
 Moreover one commit:
 http://patchwork.ozlabs.org/patch/151983/
 
 has been acked-by you, but it hasn't been added to u-boot-usb/next.
 Would it be possible to pull this code?

Yes, it's on my slate ... I'm slightly congested now, I appologize for not 
reviewing these quickly, would you mind giving me a few more days please?

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v4 0/3] usb:gadget:composite: Support for composite gadget framework

2012-04-18 Thread Lukasz Majewski
This patch set provides support for composite gadget framework.
Files from Linux kernel (2.6.36) - namely composite.{c|h} have been
ported to u-boot.

Code supporting this framework has been added to gadget.h and Samsung's
UDC driver as well.

---
Changes for v2:
- Squash the kernel files with u-boot compatibility layer.
- Removal of dead/kernel specific code.
- Comments corrected according to u-boot coding style.
- Two separate patches regarding gadget.h file squashed together.
Changes for v3:
- Remove unlikely function call
- Code indentation fixup
Changes for v4:
- Move variables definition to function beginning
- CaMeL case declaration fixed

Lukasz Majewski (3):
  usb:gadget:composite USB composite gadget support
  usb:gadget:composite: Support for composite at gadget.h
  usb:udc:samsung Add functions for storing private gadget data in UDC
driver

 drivers/usb/gadget/composite.c   | 1082 ++
 drivers/usb/gadget/s3c_udc_otg.c |   12 +
 include/linux/usb/composite.h|  350 
 include/linux/usb/gadget.h   |6 +
 include/usb/lin_gadget_compat.h  |   24 +-
 5 files changed, 1472 insertions(+), 2 deletions(-)
 create mode 100644 drivers/usb/gadget/composite.c
 create mode 100644 include/linux/usb/composite.h

-- 
1.7.2.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot