Re: [U-Boot] [PATCH v4 0/6] Add Highbank platform
Wolfgang, On 07/04/2011 05:28 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 1309275583-11763-1-git-send-email-robherri...@gmail.com you wrote: From: Rob Herring rob.herr...@calxeda.com This series enables non-PCI AHCI controllers and adds support for Calxeda Highbank platform which uses the AHCI changes. Changes from v3: - Added Highbank to MAINTAINERS - Added back patch to fix CONFIG_SKIP_LOWLEVEL_INIT (mistakenly dropped from v2) Wolfgang, Albert, Can you apply these to your trees for v2011.09? All review comments have been addressed. I have to admit that I dislike the way you are working. If I'm not wrong, there have been several versions of your patches around, but you repost again and again without any indication that these are reposts, nor what exactly has been changed between versions. For example, I see three different posts here: 06/11 Rob Herring[U-Boot] [PATCH 8/8] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101435 06/21 Rob Herring[U-Boot] [PATCH 1/5] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101867 06/28 Rob Herring[U-Boot] [PATCH 2/6] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102124 None of these adheres to the requirements as documented here: http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions Please be aware that NOT documentaing what you changed means that all (potential) reviewers of your code have to spend additional time figuring out what you might have changed, and checking back in the history if you really implemented all earlier review comments. Speaking for me, I must state that being notoriously short of time I am not willing to waste additional time on such postings, so I tend to ignore them. In short: please stick to the rules if you want your patches to go into mainline. Sorry about this. I will follow this more closely going forward. Much of the significant change was to the series itself and less so the content itself. I added Highbank support based on you wanting to see a platform use the AHCI changes. Then I dropped the SDHCI changes as another common implementation appeared on the list and it will take some time to sort out. The history for ARM: Add Calxeda Highbank platform is: v2: - Move SATA and MMC board init to separate patches - Fix DRAM size setup v3: - Add maintainer I can repost it if you like with the history, but I'd like to get any review comments from you first. Up until my last post, the following patches have had no comments and no changes. They were only reposted as part of the whole series: ARM: add missing CONFIG_SKIP_LOWLEVEL_INIT for armv7 arm: add __ilog2 function scsi/ahci: ata id little endian fix I have posted v2 of arm: add __ilog2 function and v3 of scsi/ahci: add support for non-PCI controllers as a replies to the prior versions. http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102679 http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102775 Regards, Rob ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/6] Add Highbank platform
Dear Rob Herring, In message 1309275583-11763-1-git-send-email-robherri...@gmail.com you wrote: From: Rob Herring rob.herr...@calxeda.com This series enables non-PCI AHCI controllers and adds support for Calxeda Highbank platform which uses the AHCI changes. Changes from v3: - Added Highbank to MAINTAINERS - Added back patch to fix CONFIG_SKIP_LOWLEVEL_INIT (mistakenly dropped from v2) Wolfgang, Albert, Can you apply these to your trees for v2011.09? All review comments have been addressed. I have to admit that I dislike the way you are working. If I'm not wrong, there have been several versions of your patches around, but you repost again and again without any indication that these are reposts, nor what exactly has been changed between versions. For example, I see three different posts here: 06/11 Rob Herring[U-Boot] [PATCH 8/8] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101435 06/21 Rob Herring[U-Boot] [PATCH 1/5] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/101867 06/28 Rob Herring[U-Boot] [PATCH 2/6] ARM: Add Calxeda Highbank platform http://article.gmane.org/gmane.comp.boot-loaders.u-boot/102124 None of these adheres to the requirements as documented here: http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions Please be aware that NOT documentaing what you changed means that all (potential) reviewers of your code have to spend additional time figuring out what you might have changed, and checking back in the history if you really implemented all earlier review comments. Speaking for me, I must state that being notoriously short of time I am not willing to waste additional time on such postings, so I tend to ignore them. In short: please stick to the rules if you want your patches to go into mainline. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de ... bacteriological warfare ... hard to believe we were once foolish enough to play around with that. -- McCoy, The Omega Glory, stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/6] Add Highbank platform
Hi Wolfgang, Le 04/07/2011 12:28, Wolfgang Denk a écrit : Dear Albert ARIBAUD, In message4e0c63d0.9010...@aribaud.net you wrote: Seems like there are no additional comments and most of the code is for There are not much additional comments because Rob's patches should all be ignored, or do you have the time to find out which of this versions is what, and what he actually changed? It seems he did not even run checkpatch. Acked-By: Albert ARIBAUDalbert-u-b...@aribaud.net ... and I'll pull it in u-boot-arm/master once the current ARM pull request is processed. I'm not sure if this is a good idea. Understood. Best regards, Wolfgang Denk Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/6] Add Highbank platform
Hi Rob, Le 28/06/2011 17:39, Rob Herring a écrit : From: Rob Herringrob.herr...@calxeda.com This series enables non-PCI AHCI controllers and adds support for Calxeda Highbank platform which uses the AHCI changes. Changes from v3: - Added Highbank to MAINTAINERS - Added back patch to fix CONFIG_SKIP_LOWLEVEL_INIT (mistakenly dropped from v2) Wolfgang, Albert, Can you apply these to your trees for v2011.09? All review comments have been addressed. Rob Seems like there are no additional comments and most of the code is for ARM without any other custodian involved, so: Acked-By: Albert ARIBAUD albert-u-b...@aribaud.net ... and I'll pull it in u-boot-arm/master once the current ARM pull request is processed. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 0/6] Add Highbank platform
From: Rob Herring rob.herr...@calxeda.com This series enables non-PCI AHCI controllers and adds support for Calxeda Highbank platform which uses the AHCI changes. Changes from v3: - Added Highbank to MAINTAINERS - Added back patch to fix CONFIG_SKIP_LOWLEVEL_INIT (mistakenly dropped from v2) Wolfgang, Albert, Can you apply these to your trees for v2011.09? All review comments have been addressed. Rob Rob Herring (6): ARM: add missing CONFIG_SKIP_LOWLEVEL_INIT for armv7 ARM: Add Calxeda Highbank platform arm: add __ilog2 function scsi/ahci: ata id little endian fix scsi/ahci: add support for non-PCI controllers ARM: highbank: Add AHCI support MAINTAINERS |4 + arch/arm/cpu/armv7/highbank/Makefile | 46 arch/arm/cpu/armv7/highbank/config.mk |4 + arch/arm/cpu/armv7/highbank/timer.c | 124 + arch/arm/cpu/armv7/start.S|2 + arch/arm/include/asm/bitops.h |9 +++ board/highbank/Makefile | 49 + board/highbank/highbank.c | 58 +++ boards.cfg|1 + common/cmd_scsi.c |6 +- drivers/block/ahci.c | 72 --- include/ahci.h|4 + include/configs/highbank.h| 112 + include/scsi.h|1 + 14 files changed, 480 insertions(+), 12 deletions(-) create mode 100644 arch/arm/cpu/armv7/highbank/Makefile create mode 100644 arch/arm/cpu/armv7/highbank/config.mk create mode 100644 arch/arm/cpu/armv7/highbank/timer.c create mode 100644 board/highbank/Makefile create mode 100644 board/highbank/highbank.c create mode 100644 include/configs/highbank.h -- 1.7.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
