Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On Sat, Feb 9, 2019 at 8:48 PM Abel Vesa wrote: > So, do I need to resend this with all the R-bs ? Just realized that you missed to Cc Stefano Babic on this series. Stefano, Should Abel resend this series with you on Cc or can you get review it from patchwork? Thanks ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On 19-02-04 08:19:23, Tom Rini wrote: > On Mon, Feb 04, 2019 at 09:03:43AM -0200, Fabio Estevam wrote: > > On Mon, Feb 4, 2019 at 7:55 AM Abel Vesa wrote: > > > > > If the SPL size (without the dtb appended) is larger then yes, the build > > > fails. > > > Trouble is if the SPL (without the dtb appended) is, lets say, 63kB and > > > then the dtb is larger than 1kB. Then there is no mechanism in place to > > > check that > > > and it will just fail to boot without giving any clues why. But this is a > > > totally > > > unrelated problem from this patchset's point of view and I think it > > > impacts all > > > the platforms that support SPL with DM. > > > > Yes, it is unrelated to this series and should be treated separately. > > I also agree. But, don't we have a mechanism for that? It sounds like > some additional targets need to call $(BOARD_SIZE_CHECK) at the end. Or > am I missing something? > So, do I need to resend this with all the R-bs ? > -- > Tom ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On Mon, Feb 04, 2019 at 04:21:37PM +0100, Simon Goldschmidt wrote: > Am Mo., 4. Feb. 2019, 16:16 hat Abel Vesa geschrieben: > > > On 19-02-04 08:19:23, Tom Rini wrote: > > > On Mon, Feb 04, 2019 at 09:03:43AM -0200, Fabio Estevam wrote: > > > > On Mon, Feb 4, 2019 at 7:55 AM Abel Vesa wrote: > > > > > > > > > If the SPL size (without the dtb appended) is larger then yes, the > > build fails. > > > > > Trouble is if the SPL (without the dtb appended) is, lets say, 63kB > > and > > > > > then the dtb is larger than 1kB. Then there is no mechanism in place > > to check that > > > > > and it will just fail to boot without giving any clues why. But this > > is a totally > > > > > unrelated problem from this patchset's point of view and I think it > > impacts all > > > > > the platforms that support SPL with DM. > > > > > > > > Yes, it is unrelated to this series and should be treated separately. > > > > > > I also agree. But, don't we have a mechanism for that? It sounds like > > > some additional targets need to call $(BOARD_SIZE_CHECK) at the end. Or > > > am I missing something? > > > > > > > Hmm, I believe that is true. I haven't looked deeper into it but it seems > > that's the thing the SPL is missing. > > > Haven't we talked about that just some days or weeks ago? That's exactly > what I am missing for socfpga. I keep getting broken SPL images when adding > functionality. And you don't even get an error message because the dtb is > broken and cannot provide the serial output mode... Yes, I believe it is. I guess what I'm waiting / hoping for is someone to patch the top-level Makefile to call $(BOARD_SIZE_CHECK) on a number of make targets that look reasonable, throw it at travis and see what if anything fails (and if stuff fails, ask for help to see if it's right or investigate a bit more). More or less, if it's a final target for U-Boot, we should probably give BOARD_SIZE_CHECK a try. Most of the rules start with u-boot, but I bet the %.imx target should also do it, and then we can drop all of that from arch/arm/mach-imx/Makefile. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
Am Mo., 4. Feb. 2019, 16:16 hat Abel Vesa geschrieben: > On 19-02-04 08:19:23, Tom Rini wrote: > > On Mon, Feb 04, 2019 at 09:03:43AM -0200, Fabio Estevam wrote: > > > On Mon, Feb 4, 2019 at 7:55 AM Abel Vesa wrote: > > > > > > > If the SPL size (without the dtb appended) is larger then yes, the > build fails. > > > > Trouble is if the SPL (without the dtb appended) is, lets say, 63kB > and > > > > then the dtb is larger than 1kB. Then there is no mechanism in place > to check that > > > > and it will just fail to boot without giving any clues why. But this > is a totally > > > > unrelated problem from this patchset's point of view and I think it > impacts all > > > > the platforms that support SPL with DM. > > > > > > Yes, it is unrelated to this series and should be treated separately. > > > > I also agree. But, don't we have a mechanism for that? It sounds like > > some additional targets need to call $(BOARD_SIZE_CHECK) at the end. Or > > am I missing something? > > > > Hmm, I believe that is true. I haven't looked deeper into it but it seems > that's the thing the SPL is missing. Haven't we talked about that just some days or weeks ago? That's exactly what I am missing for socfpga. I keep getting broken SPL images when adding functionality. And you don't even get an error message because the dtb is broken and cannot provide the serial output mode... Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On 19-02-04 08:19:23, Tom Rini wrote: > On Mon, Feb 04, 2019 at 09:03:43AM -0200, Fabio Estevam wrote: > > On Mon, Feb 4, 2019 at 7:55 AM Abel Vesa wrote: > > > > > If the SPL size (without the dtb appended) is larger then yes, the build > > > fails. > > > Trouble is if the SPL (without the dtb appended) is, lets say, 63kB and > > > then the dtb is larger than 1kB. Then there is no mechanism in place to > > > check that > > > and it will just fail to boot without giving any clues why. But this is a > > > totally > > > unrelated problem from this patchset's point of view and I think it > > > impacts all > > > the platforms that support SPL with DM. > > > > Yes, it is unrelated to this series and should be treated separately. > > I also agree. But, don't we have a mechanism for that? It sounds like > some additional targets need to call $(BOARD_SIZE_CHECK) at the end. Or > am I missing something? > Hmm, I believe that is true. I haven't looked deeper into it but it seems that's the thing the SPL is missing. > -- > Tom ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On Mon, Feb 04, 2019 at 09:03:43AM -0200, Fabio Estevam wrote: > On Mon, Feb 4, 2019 at 7:55 AM Abel Vesa wrote: > > > If the SPL size (without the dtb appended) is larger then yes, the build > > fails. > > Trouble is if the SPL (without the dtb appended) is, lets say, 63kB and > > then the dtb is larger than 1kB. Then there is no mechanism in place to > > check that > > and it will just fail to boot without giving any clues why. But this is a > > totally > > unrelated problem from this patchset's point of view and I think it impacts > > all > > the platforms that support SPL with DM. > > Yes, it is unrelated to this series and should be treated separately. I also agree. But, don't we have a mechanism for that? It sounds like some additional targets need to call $(BOARD_SIZE_CHECK) at the end. Or am I missing something? -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On Mon, Feb 4, 2019 at 7:55 AM Abel Vesa wrote: > If the SPL size (without the dtb appended) is larger then yes, the build > fails. > Trouble is if the SPL (without the dtb appended) is, lets say, 63kB and > then the dtb is larger than 1kB. Then there is no mechanism in place to check > that > and it will just fail to boot without giving any clues why. But this is a > totally > unrelated problem from this patchset's point of view and I think it impacts > all > the platforms that support SPL with DM. Yes, it is unrelated to this series and should be treated separately. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On 19-02-02 07:50:28, Fabio Estevam wrote: > Hi Abel, > > On Fri, Feb 1, 2019 at 2:43 PM Abel Vesa wrote: > > > > The third version is here: > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Fpipermail%2Fu-boot%2F2019-January%2F356903.htmldata=02%7C01%7Cabel.vesa%40nxp.com%7Ca93c33315b5b492ca15308d688f3e275%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636846978387908349sdata=wQrrLoMyouM5vdUlfXI325wqZYt4tTa5WTRJsgwMEz0%3Dreserved=0 > > > > So, this time I hope I got it right. Before, I was stupidly trying > > to put a fit in another fit without a really good reason. To my > > excuse, that was working even with the spl_image->os set to 0, > > bug which I (hope) I fixed in the first patch (a new one) > > of this series. > > I am happy with the entire series. > > One more question: do we get build error when the SPL gets larger than 64kB? If the SPL size (without the dtb appended) is larger then yes, the build fails. Trouble is if the SPL (without the dtb appended) is, lets say, 63kB and then the dtb is larger than 1kB. Then there is no mechanism in place to check that and it will just fail to boot without giving any clues why. But this is a totally unrelated problem from this patchset's point of view and I think it impacts all the platforms that support SPL with DM. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
Hi Abel, On Fri, Feb 1, 2019 at 2:43 PM Abel Vesa wrote: > > The third version is here: > https://lists.denx.de/pipermail/u-boot/2019-January/356903.html > > So, this time I hope I got it right. Before, I was stupidly trying > to put a fit in another fit without a really good reason. To my > excuse, that was working even with the spl_image->os set to 0, > bug which I (hope) I fixed in the first patch (a new one) > of this series. I am happy with the entire series. One more question: do we get build error when the SPL gets larger than 64kB? ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On Fri, Feb 01, 2019 at 04:40:05PM +, Abel Vesa wrote: > The third version is here: > https://lists.denx.de/pipermail/u-boot/2019-January/356903.html > > So, this time I hope I got it right. Before, I was stupidly trying > to put a fit in another fit without a really good reason. To my > excuse, that was working even with the spl_image->os set to 0, > bug which I (hope) I fixed in the first patch (a new one) > of this series. > > Changes since v3: > * Reduced the SPL size by disabling EXT_SUPPORT, otherwise the >6qp-sabresd wouldn't boot due to having its dtb last in the fit. >I forgot to mention in the last version that EFI and DOS SPL support >also had to be disabled to get the size right. > * Dropped the fit_spl.its file > * Dropped the (now) unnecessary updates to the README files. We're >sticking to the u-boot.img since it's exactly what is needed. > * Fixed a bug related to FIT_IMAGE_TINY when CONFIG_SPL_OS_BOOT >is enabled. The short story here is that spl_image->os was >remaining set to 0. (see first patch in the series for details) Thanks for being persistent and figuring all of this out! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On Fri, Feb 1, 2019 at 3:59 PM Abel Vesa wrote: > > Is Ethernet functional? > > I haven't tested the ethernet on all of them, just one of each > (sabresd/sabreauto). > > I'll test them all when I get back at the office tomorrow. Don't worry about that. If you tested in one of each then it is fine. Thanks ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
On 19-02-01 15:13:32, Fabio Estevam wrote: > Hi Abel, > > On Fri, Feb 1, 2019 at 2:43 PM Abel Vesa wrote: > > > > The third version is here: > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Fpipermail%2Fu-boot%2F2019-January%2F356903.htmldata=02%7C01%7Cabel.vesa%40nxp.com%7Cc7db2be273394c06098308d688689e41%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636846380248922351sdata=fhDqNxkE1dq0fGNroGRR%2F0OkmBPRlVBqCefS6GM8kns%3Dreserved=0 > > > > So, this time I hope I got it right. Before, I was stupidly trying > > to put a fit in another fit without a really good reason. To my > > excuse, that was working even with the spl_image->os set to 0, > > bug which I (hope) I fixed in the first patch (a new one) > > of this series. > > Thanks for your work on this! > > Just to confirm: with this series all sabresd variants (imx6q, imx6dl, > imx6qp) boot with the same binary, right? > That is correct. For mx6sabresd_defconfig, all imx6q_sabresd, imx6qp_sabresd and imx6dl_sabresd have been tested with the same binary. And I've tested exactly the same the mx6sabreauto_defconfig with all three SoC combinations. > Is there anything known to be not working that used to work before due > to missing driver model conversion? > I don't know about anything that might not work. As specified in the cover letter I had to get rid (disable) of EFI, EXT and DOS support in SPL. > Is Ethernet functional? I haven't tested the ethernet on all of them, just one of each (sabresd/sabreauto). I'll test them all when I get back at the office tomorrow. > > Thanks ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
Hi Abel, On Fri, Feb 1, 2019 at 2:43 PM Abel Vesa wrote: > > The third version is here: > https://lists.denx.de/pipermail/u-boot/2019-January/356903.html > > So, this time I hope I got it right. Before, I was stupidly trying > to put a fit in another fit without a really good reason. To my > excuse, that was working even with the spl_image->os set to 0, > bug which I (hope) I fixed in the first patch (a new one) > of this series. Thanks for your work on this! Just to confirm: with this series all sabresd variants (imx6q, imx6dl, imx6qp) boot with the same binary, right? Is there anything known to be not working that used to work before due to missing driver model conversion? Is Ethernet functional? Thanks ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
The third version is here: https://lists.denx.de/pipermail/u-boot/2019-January/356903.html So, this time I hope I got it right. Before, I was stupidly trying to put a fit in another fit without a really good reason. To my excuse, that was working even with the spl_image->os set to 0, bug which I (hope) I fixed in the first patch (a new one) of this series. Changes since v3: * Reduced the SPL size by disabling EXT_SUPPORT, otherwise the 6qp-sabresd wouldn't boot due to having its dtb last in the fit. I forgot to mention in the last version that EFI and DOS SPL support also had to be disabled to get the size right. * Dropped the fit_spl.its file * Dropped the (now) unnecessary updates to the README files. We're sticking to the u-boot.img since it's exactly what is needed. * Fixed a bug related to FIT_IMAGE_TINY when CONFIG_SPL_OS_BOOT is enabled. The short story here is that spl_image->os was remaining set to 0. (see first patch in the series for details) Abel Vesa (20): common: spl_fit: Fix the spl_fit_image_get_os for FIT_IMAGE_TINY usb: Rename SPL_USB_SUPPORT to SPL_USB_STORAGE usb: ehci-mx6: Make regulator DM_REGULATOR dependent configs: imx6sabreauto: Add DM_MMC support configs: imx6sabreauto: Add DM_USB support mmc: fsl_esdhc: Fix DM_REGULATOR ifdefs for SPL builds board: mx6sabresd: Add board_fit_config_name_match to support FIT in SPL board: mx6sabreauto: Add board_fit_config_name_match to support FIT in SPL arm: dts: Add all the imx6[q|qp|dl] sabre[auto|sd] u-boot dts[i] files arm: dts: Update all the dts[i] files for imx6[q|qp|dl] sabre[auto|sd] configs: mx6sabreauto: Add SPL FIT and DM support configs: mx6sabresd: Add SPL FIT and DM support mx6sabreauto: Add DM_GPIO support mx6sabresd: Add DM_GPIO support configs: mx6sabreauto: Add DM_SPI_FLASH necessary configs configs: mx6sabresd: Add DM_SPI_FLASH necessary configs board: mx6sabreauto: Remove the non-DM code board: mx6sabresd: Remove non-DM code board: mx6sabresd: Remove the enet reset gpio handling configs: mx6sabresd: Reduce SPL size by disabling DOS, EXT and EFI support arch/arm/dts/Makefile | 8 +- arch/arm/dts/imx6dl-sabreauto-u-boot.dtsi | 6 + arch/arm/dts/imx6dl-sabreauto.dts | 13 + arch/arm/dts/imx6dl-sabresd-u-boot.dtsi | 6 + arch/arm/dts/imx6dl-sabresd.dts | 18 + arch/arm/dts/imx6dl.dtsi| 306 ++- arch/arm/dts/imx6q-sabreauto-u-boot.dtsi| 6 + arch/arm/dts/imx6q-sabreauto.dts| 18 + arch/arm/dts/imx6q-sabresd-u-boot.dtsi | 6 + arch/arm/dts/imx6q-sabresd.dts | 23 + arch/arm/dts/imx6q.dtsi | 310 +-- arch/arm/dts/imx6qdl-sabreauto-u-boot.dtsi | 21 + arch/arm/dts/imx6qdl-sabreauto.dtsi | 810 arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi| 14 + arch/arm/dts/imx6qdl-sabresd.dtsi | 741 + arch/arm/dts/imx6qdl-u-boot.dtsi| 4 +- arch/arm/dts/imx6qdl.dtsi | 455 +--- arch/arm/dts/imx6qp-sabreauto-u-boot.dtsi | 6 + arch/arm/dts/imx6qp-sabreauto.dts | 55 ++ arch/arm/dts/imx6qp-sabresd-u-boot.dtsi | 6 + arch/arm/dts/imx6qp-sabresd.dts | 55 ++ arch/arm/dts/imx6qp.dtsi| 115 arch/arm/include/asm/arch-am33xx/spl.h | 2 +- arch/arm/mach-omap2/boot-common.c | 2 +- board/freescale/mx6sabreauto/mx6sabreauto.c | 91 +--- board/freescale/mx6sabresd/mx6sabresd.c | 78 +-- common/Makefile | 5 +- common/spl/Kconfig | 4 +- common/spl/Makefile | 2 +- common/spl/spl_fit.c| 4 - common/spl/spl_usb.c| 4 - configs/am43xx_evm_usbhost_boot_defconfig | 2 +- configs/am43xx_hs_evm_defconfig | 2 +- configs/mx6sabreauto_defconfig | 20 +- configs/mx6sabresd_defconfig| 26 +- drivers/mmc/fsl_esdhc.c | 8 +- drivers/usb/host/ehci-mx6.c | 7 +- 37 files changed, 2847 insertions(+), 412 deletions(-) create mode 100644 arch/arm/dts/imx6dl-sabreauto-u-boot.dtsi create mode 100644 arch/arm/dts/imx6dl-sabreauto.dts create mode 100644 arch/arm/dts/imx6dl-sabresd-u-boot.dtsi create mode 100644 arch/arm/dts/imx6dl-sabresd.dts create mode 100644 arch/arm/dts/imx6q-sabreauto-u-boot.dtsi create mode 100644 arch/arm/dts/imx6q-sabreauto.dts create mode 100644 arch/arm/dts/imx6q-sabresd-u-boot.dtsi create mode 100644 arch/arm/dts/imx6q-sabresd.dts create mode 100644 arch/arm/dts/imx6qdl-sabreauto-u-boot.dtsi create mode 100644 arch/arm/dts/imx6qdl-sabreauto.dtsi create mode 100644 arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi create mode 100644 arch/arm/dts/imx6qdl-sabresd.dtsi create mode 100644
