Re: [U-Boot] [PATCH v4 2/4] ARMV7: OMAP3: Cleanup extern variables in mem.c

2011-04-19 Thread Paulraj, Sandeep


 
 Removed boot_flash_* extern variables.
 boot_flash_type was totally unused. The other ones were actually constants,
 so
 they have been replaced with #defines in the board config files.
 
 Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
 Cc: Wolfgang Denk w...@denx.de
 Cc: Albert Aribaud albert.arib...@free.fr
 Cc: Sandeep Paulraj s-paul...@ti.com
 ---
 Changes in v4:
  - this patch is new in v4.
 
  arch/arm/cpu/armv7/omap3/mem.c  |   32 
  include/configs/am3517_evm.h|   18 ++
  include/configs/cm_t35.h|   16 +---
  include/configs/devkit8000.h|   10 +-
  include/configs/omap3_beagle.h  |   16 +---
  include/configs/omap3_evm.h |   26 --
  include/configs/omap3_overo.h   |   16 +---
  include/configs/omap3_pandora.h |   16 +---
  include/configs/omap3_sdp3430.h |   10 --
  include/configs/omap3_zoom1.h   |   16 +---
  include/configs/omap3_zoom2.h   |   16 +---
  11 files changed, 49 insertions(+), 143 deletions(-)
 


Can you please rebase with u-boot-ti?

Also there is a new board am 3517 crane

http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commitdiff;h=29ffd724e25f0cf456d1971e8c1c6567ebbd4818

Can you include this in your patch as well?

Regards,
Sandeep
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v4 2/4] ARMV7: OMAP3: Cleanup extern variables in mem.c

2011-04-15 Thread Luca Ceresoli
Removed boot_flash_* extern variables.
boot_flash_type was totally unused. The other ones were actually constants, so
they have been replaced with #defines in the board config files.

Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v4:
 - this patch is new in v4.

 arch/arm/cpu/armv7/omap3/mem.c  |   32 
 include/configs/am3517_evm.h|   18 ++
 include/configs/cm_t35.h|   16 +---
 include/configs/devkit8000.h|   10 +-
 include/configs/omap3_beagle.h  |   16 +---
 include/configs/omap3_evm.h |   26 --
 include/configs/omap3_overo.h   |   16 +---
 include/configs/omap3_pandora.h |   16 +---
 include/configs/omap3_sdp3430.h |   10 --
 include/configs/omap3_zoom1.h   |   16 +---
 include/configs/omap3_zoom2.h   |   16 +---
 11 files changed, 49 insertions(+), 143 deletions(-)

diff --git a/arch/arm/cpu/armv7/omap3/mem.c b/arch/arm/cpu/armv7/omap3/mem.c
index bd914b0..a01c303 100644
--- a/arch/arm/cpu/armv7/omap3/mem.c
+++ b/arch/arm/cpu/armv7/omap3/mem.c
@@ -31,16 +31,6 @@
 #include asm/arch/sys_proto.h
 #include command.h
 
-/*
- * Only One NAND allowed on board at a time.
- * The GPMC CS Base for the same
- */
-unsigned int boot_flash_base;
-unsigned int boot_flash_off;
-unsigned int boot_flash_sec;
-unsigned int boot_flash_type;
-volatile unsigned int boot_flash_env_addr;
-
 struct gpmc *gpmc_cfg;
 
 #if defined(CONFIG_CMD_NAND)
@@ -134,10 +124,6 @@ void gpmc_init(void)
const u32 *gpmc_config = NULL;
u32 base = 0;
u32 size = 0;
-#if defined(CONFIG_ENV_IS_IN_NAND) || defined(CONFIG_ENV_IS_IN_ONENAND)
-   u32 f_off = CONFIG_SYS_MONITOR_LEN;
-   u32 f_sec = 0;
-#endif
 #endif
u32 config = 0;
 
@@ -162,15 +148,6 @@ void gpmc_init(void)
base = PISMO1_NAND_BASE;
size = PISMO1_NAND_SIZE;
enable_gpmc_cs_config(gpmc_config, gpmc_cfg-cs[0], base, size);
-#if defined(CONFIG_ENV_IS_IN_NAND)
-   f_off = SMNAND_ENV_OFFSET;
-   f_sec = (128  10);/* 128 KiB */
-   /* env setup */
-   boot_flash_base = base;
-   boot_flash_off = f_off;
-   boot_flash_sec = f_sec;
-   boot_flash_env_addr = f_off;
-#endif
 #endif
 
 #if defined(CONFIG_CMD_ONENAND)
@@ -178,14 +155,5 @@ void gpmc_init(void)
base = PISMO1_ONEN_BASE;
size = PISMO1_ONEN_SIZE;
enable_gpmc_cs_config(gpmc_config, gpmc_cfg-cs[0], base, size);
-#if defined(CONFIG_ENV_IS_IN_ONENAND)
-   f_off = ONENAND_ENV_OFFSET;
-   f_sec = (128  10);/* 128 KiB */
-   /* env setup */
-   boot_flash_base = base;
-   boot_flash_off = f_off;
-   boot_flash_sec = f_sec;
-   boot_flash_env_addr = f_off;
-#endif
 #endif
 }
diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
index 70e8f07..f5d5821 100644
--- a/include/configs/am3517_evm.h
+++ b/include/configs/am3517_evm.h
@@ -294,7 +294,9 @@
 #define CONFIG_SYS_MAX_FLASH_BANKS 2   /* max number of flash banks */
 #define CONFIG_SYS_MONITOR_LEN (256  10) /* Reserve 2 sectors */
 
-#define CONFIG_SYS_FLASH_BASE  boot_flash_base
+#if defined(CONFIG_CMD_NAND)
+#define CONFIG_SYS_FLASH_BASE  PISMO1_NAND_BASE
+#endif
 
 /* Monitor at start of flash */
 #define CONFIG_SYS_MONITOR_BASECONFIG_SYS_FLASH_BASE
@@ -304,9 +306,9 @@
 #define CONFIG_ENV_IS_IN_NAND  1
 #define SMNAND_ENV_OFFSET  0x26 /* environment starts here */
 
-#define CONFIG_SYS_ENV_SECT_SIZE   boot_flash_sec
-#define CONFIG_ENV_OFFSET  boot_flash_off
-#define CONFIG_ENV_ADDRboot_flash_env_addr
+#define CONFIG_SYS_ENV_SECT_SIZE   (128  10) /* 128 KiB */
+#define CONFIG_ENV_OFFSET  SMNAND_ENV_OFFSET
+#define CONFIG_ENV_ADDRSMNAND_ENV_OFFSET
 
 /*---
  * CFI FLASH driver setup
@@ -323,14 +325,6 @@
 #define CONFIG_SYS_JFFS2_FIRST_BANKCONFIG_SYS_MAX_FLASH_BANKS
 #define CONFIG_SYS_JFFS2_NUM_BANKS 1
 
-#ifndef __ASSEMBLY__
-extern unsigned int boot_flash_base;
-extern volatile unsigned int boot_flash_env_addr;
-extern unsigned int boot_flash_off;
-extern unsigned int boot_flash_sec;
-extern unsigned int boot_flash_type;
-#endif
-
 #define CONFIG_SYS_SDRAM_BASE  PHYS_SDRAM_1
 #define CONFIG_SYS_INIT_RAM_ADDR   0x4020f800
 #define CONFIG_SYS_INIT_RAM_SIZE   0x800
diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h
index 510c6d4..ee9175d 100644
--- a/include/configs/cm_t35.h
+++ b/include/configs/cm_t35.h
@@ -310,7 +310,9 @@
 
 #define CONFIG_SYS_MONITOR_LEN (256  10) /* Reserve 2 sectors */
 
-#define CONFIG_SYS_FLASH_BASE