Re: [U-Boot] [PATCH v4 3/3] musb_udc : Fix compile warning.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/15/12 22:43, Marek Vasut wrote: Lets just drop this patch. The whole series if still in patchwork should be superseded by the work Ilya is doing for MUSB. - -- Tom -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQfXBLAAoJENk4IS6UOR1WpqoQAJXf8eI46hYnDEi0USaiErml FEBVR3gn+PjQBTFmZHV+x7CXrNtr7knMht5xV/EFYVhnMUuNAHMRH8Txbcp01FSf VM4nZtTIRYvEknkY4vDdqu+xv5xjc8mNiPfyrjkefjMkCIETFWKc0N7bBdlKhyOs PNSkCybZ7dB6Rpicu1Xls+9B+TIUdAiqCvMnJtumcwYx5M6IkXVQS0I1RcMBFjEt M0oQ7AtsYcVTCO9A1H/m+AEk6egUjEmqSz1lxHm5/TGf5O+54jn+GK2WPwsZhj6Y pamdOuKNx3AjQifzZTs71Is2WEpCsSd6InHrx3+LKjLBcio3pHJVlbxJ+DnWO7XY stc3WCXrM6681kJKhmJDbCbQWN+gbo2vm/HIlYgTlhLg3cDGOjoOvVOOwLZGmLRJ YRU6vnxDoLwCIfjLwVgp1vLwox6jTLjGPoUQK30KeBQxDePO2+PpLuxirsdLmLEa Vxw9Qz9m9k4/C1mW/p0ySgFEMe6xpXtg1w8LbYQSVA3da5z6pfkIkbi+sQzNB+dF NHLl/xST9UnCPX9DGOzsUClw/gpXmoIlNoisoUIRXZ771ENSyLpmrhrET2MUO6NT zTt7maQjQZmOOAKNeNPQmm4RCmSQmDOjpacfKBvCHUblKg77qHJGUuE7RR7X+39H /UQ1037H2OBgvc1NnsSV =fPvR -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 3/3] musb_udc : Fix compile warning.
Dear Harman Sohanpal, > Fix the compile warning : > implicit declaration of musb_platform_init > when CONFIG_MUSB_UDC is defined. > The extern musb_platform_init was declared in musb_hcd.h > but no such extern function was declared for musb_udc. > So a common function has been declared in musb_core.h > which can be used for both host mode and device mode. > > Signed-off-by: Harman Sohanpal [...] Tom, what's the status? I dont see the warning. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 3/3] musb_udc : Fix compile warning.
Fix the compile warning : implicit declaration of musb_platform_init when CONFIG_MUSB_UDC is defined. The extern musb_platform_init was declared in musb_hcd.h but no such extern function was declared for musb_udc. So a common function has been declared in musb_core.h which can be used for both host mode and device mode. Signed-off-by: Harman Sohanpal --- Changes for v2: - none Changes for v3: - none Changes for v4: - none drivers/usb/musb/musb_core.h |2 ++ drivers/usb/musb/musb_hcd.h |3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h index a8adcce..14253f0 100644 --- a/drivers/usb/musb/musb_core.h +++ b/drivers/usb/musb/musb_core.h @@ -360,6 +360,8 @@ extern void musb_start(void); extern void musb_configure_ep(const struct musb_epinfo *epinfo, u8 cnt); extern void write_fifo(u8 ep, u32 length, void *fifo_data); extern void read_fifo(u8 ep, u32 length, void *fifo_data); +extern int musb_platform_init(void); +extern void musb_platform_deinit(void); #if defined(CONFIG_USB_BLACKFIN) /* Every USB register is accessed as a 16-bit even if the value itself diff --git a/drivers/usb/musb/musb_hcd.h b/drivers/usb/musb/musb_hcd.h index dde7d37..5621f7e 100644 --- a/drivers/usb/musb/musb_hcd.h +++ b/drivers/usb/musb/musb_hcd.h @@ -105,8 +105,5 @@ extern unsigned char new[]; #define RH_REQ_ERR-1 #define RH_NACK 0x00 -/* extern functions */ -extern int musb_platform_init(void); -extern void musb_platform_deinit(void); #endif /* __MUSB_HCD_H__ */ -- 1.7.0.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
