[U-Boot] [PATCH v4 4/4] net: designware: Add reset ctrl to driver

2018-06-01 Thread Ley Foon Tan
Add code to reset all reset signals as in Ethernet DT node. A reset property is 
an optional feature,
so only print out a warning and do not fail if a reset property is not present.

If a reset property is discovered, then use it to deassert, thus bringing the
IP out of reset.

Signed-off-by: Ley Foon Tan 
---
 drivers/net/designware.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index cf12521..6797691 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -664,6 +665,7 @@ int designware_eth_probe(struct udevice *dev)
u32 iobase = pdata->iobase;
ulong ioaddr;
int ret;
+   struct reset_ctl_bulk reset_bulk;
 #ifdef CONFIG_CLK
int i, err, clock_nb;
 
@@ -710,6 +712,12 @@ int designware_eth_probe(struct udevice *dev)
}
 #endif
 
+   ret = reset_get_bulk(dev, &reset_bulk);
+   if (ret)
+   dev_warn(dev, "Can't get reset: %d\n", ret);
+   else
+   reset_deassert_bulk(&reset_bulk);
+
 #ifdef CONFIG_DM_PCI
/*
 * If we are on PCI bus, either directly attached to a PCI root port,
-- 
2.2.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH v4 4/4] net: designware: Add reset ctrl to driver

2018-06-12 Thread Joe Hershberger
On Fri, Jun 1, 2018 at 3:45 AM, Ley Foon Tan  wrote:
> Add code to reset all reset signals as in Ethernet DT node. A reset property 
> is an optional feature,
> so only print out a warning and do not fail if a reset property is not 
> present.
>
> If a reset property is discovered, then use it to deassert, thus bringing the
> IP out of reset.
>
> Signed-off-by: Ley Foon Tan 

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH v4 4/4] net: designware: Add reset ctrl to driver

2018-06-01 Thread Simon Glass
On 1 June 2018 at 02:45, Ley Foon Tan  wrote:
> Add code to reset all reset signals as in Ethernet DT node. A reset property 
> is an optional feature,
> so only print out a warning and do not fail if a reset property is not 
> present.
>
> If a reset property is discovered, then use it to deassert, thus bringing the
> IP out of reset.
>
> Signed-off-by: Ley Foon Tan 
> ---
>  drivers/net/designware.c | 8 
>  1 file changed, 8 insertions(+)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot