Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver
Hi Tom, On Mon, Feb 27, 2012 at 1:44 PM, Tom Warren wrote: > Marek/Simon, > >> -Original Message- >> From: Marek Vasut [mailto:marek.va...@gmail.com] >> Sent: Monday, February 27, 2012 1:55 PM >> To: u-boot@lists.denx.de >> Cc: Simon Glass; Tom Warren >> Subject: Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB >> driver >> >> > Hi, >> > >> > On Sun, Feb 26, 2012 at 7:02 PM, Simon Glass wrote: >> > > Hi Marek, >> > > >> > > On Sun, Feb 26, 2012 at 3:13 PM, Marek Vasut wrote: >> > >>> This series brings in the Linux kernel fdt file and provides a >> > >>> working USB driver for Tegra2 Seaboard. >> > >>> >> > >>> (I have done this in one series since otherwise most of the fdt >> > >>> additions will just look like dead code.) >> > >>> >> > >>> The driver requires CONFIG_OF_CONTROL and a device tree to operate. >> > >>> >> > >>> Some enhancements to fdtdec are required to make this easier, and >> > >>> these are included in the series also. I have had to bring in >> > >>> basic GPIO support due to the request to put the USB VBUS into the >> fdt. >> > >>> >> > >>> Since the kernel recently got a very minimal USB binding, I have >> > >>> started with that and extended it where appropriate. >> > >>> >> > >>> Tegra likes to have cache-aligned buffers. I have dropped the >> > >>> patch which implements this since we will solve this problem by >> > >>> making callers align their buffers (as we did with MMC). >> > >> >> > >> Hi, >> > >> >> > >> what's the status of this patch/patchset? >> > > >> > > Superceded, v6 is on its way in the next few days. >> > >> > I am about to send v6. Due to the way things are organized, 6 of that >> > patches have changed. I have also dropped the fdt alignment one. So I >> > think it is safest to resend the whole 20-patch series again. >> > >> > Regards, >> > Simon >> >> Please wait until wednesday with the submission until we sort out the usb >> maintainership and until the most significant USB changes find their way >> into mainline uboot. >> > > For those that don't want to wait, I've applied this patch series to > u-boot-tegra/test and pushed to denx. > > Simon - seems to work fine - USB->NET dongle, USB mouse, and USB stick all > detected OK, both directly and behind the hub on the USB->NET dongle (Asix > 3-port hub w/Ethernet adapter). OK thanks, good. Hoping that Puneet's alignment fixes can go in soon also. > > I'll wait a couple of days for the reviews & USB issues to sort themselves > out before doing a pull request to Albert for ARM, but I want to get this in > so I can move forward with the other Tegra2 drivers (I2C, LCD, kbd, etc.) > that depend on fdt/DT. I will have to do an update to i2c sorry, due to Stephen's clock binding changes. Yes I know it is acked and ready, but it will not work now. Wil try to do that today. After that is warmboot - have you taken a look at that? Regards, Simon > > Tom > > -- > nvpublic > >> Thanks in advance >> M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver
Marek/Simon, > -Original Message- > From: Marek Vasut [mailto:marek.va...@gmail.com] > Sent: Monday, February 27, 2012 1:55 PM > To: u-boot@lists.denx.de > Cc: Simon Glass; Tom Warren > Subject: Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB > driver > > > Hi, > > > > On Sun, Feb 26, 2012 at 7:02 PM, Simon Glass wrote: > > > Hi Marek, > > > > > > On Sun, Feb 26, 2012 at 3:13 PM, Marek Vasut wrote: > > >>> This series brings in the Linux kernel fdt file and provides a > > >>> working USB driver for Tegra2 Seaboard. > > >>> > > >>> (I have done this in one series since otherwise most of the fdt > > >>> additions will just look like dead code.) > > >>> > > >>> The driver requires CONFIG_OF_CONTROL and a device tree to operate. > > >>> > > >>> Some enhancements to fdtdec are required to make this easier, and > > >>> these are included in the series also. I have had to bring in > > >>> basic GPIO support due to the request to put the USB VBUS into the > fdt. > > >>> > > >>> Since the kernel recently got a very minimal USB binding, I have > > >>> started with that and extended it where appropriate. > > >>> > > >>> Tegra likes to have cache-aligned buffers. I have dropped the > > >>> patch which implements this since we will solve this problem by > > >>> making callers align their buffers (as we did with MMC). > > >> > > >> Hi, > > >> > > >> what's the status of this patch/patchset? > > > > > > Superceded, v6 is on its way in the next few days. > > > > I am about to send v6. Due to the way things are organized, 6 of that > > patches have changed. I have also dropped the fdt alignment one. So I > > think it is safest to resend the whole 20-patch series again. > > > > Regards, > > Simon > > Please wait until wednesday with the submission until we sort out the usb > maintainership and until the most significant USB changes find their way > into mainline uboot. > For those that don't want to wait, I've applied this patch series to u-boot-tegra/test and pushed to denx. Simon - seems to work fine - USB->NET dongle, USB mouse, and USB stick all detected OK, both directly and behind the hub on the USB->NET dongle (Asix 3-port hub w/Ethernet adapter). I'll wait a couple of days for the reviews & USB issues to sort themselves out before doing a pull request to Albert for ARM, but I want to get this in so I can move forward with the other Tegra2 drivers (I2C, LCD, kbd, etc.) that depend on fdt/DT. Tom -- nvpublic > Thanks in advance > M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver
> Hi, > > On Sun, Feb 26, 2012 at 7:02 PM, Simon Glass wrote: > > Hi Marek, > > > > On Sun, Feb 26, 2012 at 3:13 PM, Marek Vasut wrote: > >>> This series brings in the Linux kernel fdt file and provides a working > >>> USB driver for Tegra2 Seaboard. > >>> > >>> (I have done this in one series since otherwise most of the fdt > >>> additions will just look like dead code.) > >>> > >>> The driver requires CONFIG_OF_CONTROL and a device tree to operate. > >>> > >>> Some enhancements to fdtdec are required to make this easier, and these > >>> are included in the series also. I have had to bring in basic GPIO > >>> support due to the request to put the USB VBUS into the fdt. > >>> > >>> Since the kernel recently got a very minimal USB binding, I have > >>> started with that and extended it where appropriate. > >>> > >>> Tegra likes to have cache-aligned buffers. I have dropped the patch > >>> which implements this since we will solve this problem by making > >>> callers align their buffers (as we did with MMC). > >> > >> Hi, > >> > >> what's the status of this patch/patchset? > > > > Superceded, v6 is on its way in the next few days. > > I am about to send v6. Due to the way things are organized, 6 of that > patches have changed. I have also dropped the fdt alignment one. So I > think it is safest to resend the whole 20-patch series again. > > Regards, > Simon Please wait until wednesday with the submission until we sort out the usb maintainership and until the most significant USB changes find their way into mainline uboot. Thanks in advance M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver
Hi, On Sun, Feb 26, 2012 at 7:02 PM, Simon Glass wrote: > Hi Marek, > > On Sun, Feb 26, 2012 at 3:13 PM, Marek Vasut wrote: >>> This series brings in the Linux kernel fdt file and provides a working >>> USB driver for Tegra2 Seaboard. >>> >>> (I have done this in one series since otherwise most of the fdt additions >>> will just look like dead code.) >>> >>> The driver requires CONFIG_OF_CONTROL and a device tree to operate. >>> >>> Some enhancements to fdtdec are required to make this easier, and these >>> are included in the series also. I have had to bring in basic GPIO >>> support due to the request to put the USB VBUS into the fdt. >>> >>> Since the kernel recently got a very minimal USB binding, I have started >>> with that and extended it where appropriate. >>> >>> Tegra likes to have cache-aligned buffers. I have dropped the patch which >>> implements this since we will solve this problem by making callers align >>> their buffers (as we did with MMC). >>> >> >> Hi, >> >> what's the status of this patch/patchset? > > Superceded, v6 is on its way in the next few days. > I am about to send v6. Due to the way things are organized, 6 of that patches have changed. I have also dropped the fdt alignment one. So I think it is safest to resend the whole 20-patch series again. Regards, Simon >> >> Thanks >> M > > Regards, > Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver
Hi Marek, On Sun, Feb 26, 2012 at 3:13 PM, Marek Vasut wrote: >> This series brings in the Linux kernel fdt file and provides a working >> USB driver for Tegra2 Seaboard. >> >> (I have done this in one series since otherwise most of the fdt additions >> will just look like dead code.) >> >> The driver requires CONFIG_OF_CONTROL and a device tree to operate. >> >> Some enhancements to fdtdec are required to make this easier, and these >> are included in the series also. I have had to bring in basic GPIO >> support due to the request to put the USB VBUS into the fdt. >> >> Since the kernel recently got a very minimal USB binding, I have started >> with that and extended it where appropriate. >> >> Tegra likes to have cache-aligned buffers. I have dropped the patch which >> implements this since we will solve this problem by making callers align >> their buffers (as we did with MMC). >> > > Hi, > > what's the status of this patch/patchset? Superceded, v6 is on its way in the next few days. > > Thanks > M Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver
> This series brings in the Linux kernel fdt file and provides a working > USB driver for Tegra2 Seaboard. > > (I have done this in one series since otherwise most of the fdt additions > will just look like dead code.) > > The driver requires CONFIG_OF_CONTROL and a device tree to operate. > > Some enhancements to fdtdec are required to make this easier, and these > are included in the series also. I have had to bring in basic GPIO > support due to the request to put the USB VBUS into the fdt. > > Since the kernel recently got a very minimal USB binding, I have started > with that and extended it where appropriate. > > Tegra likes to have cache-aligned buffers. I have dropped the patch which > implements this since we will solve this problem by making callers align > their buffers (as we did with MMC). > Hi, what's the status of this patch/patchset? Thanks M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 0/18] tegra: Add fdt definitions and USB driver
This series brings in the Linux kernel fdt file and provides a working USB driver for Tegra2 Seaboard. (I have done this in one series since otherwise most of the fdt additions will just look like dead code.) The driver requires CONFIG_OF_CONTROL and a device tree to operate. Some enhancements to fdtdec are required to make this easier, and these are included in the series also. I have had to bring in basic GPIO support due to the request to put the USB VBUS into the fdt. Since the kernel recently got a very minimal USB binding, I have started with that and extended it where appropriate. Tegra likes to have cache-aligned buffers. I have dropped the patch which implements this since we will solve this problem by making callers align their buffers (as we did with MMC). Changes in v2: - Add setting of pinmux for USB VBUS GPIO - Decode USB VBUS GPIO from the fdt - Decode phy type differently (to match new kernel fdt) - Improve debug() printouts in case of failure to init USB - Remove 0x from fdt aliases - Remove non-fdt operation of USB, since it is not needed - Remove unneeded CONFIG_TEGRA_USBx defines - Rename params to timing - Rename tegra20-usb to tegra20-ehcui (to match new kernel fdt) - Store entire fdt config in port list, not just register pointer - Use "okay" instead of "ok" for fdt node status Changes in v3: - Disable USB2 which is not used on Seaboard - Drop Tegra USB alignment patch as we will deal with this another way - Fix device tree indenting with tabs instead of spaces - Remove "okay" from nodes since this is the default anyway - Remove usbparams properties from fdt and moved them to C code Changes in v4: - Add clock bindings for Tegra2x - Add fdtdec function to return peripheral ID - Add staging area for device tree bindings used in U-Boot - Use peripheral clock node to obtain peripheral ID - Use updated fdtdec alias functiona to get USB aliases Changes in v5: - Add CONFIG_EHCI_DCACHE which is needed for dcache operation - Add additional debugging to report active USB ports - Add dr_mode property to control host/device/otg mode - Add nvidia,has-legacy-mode property per review comments - Allow any port to operate in otg mode - Change device tree comment style from // to /* */ - Correct PTS_MASK value to be unsigned - Drop unused CONFIG_USB_EHCI_DATA_ALIGN option - Fixed endian bug in fdtdec_decode_gpios() - Implement new device tree properties - Make sure GPIO name is NULL if incorrectly decoded - Put pinmux setting into a board-specific function - Remove checking of peripheral ID and try to use only device tree - Remove support-host-mode property - Report error if phy clock does not start up - Update README to indicate that we will commit fdt documentation to U-Boot Simon Glass (18): fdt: Add basic support for decoding GPIO definitions arm: fdt: Ensure that an embedded fdt is word-aligned arm: fdt: Add skeleton device tree file from kernel tegra: fdt: Add Tegra2x device tree file from kernel tegra: fdt: Add device tree file for Tegra2 Seaboard from kernel fdt: Add staging area for device tree binding documentation fdt: Add tegra-usb bindings file from linux tegra: fdt: Add additional USB binding tegra: fdt: Add clock bindings tegra: usb: fdt: Add additional device tree definitions for USB ports tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard usb: Add support for txfifo threshold fdt: Add function to return peripheral/clock ID tegra: usb: Add support for Tegra USB peripheral tegra: usb: Add USB support to nvidia boards tegra: usb: Add common USB defines for tegra2 boards tegra: usb: Enable USB on Seaboard tegra: fdt: Enable FDT support for Seaboard README |3 + arch/arm/cpu/armv7/tegra2/Makefile |4 +- arch/arm/cpu/armv7/tegra2/config.mk|2 + arch/arm/cpu/armv7/tegra2/usb.c| 460 arch/arm/cpu/armv7/u-boot.lds |5 + arch/arm/dts/skeleton.dtsi | 13 + arch/arm/dts/tegra20.dtsi | 202 +++ arch/arm/include/asm/arch-tegra2/tegra2.h |2 + arch/arm/include/asm/arch-tegra2/usb.h | 252 + board/nvidia/common/board.c| 12 + board/nvidia/common/board.h|6 + board/nvidia/dts/tegra2-seaboard.dts | 46 +++ board/nvidia/seaboard/seaboard.c |6 + doc/device-tree-bindings/README| 17 + doc/device-tree-bindings/clock/tegra-periphclk | 51 +++ doc/device-tree-bindings/usb/tegra-usb.txt | 25 ++ drivers/usb/host/Makefile |1 + drivers/usb/host/ehci-hcd.c|7 + drivers/usb/host/ehci-tegra.c | 62 drivers/usb/host/ehci.h|6 +- dts/Makefile |2 +- include/configs/seaboard.h | 12 + in
