Re: [U-Boot] [PATCH v6 06/31] mtd: fix build issue with includes
On Thu, 16 Aug 2018 17:33:18 +0200 Boris Brezillon wrote: > On Thu, 16 Aug 2018 17:30:04 +0200 > Miquel Raynal wrote: > > > Fix build errors produced by mtd.h and dm/device.h if not included in > > the right order. > > > > Signed-off-by: Miquel Raynal > > Reviewed-by: Jagan Teki > > I'm pretty sure this patch is not needed, the build failure has been > fixed in patch 5. My bad. It's needed, but it should be squashed in patch 5, since this is patch 5 who introduces the error. > > > --- > > include/linux/mtd/mtd.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h > > index 73b19b57b1..272c646f9d 100644 > > --- a/include/linux/mtd/mtd.h > > +++ b/include/linux/mtd/mtd.h > > @@ -21,6 +21,9 @@ > > #include > > #include > > #include > > +#if IS_ENABLED(CONFIG_DM) > > +#include > > +#endif > > > > #define MAX_MTD_DEVICES 32 > > #endif > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 06/31] mtd: fix build issue with includes
On Thu, 16 Aug 2018 17:30:04 +0200 Miquel Raynal wrote: > Fix build errors produced by mtd.h and dm/device.h if not included in > the right order. > > Signed-off-by: Miquel Raynal > Reviewed-by: Jagan Teki I'm pretty sure this patch is not needed, the build failure has been fixed in patch 5. > --- > include/linux/mtd/mtd.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h > index 73b19b57b1..272c646f9d 100644 > --- a/include/linux/mtd/mtd.h > +++ b/include/linux/mtd/mtd.h > @@ -21,6 +21,9 @@ > #include > #include > #include > +#if IS_ENABLED(CONFIG_DM) > +#include > +#endif > > #define MAX_MTD_DEVICES 32 > #endif ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v6 06/31] mtd: fix build issue with includes
Fix build errors produced by mtd.h and dm/device.h if not included in the right order. Signed-off-by: Miquel Raynal Reviewed-by: Jagan Teki --- include/linux/mtd/mtd.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h index 73b19b57b1..272c646f9d 100644 --- a/include/linux/mtd/mtd.h +++ b/include/linux/mtd/mtd.h @@ -21,6 +21,9 @@ #include #include #include +#if IS_ENABLED(CONFIG_DM) +#include +#endif #define MAX_MTD_DEVICES 32 #endif -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
