Re: [U-Boot] [PATCHv1 08/22] arm: socfpga: spl: Add call to timer_init

[Dinh Nguyen]

On 1/14/15 5:45 PM, Marek Vasut wrote:
> On Wednesday, January 14, 2015 at 05:40:48 PM, dingu...@opensource.altera.com 
> wrote:
>> From: Dinh Nguyen 
>>
>> Signed-off-by: Dinh Nguyen 
> 
> You might want to check common/spl/spl.c , which implements most of the 
> standard
> SPL init procedure. It even includes the call to timer_init() there in 
> board_init_r() . I wonder if you really need to call it here one more time.
> Do you ?
> 

Your logic makes sense, but I think this timer_init() call in
spl_board_init() is needed. The reason is that we are releasing the
timer from reset in spl_board_init, and timer_init is getting called
before spl_board_init. If I take out this timer_init, the SPL doesn't
work so well.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCHv1 08/22] arm: socfpga: spl: Add call to timer_init

[Marek Vasut]

On Wednesday, January 14, 2015 at 05:40:48 PM, dingu...@opensource.altera.com 
wrote:
> From: Dinh Nguyen 
> 
> Signed-off-by: Dinh Nguyen 

You might want to check common/spl/spl.c , which implements most of the standard
SPL init procedure. It even includes the call to timer_init() there in 
board_init_r() . I wonder if you really need to call it here one more time.
Do you ?

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCHv1 08/22] arm: socfpga: spl: Add call to timer_init

[dinguyen]

From: Dinh Nguyen 

Signed-off-by: Dinh Nguyen 
---
 arch/arm/cpu/armv7/socfpga/spl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
index b123336..bc6f8dd 100644
--- a/arch/arm/cpu/armv7/socfpga/spl.c
+++ b/arch/arm/cpu/armv7/socfpga/spl.c
@@ -149,6 +149,8 @@ void spl_board_init(void)
socfpga_uart0_enable();
socfpga_osc1timer_enable();
 
+   timer_init();
+
debug("Reconfigure Clock Manager\n");
/* reconfigure the PLLs */
cm_basic_init(&cm_default_cfg);
-- 
2.2.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot