Re: [U-Boot] [RESEND PATCH 8/9] defconfig: k2e_hs_evm: Add k2e_hs_evm_defconfig

2017-03-02 Thread Simon Glass
On 28 February 2017 at 10:58, Tom Rini  wrote:
> On Tue, Feb 28, 2017 at 11:47:01AM -0600, Andrew F. Davis wrote:
>> On 02/27/2017 09:19 AM, Tom Rini wrote:
>> > On Fri, Feb 24, 2017 at 06:59:45AM -0600, Andrew F. Davis wrote:
>> >
>> >> From: Vitaly Andrianov 
>> >>
>> >> TI K2E secure devices have to be built with TI_SECURE_DEVICE, FIT, and
>> >> FIT_IMAGE_POST_PROCESS enabled. Add a dedicated defconfig for this.
>> >>
>> >> Signed-off-by: Vitaly Andrianov 
>> >> Signed-off-by: Madan Srinivas 
>> >> Signed-off-by: Andrew F. Davis 
>> >> ---
>> >>  configs/k2e_hs_evm_defconfig | 51 
>> >> 
>> >>  1 file changed, 51 insertions(+)
>> >>  create mode 100644 configs/k2e_hs_evm_defconfig
>> >>
>> >> diff --git a/configs/k2e_hs_evm_defconfig b/configs/k2e_hs_evm_defconfig
>> >> new file mode 100644
>> >> index 00..d515cedaca
>> >> --- /dev/null
>> >> +++ b/configs/k2e_hs_evm_defconfig
>> >> @@ -0,0 +1,51 @@
>> >> +CONFIG_ARM=y
>> >> +CONFIG_ARCH_KEYSTONE=y
>> >> +CONFIG_SYS_TEXT_BASE=0x0c60
>> >> +CONFIG_TARGET_K2E_EVM=y
>> >> +CONFIG_TI_SECURE_DEVICE=y
>> >> +CONFIG_DEFAULT_DEVICE_TREE="keystone-k2e-evm"
>> >> +CONFIG_FIT=y
>> >> +CONFIG_FIT_IMAGE_POST_PROCESS=y
>> >> +CONFIG_OF_BOARD_SETUP=y
>> >> +CONFIG_SYS_CONSOLE_INFO_QUIET=y
>> >> +CONFIG_VERSION_VARIABLE=y
>> >> +CONFIG_HUSH_PARSER=y
>> >> +CONFIG_SYS_PROMPT="K2E HS EVM # "
>> >> +CONFIG_CMD_BOOTZ=y
>> >> +# CONFIG_CMD_IMLS is not set
>> >> +CONFIG_CMD_ASKENV=y
>> >> +# CONFIG_CMD_FLASH is not set
>> >> +CONFIG_CMD_NAND=y
>> >> +CONFIG_CMD_PART=y
>> >> +CONFIG_CMD_SF=y
>> >> +CONFIG_CMD_SPI=y
>> >> +CONFIG_CMD_I2C=y
>> >> +CONFIG_CMD_USB=y
>> >> +# CONFIG_CMD_SETEXPR is not set
>> >> +CONFIG_CMD_DHCP=y
>> >> +CONFIG_CMD_MII=y
>> >> +CONFIG_CMD_PING=y
>> >> +CONFIG_CMD_EXT2=y
>> >> +CONFIG_CMD_EXT4=y
>> >> +CONFIG_CMD_EXT4_WRITE=y
>> >> +CONFIG_CMD_FAT=y
>> >> +CONFIG_CMD_FS_GENERIC=y
>> >> +CONFIG_CMD_UBI=y
>> >> +CONFIG_ISO_PARTITION=y
>> >> +CONFIG_EFI_PARTITION=y
>> >> +CONFIG_OF_CONTROL=y
>> >> +CONFIG_NET_RANDOM_ETHADDR=y
>> >> +CONFIG_DM=y
>> >> +CONFIG_TI_AEMIF=y
>> >> +# CONFIG_MMC is not set
>> >> +CONFIG_DM_SPI_FLASH=y
>> >> +CONFIG_SPI_FLASH=y
>> >> +CONFIG_SPI_FLASH_STMICRO=y
>> >> +CONFIG_DM_ETH=y
>> >> +CONFIG_DM_SERIAL=y
>> >> +CONFIG_SYS_NS16550=y
>> >> +CONFIG_DM_SPI=y
>> >> +CONFIG_USB=y
>> >> +CONFIG_USB_XHCI_HCD=y
>> >> +CONFIG_USB_XHCI_DWC3=y
>> >> +CONFIG_USB_STORAGE=y
>> >
>> > This shows a number of the will-be-problems like the AM43/AM33 devices
>> > have.  More things need to be select'd and imply'd so that the _hs_
>> > variant defconfigs do not get out of sync easily and often.
>> >
>>
>> I do not think selecting all these options in Kconfig files is safe
>> right now, at least until moving some more symbols to Kconfig is
>> complete. After that we can add proper dependencies to all the symbols
>> and some things like _CMD_ symbols could be added automatically.
>>
>> Defconfigs are easier to cleanup than Kconfig definitions. I do not want
>> to maintain the per-platform Kconfig select'd list before we get symbol
>> dependencies worked out.
>
> Well, at the end of the day, the pain is on you on re-syncing the
> defconfig files, so if you want to wait on adding more logic, OK, I'll
> remove my objection.

OK

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [RESEND PATCH 8/9] defconfig: k2e_hs_evm: Add k2e_hs_evm_defconfig

2017-02-28 Thread Tom Rini
On Tue, Feb 28, 2017 at 11:47:01AM -0600, Andrew F. Davis wrote:
> On 02/27/2017 09:19 AM, Tom Rini wrote:
> > On Fri, Feb 24, 2017 at 06:59:45AM -0600, Andrew F. Davis wrote:
> > 
> >> From: Vitaly Andrianov 
> >>
> >> TI K2E secure devices have to be built with TI_SECURE_DEVICE, FIT, and
> >> FIT_IMAGE_POST_PROCESS enabled. Add a dedicated defconfig for this.
> >>
> >> Signed-off-by: Vitaly Andrianov 
> >> Signed-off-by: Madan Srinivas 
> >> Signed-off-by: Andrew F. Davis 
> >> ---
> >>  configs/k2e_hs_evm_defconfig | 51 
> >> 
> >>  1 file changed, 51 insertions(+)
> >>  create mode 100644 configs/k2e_hs_evm_defconfig
> >>
> >> diff --git a/configs/k2e_hs_evm_defconfig b/configs/k2e_hs_evm_defconfig
> >> new file mode 100644
> >> index 00..d515cedaca
> >> --- /dev/null
> >> +++ b/configs/k2e_hs_evm_defconfig
> >> @@ -0,0 +1,51 @@
> >> +CONFIG_ARM=y
> >> +CONFIG_ARCH_KEYSTONE=y
> >> +CONFIG_SYS_TEXT_BASE=0x0c60
> >> +CONFIG_TARGET_K2E_EVM=y
> >> +CONFIG_TI_SECURE_DEVICE=y
> >> +CONFIG_DEFAULT_DEVICE_TREE="keystone-k2e-evm"
> >> +CONFIG_FIT=y
> >> +CONFIG_FIT_IMAGE_POST_PROCESS=y
> >> +CONFIG_OF_BOARD_SETUP=y
> >> +CONFIG_SYS_CONSOLE_INFO_QUIET=y
> >> +CONFIG_VERSION_VARIABLE=y
> >> +CONFIG_HUSH_PARSER=y
> >> +CONFIG_SYS_PROMPT="K2E HS EVM # "
> >> +CONFIG_CMD_BOOTZ=y
> >> +# CONFIG_CMD_IMLS is not set
> >> +CONFIG_CMD_ASKENV=y
> >> +# CONFIG_CMD_FLASH is not set
> >> +CONFIG_CMD_NAND=y
> >> +CONFIG_CMD_PART=y
> >> +CONFIG_CMD_SF=y
> >> +CONFIG_CMD_SPI=y
> >> +CONFIG_CMD_I2C=y
> >> +CONFIG_CMD_USB=y
> >> +# CONFIG_CMD_SETEXPR is not set
> >> +CONFIG_CMD_DHCP=y
> >> +CONFIG_CMD_MII=y
> >> +CONFIG_CMD_PING=y
> >> +CONFIG_CMD_EXT2=y
> >> +CONFIG_CMD_EXT4=y
> >> +CONFIG_CMD_EXT4_WRITE=y
> >> +CONFIG_CMD_FAT=y
> >> +CONFIG_CMD_FS_GENERIC=y
> >> +CONFIG_CMD_UBI=y
> >> +CONFIG_ISO_PARTITION=y
> >> +CONFIG_EFI_PARTITION=y
> >> +CONFIG_OF_CONTROL=y
> >> +CONFIG_NET_RANDOM_ETHADDR=y
> >> +CONFIG_DM=y
> >> +CONFIG_TI_AEMIF=y
> >> +# CONFIG_MMC is not set
> >> +CONFIG_DM_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH_STMICRO=y
> >> +CONFIG_DM_ETH=y
> >> +CONFIG_DM_SERIAL=y
> >> +CONFIG_SYS_NS16550=y
> >> +CONFIG_DM_SPI=y
> >> +CONFIG_USB=y
> >> +CONFIG_USB_XHCI_HCD=y
> >> +CONFIG_USB_XHCI_DWC3=y
> >> +CONFIG_USB_STORAGE=y
> > 
> > This shows a number of the will-be-problems like the AM43/AM33 devices
> > have.  More things need to be select'd and imply'd so that the _hs_
> > variant defconfigs do not get out of sync easily and often.
> > 
> 
> I do not think selecting all these options in Kconfig files is safe
> right now, at least until moving some more symbols to Kconfig is
> complete. After that we can add proper dependencies to all the symbols
> and some things like _CMD_ symbols could be added automatically.
> 
> Defconfigs are easier to cleanup than Kconfig definitions. I do not want
> to maintain the per-platform Kconfig select'd list before we get symbol
> dependencies worked out.

Well, at the end of the day, the pain is on you on re-syncing the
defconfig files, so if you want to wait on adding more logic, OK, I'll
remove my objection.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [RESEND PATCH 8/9] defconfig: k2e_hs_evm: Add k2e_hs_evm_defconfig

2017-02-28 Thread Andrew F. Davis
On 02/27/2017 09:19 AM, Tom Rini wrote:
> On Fri, Feb 24, 2017 at 06:59:45AM -0600, Andrew F. Davis wrote:
> 
>> From: Vitaly Andrianov 
>>
>> TI K2E secure devices have to be built with TI_SECURE_DEVICE, FIT, and
>> FIT_IMAGE_POST_PROCESS enabled. Add a dedicated defconfig for this.
>>
>> Signed-off-by: Vitaly Andrianov 
>> Signed-off-by: Madan Srinivas 
>> Signed-off-by: Andrew F. Davis 
>> ---
>>  configs/k2e_hs_evm_defconfig | 51 
>> 
>>  1 file changed, 51 insertions(+)
>>  create mode 100644 configs/k2e_hs_evm_defconfig
>>
>> diff --git a/configs/k2e_hs_evm_defconfig b/configs/k2e_hs_evm_defconfig
>> new file mode 100644
>> index 00..d515cedaca
>> --- /dev/null
>> +++ b/configs/k2e_hs_evm_defconfig
>> @@ -0,0 +1,51 @@
>> +CONFIG_ARM=y
>> +CONFIG_ARCH_KEYSTONE=y
>> +CONFIG_SYS_TEXT_BASE=0x0c60
>> +CONFIG_TARGET_K2E_EVM=y
>> +CONFIG_TI_SECURE_DEVICE=y
>> +CONFIG_DEFAULT_DEVICE_TREE="keystone-k2e-evm"
>> +CONFIG_FIT=y
>> +CONFIG_FIT_IMAGE_POST_PROCESS=y
>> +CONFIG_OF_BOARD_SETUP=y
>> +CONFIG_SYS_CONSOLE_INFO_QUIET=y
>> +CONFIG_VERSION_VARIABLE=y
>> +CONFIG_HUSH_PARSER=y
>> +CONFIG_SYS_PROMPT="K2E HS EVM # "
>> +CONFIG_CMD_BOOTZ=y
>> +# CONFIG_CMD_IMLS is not set
>> +CONFIG_CMD_ASKENV=y
>> +# CONFIG_CMD_FLASH is not set
>> +CONFIG_CMD_NAND=y
>> +CONFIG_CMD_PART=y
>> +CONFIG_CMD_SF=y
>> +CONFIG_CMD_SPI=y
>> +CONFIG_CMD_I2C=y
>> +CONFIG_CMD_USB=y
>> +# CONFIG_CMD_SETEXPR is not set
>> +CONFIG_CMD_DHCP=y
>> +CONFIG_CMD_MII=y
>> +CONFIG_CMD_PING=y
>> +CONFIG_CMD_EXT2=y
>> +CONFIG_CMD_EXT4=y
>> +CONFIG_CMD_EXT4_WRITE=y
>> +CONFIG_CMD_FAT=y
>> +CONFIG_CMD_FS_GENERIC=y
>> +CONFIG_CMD_UBI=y
>> +CONFIG_ISO_PARTITION=y
>> +CONFIG_EFI_PARTITION=y
>> +CONFIG_OF_CONTROL=y
>> +CONFIG_NET_RANDOM_ETHADDR=y
>> +CONFIG_DM=y
>> +CONFIG_TI_AEMIF=y
>> +# CONFIG_MMC is not set
>> +CONFIG_DM_SPI_FLASH=y
>> +CONFIG_SPI_FLASH=y
>> +CONFIG_SPI_FLASH_STMICRO=y
>> +CONFIG_DM_ETH=y
>> +CONFIG_DM_SERIAL=y
>> +CONFIG_SYS_NS16550=y
>> +CONFIG_DM_SPI=y
>> +CONFIG_USB=y
>> +CONFIG_USB_XHCI_HCD=y
>> +CONFIG_USB_XHCI_DWC3=y
>> +CONFIG_USB_STORAGE=y
> 
> This shows a number of the will-be-problems like the AM43/AM33 devices
> have.  More things need to be select'd and imply'd so that the _hs_
> variant defconfigs do not get out of sync easily and often.
> 

I do not think selecting all these options in Kconfig files is safe
right now, at least until moving some more symbols to Kconfig is
complete. After that we can add proper dependencies to all the symbols
and some things like _CMD_ symbols could be added automatically.

Defconfigs are easier to cleanup than Kconfig definitions. I do not want
to maintain the per-platform Kconfig select'd list before we get symbol
dependencies worked out.

Andrew
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [RESEND PATCH 8/9] defconfig: k2e_hs_evm: Add k2e_hs_evm_defconfig

2017-02-27 Thread Tom Rini
On Fri, Feb 24, 2017 at 06:59:45AM -0600, Andrew F. Davis wrote:

> From: Vitaly Andrianov 
> 
> TI K2E secure devices have to be built with TI_SECURE_DEVICE, FIT, and
> FIT_IMAGE_POST_PROCESS enabled. Add a dedicated defconfig for this.
> 
> Signed-off-by: Vitaly Andrianov 
> Signed-off-by: Madan Srinivas 
> Signed-off-by: Andrew F. Davis 
> ---
>  configs/k2e_hs_evm_defconfig | 51 
> 
>  1 file changed, 51 insertions(+)
>  create mode 100644 configs/k2e_hs_evm_defconfig
> 
> diff --git a/configs/k2e_hs_evm_defconfig b/configs/k2e_hs_evm_defconfig
> new file mode 100644
> index 00..d515cedaca
> --- /dev/null
> +++ b/configs/k2e_hs_evm_defconfig
> @@ -0,0 +1,51 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_KEYSTONE=y
> +CONFIG_SYS_TEXT_BASE=0x0c60
> +CONFIG_TARGET_K2E_EVM=y
> +CONFIG_TI_SECURE_DEVICE=y
> +CONFIG_DEFAULT_DEVICE_TREE="keystone-k2e-evm"
> +CONFIG_FIT=y
> +CONFIG_FIT_IMAGE_POST_PROCESS=y
> +CONFIG_OF_BOARD_SETUP=y
> +CONFIG_SYS_CONSOLE_INFO_QUIET=y
> +CONFIG_VERSION_VARIABLE=y
> +CONFIG_HUSH_PARSER=y
> +CONFIG_SYS_PROMPT="K2E HS EVM # "
> +CONFIG_CMD_BOOTZ=y
> +# CONFIG_CMD_IMLS is not set
> +CONFIG_CMD_ASKENV=y
> +# CONFIG_CMD_FLASH is not set
> +CONFIG_CMD_NAND=y
> +CONFIG_CMD_PART=y
> +CONFIG_CMD_SF=y
> +CONFIG_CMD_SPI=y
> +CONFIG_CMD_I2C=y
> +CONFIG_CMD_USB=y
> +# CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_DHCP=y
> +CONFIG_CMD_MII=y
> +CONFIG_CMD_PING=y
> +CONFIG_CMD_EXT2=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_EXT4_WRITE=y
> +CONFIG_CMD_FAT=y
> +CONFIG_CMD_FS_GENERIC=y
> +CONFIG_CMD_UBI=y
> +CONFIG_ISO_PARTITION=y
> +CONFIG_EFI_PARTITION=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_NET_RANDOM_ETHADDR=y
> +CONFIG_DM=y
> +CONFIG_TI_AEMIF=y
> +# CONFIG_MMC is not set
> +CONFIG_DM_SPI_FLASH=y
> +CONFIG_SPI_FLASH=y
> +CONFIG_SPI_FLASH_STMICRO=y
> +CONFIG_DM_ETH=y
> +CONFIG_DM_SERIAL=y
> +CONFIG_SYS_NS16550=y
> +CONFIG_DM_SPI=y
> +CONFIG_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_XHCI_DWC3=y
> +CONFIG_USB_STORAGE=y

This shows a number of the will-be-problems like the AM43/AM33 devices
have.  More things need to be select'd and imply'd so that the _hs_
variant defconfigs do not get out of sync easily and often.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/listinfo/u-boot


[U-Boot] [RESEND PATCH 8/9] defconfig: k2e_hs_evm: Add k2e_hs_evm_defconfig

2017-02-24 Thread Andrew F. Davis
From: Vitaly Andrianov 

TI K2E secure devices have to be built with TI_SECURE_DEVICE, FIT, and
FIT_IMAGE_POST_PROCESS enabled. Add a dedicated defconfig for this.

Signed-off-by: Vitaly Andrianov 
Signed-off-by: Madan Srinivas 
Signed-off-by: Andrew F. Davis 
---
 configs/k2e_hs_evm_defconfig | 51 
 1 file changed, 51 insertions(+)
 create mode 100644 configs/k2e_hs_evm_defconfig

diff --git a/configs/k2e_hs_evm_defconfig b/configs/k2e_hs_evm_defconfig
new file mode 100644
index 00..d515cedaca
--- /dev/null
+++ b/configs/k2e_hs_evm_defconfig
@@ -0,0 +1,51 @@
+CONFIG_ARM=y
+CONFIG_ARCH_KEYSTONE=y
+CONFIG_SYS_TEXT_BASE=0x0c60
+CONFIG_TARGET_K2E_EVM=y
+CONFIG_TI_SECURE_DEVICE=y
+CONFIG_DEFAULT_DEVICE_TREE="keystone-k2e-evm"
+CONFIG_FIT=y
+CONFIG_FIT_IMAGE_POST_PROCESS=y
+CONFIG_OF_BOARD_SETUP=y
+CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_VERSION_VARIABLE=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="K2E HS EVM # "
+CONFIG_CMD_BOOTZ=y
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_ASKENV=y
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_NAND=y
+CONFIG_CMD_PART=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_CMD_UBI=y
+CONFIG_ISO_PARTITION=y
+CONFIG_EFI_PARTITION=y
+CONFIG_OF_CONTROL=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_DM=y
+CONFIG_TI_AEMIF=y
+# CONFIG_MMC is not set
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_DM_ETH=y
+CONFIG_DM_SERIAL=y
+CONFIG_SYS_NS16550=y
+CONFIG_DM_SPI=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_STORAGE=y
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot