Re: [U-Boot] [RESEND PATCH v2 01/13] davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
On Mon, Jul 29, 2019 at 08:57:58AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This option is no longer used on any davinci board but still selected > in defconfigs which causes the following warning: > > = WARNING == > This board uses CONFIG_DM_I2C_COMPAT. Please remove > (possibly in a subsequent patch in your series) > before sending patches to the mailing list. > > > Remove all references to CONFIG_DM_I2C_COMPAT from davinci. > > Signed-off-by: Bartosz Golaszewski > Acked-by: Heiko Schocher Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH v2 01/13] davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
On Mon, Jul 29, 2019 at 11:14 AM Tom Rini wrote: > > On Mon, Jul 29, 2019 at 08:57:58AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This option is no longer used on any davinci board but still selected > > in defconfigs which causes the following warning: > > > > = WARNING == > > This board uses CONFIG_DM_I2C_COMPAT. Please remove > > (possibly in a subsequent patch in your series) > > before sending patches to the mailing list. > > > > > > Remove all references to CONFIG_DM_I2C_COMPAT from davinci. > > > > Signed-off-by: Bartosz Golaszewski > > Acked-by: Heiko Schocher > > --- > > configs/da850_am18xxevm_defconfig | 1 - > > configs/omapl138_lcdk_defconfig | 1 - > > include/configs/am3517_evm.h | 1 - > > include/configs/omapl138_lcdk.h | 8 > > 4 files changed, 11 deletions(-) > > This breaks da850_am18xxevm as dvevm_read_mac_address() in > arch/arm/mach-davinci/misc.c has not been updated for the i2c case. I > suspect board/atmel/common/mac_eeprom.c::at91_set_ethaddr() could be > adapted easily enough and if you don't have a chance to do so, I'll take > a pass at that. I submitted a patch to remove da850_am18xxevm since it's been orphaned for a while, and I don't have the hardware to support it as that variation wasn't a board made by Logic PD. I would argue that we apply the patch to remove the da850_am18xxevm, then we can apply his patches to remove CONFIG_DM_I2C_COMPAT. adam > > -- > Tom ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND PATCH v2 01/13] davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
On Mon, Jul 29, 2019 at 08:57:58AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This option is no longer used on any davinci board but still selected > in defconfigs which causes the following warning: > > = WARNING == > This board uses CONFIG_DM_I2C_COMPAT. Please remove > (possibly in a subsequent patch in your series) > before sending patches to the mailing list. > > > Remove all references to CONFIG_DM_I2C_COMPAT from davinci. > > Signed-off-by: Bartosz Golaszewski > Acked-by: Heiko Schocher > --- > configs/da850_am18xxevm_defconfig | 1 - > configs/omapl138_lcdk_defconfig | 1 - > include/configs/am3517_evm.h | 1 - > include/configs/omapl138_lcdk.h | 8 > 4 files changed, 11 deletions(-) This breaks da850_am18xxevm as dvevm_read_mac_address() in arch/arm/mach-davinci/misc.c has not been updated for the i2c case. I suspect board/atmel/common/mac_eeprom.c::at91_set_ethaddr() could be adapted easily enough and if you don't have a chance to do so, I'll take a pass at that. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [RESEND PATCH v2 01/13] davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
From: Bartosz Golaszewski This option is no longer used on any davinci board but still selected in defconfigs which causes the following warning: = WARNING == This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list. Remove all references to CONFIG_DM_I2C_COMPAT from davinci. Signed-off-by: Bartosz Golaszewski Acked-by: Heiko Schocher --- configs/da850_am18xxevm_defconfig | 1 - configs/omapl138_lcdk_defconfig | 1 - include/configs/am3517_evm.h | 1 - include/configs/omapl138_lcdk.h | 8 4 files changed, 11 deletions(-) diff --git a/configs/da850_am18xxevm_defconfig b/configs/da850_am18xxevm_defconfig index f7054b4a1e..bc6199822e 100644 --- a/configs/da850_am18xxevm_defconfig +++ b/configs/da850_am18xxevm_defconfig @@ -43,7 +43,6 @@ CONFIG_DM=y CONFIG_SPL_DM=y CONFIG_DA8XX_GPIO=y CONFIG_DM_I2C=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y CONFIG_MTD_DEVICE=y CONFIG_DM_SPI_FLASH=y diff --git a/configs/omapl138_lcdk_defconfig b/configs/omapl138_lcdk_defconfig index 466ae860cd..b5d41bd3f6 100644 --- a/configs/omapl138_lcdk_defconfig +++ b/configs/omapl138_lcdk_defconfig @@ -36,7 +36,6 @@ CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y CONFIG_DM_I2C=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y CONFIG_DM_MMC=y CONFIG_NAND=y diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h index 2e8481890f..c2c5c1f668 100644 --- a/include/configs/am3517_evm.h +++ b/include/configs/am3517_evm.h @@ -14,7 +14,6 @@ #include -#undef CONFIG_DM_I2C_COMPAT #define CONFIG_REVISION_TAG /* Hardware drivers */ diff --git a/include/configs/omapl138_lcdk.h b/include/configs/omapl138_lcdk.h index da615e5063..db4a663c53 100644 --- a/include/configs/omapl138_lcdk.h +++ b/include/configs/omapl138_lcdk.h @@ -16,14 +16,6 @@ #undef CONFIG_USE_SPIFLASH #undef CONFIG_SYS_USE_NOR -/* -* Disable DM_* for SPL build and can be re-enabled after adding -* DM support in SPL -*/ -#ifdef CONFIG_SPL_BUILD -#undef CONFIG_DM_I2C -#undef CONFIG_DM_I2C_COMPAT -#endif /* * SoC Configuration */ -- 2.21.0 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
