Re: [U-Boot] [RESEND PATCH v2 03/13] i2c: remove i2c driver-model compatibility layer

2019-07-29 Thread Tom Rini
On Mon, Jul 29, 2019 at 08:58:00AM +0200, Bartosz Golaszewski wrote:

> From: Bartosz Golaszewski 
> 
> There are no more users of the compatibility layer for i2c. Remove the
> driver and all references to it.
> 
> Signed-off-by: Bartosz Golaszewski 
> Acked-by: Heiko Schocher 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [RESEND PATCH v2 03/13] i2c: remove i2c driver-model compatibility layer

2019-07-29 Thread Bartosz Golaszewski
From: Bartosz Golaszewski 

There are no more users of the compatibility layer for i2c. Remove the
driver and all references to it.

Signed-off-by: Bartosz Golaszewski 
Acked-by: Heiko Schocher 
---
 Makefile|   7 --
 drivers/i2c/Kconfig |  13 +---
 drivers/i2c/Makefile|   1 -
 drivers/i2c/i2c-uclass-compat.c | 128 
 include/_exports.h  |   3 +-
 include/exports.h   |   3 +-
 include/i2c.h   |  80 
 7 files changed, 3 insertions(+), 232 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c

diff --git a/Makefile b/Makefile
index 252525bf0a..bff5a402a7 100644
--- a/Makefile
+++ b/Makefile
@@ -936,13 +936,6 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
 endif
 endif
 endif
-ifeq ($(CONFIG_DM_I2C_COMPAT),y)
-   @echo >&2 "= WARNING =="
-   @echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
-   @echo >&2 "(possibly in a subsequent patch in your series)"
-   @echo >&2 "before sending patches to the mailing list."
-   @echo >&2 ""
-endif
 ifeq ($(CONFIG_MMC),y)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
@echo >&2 "= WARNING =="
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index 4772db3837..03d2fed341 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -12,18 +12,7 @@ config DM_I2C
  write and speed, is implemented with the bus drivers operations,
  which provide methods for bus setting and data transfer. Each chip
  device (bus child) info is kept as parent platdata. The interface
- is defined in include/i2c.h. When i2c bus driver supports the i2c
- uclass, but the device drivers not, then DM_I2C_COMPAT config can
- be used as compatibility layer.
-
-config DM_I2C_COMPAT
-   bool "Enable I2C compatibility layer"
-   depends on DM
-   help
- Enable old-style I2C functions for compatibility with existing code.
- This option can be enabled as a temporary measure to avoid needing
- to convert all code for a board in a single commit. It should not
- be enabled for any board in an official release.
+ is defined in include/i2c.h.
 
 config I2C_CROS_EC_TUNNEL
tristate "Chrome OS EC tunnel I2C bus"
diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
index dc40055efb..c2f75d8755 100644
--- a/drivers/i2c/Makefile
+++ b/drivers/i2c/Makefile
@@ -3,7 +3,6 @@
 # (C) Copyright 2000-2007
 # Wolfgang Denk, DENX Software Engineering, w...@denx.de.
 obj-$(CONFIG_DM_I2C) += i2c-uclass.o
-obj-$(CONFIG_DM_I2C_COMPAT) += i2c-uclass-compat.o
 obj-$(CONFIG_DM_I2C_GPIO) += i2c-gpio.o
 obj-$(CONFIG_$(SPL_)I2C_CROS_EC_TUNNEL) += cros_ec_tunnel.o
 obj-$(CONFIG_$(SPL_)I2C_CROS_EC_LDO) += cros_ec_ldo.o
diff --git a/drivers/i2c/i2c-uclass-compat.c b/drivers/i2c/i2c-uclass-compat.c
deleted file mode 100644
index b3ade88113..00
--- a/drivers/i2c/i2c-uclass-compat.c
+++ /dev/null
@@ -1,128 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * Copyright (c) 2014 Google, Inc
- */
-
-#include 
-#include 
-#include 
-#include 
-
-static int cur_busnum __attribute__((section(".data")));
-
-static int i2c_compat_get_device(uint chip_addr, int alen,
-struct udevice **devp)
-{
-   struct dm_i2c_chip *chip;
-   int ret;
-
-   ret = i2c_get_chip_for_busnum(cur_busnum, chip_addr, alen, devp);
-   if (ret)
-   return ret;
-   chip = dev_get_parent_platdata(*devp);
-   if (chip->offset_len != alen) {
-   printf("I2C chip %x: requested alen %d does not match chip 
offset_len %d\n",
-  chip_addr, alen, chip->offset_len);
-   return -EADDRNOTAVAIL;
-   }
-
-   return 0;
-}
-
-int i2c_probe(uint8_t chip_addr)
-{
-   struct udevice *bus, *dev;
-   int ret;
-
-   ret = uclass_get_device_by_seq(UCLASS_I2C, cur_busnum, &bus);
-   if (ret) {
-   debug("Cannot find I2C bus %d: err=%d\n", cur_busnum, ret);
-   return ret;
-   }
-
-   if (!bus)
-   return -ENOENT;
-
-   return dm_i2c_probe(bus, chip_addr, 0, &dev);
-}
-
-int i2c_read(uint8_t chip_addr, unsigned int addr, int alen, uint8_t *buffer,
-int len)
-{
-   struct udevice *dev;
-   int ret;
-
-   ret = i2c_compat_get_device(chip_addr, alen, &dev);
-   if (ret)
-   return ret;
-
-   return dm_i2c_read(dev, addr, buffer, len);
-}
-
-int i2c_write(uint8_t chip_addr, unsigned int addr, int alen, uint8_t *buffer,
- int len)
-{
-   struct udevice *dev;
-   int ret;
-
-   ret = i2c_compat_get_device(chip_addr, alen, &dev);
-   if (ret)
-   return ret;
-
-   return dm_i2c_wri