Re: [U-Boot] [RESEND PATCH v7 02/10] board: common:vid: Add LS1088A VID Supported voltage values

[York Sun]

On 11/29/2017 10:30 PM, Rajesh Bhagat wrote:
> Adds below voltage values supported by LS1088A Soc:
> 
> 1.025 V(default), 0.9875V, 0.9750 V, 0.9V, 1.0 V, 1.0125 V, 1.0250 V
> 
> Signed-off-by: Ashish Kumar 
> Signed-off-by: Rajesh Bhagat 
> ---
> Changes in v7:
>   
>  None 
>   
> 
> Changes in v6:
>   
>  None 
>   
>   
>   
> Changes in v5:
>   
>  None 
>   
>   
>   
> Changes in v4:
>   
>  None 
> 
>  board/freescale/common/vid.c | 21 +
>  1 file changed, 21 insertions(+)
> 
> diff --git a/board/freescale/common/vid.c b/board/freescale/common/vid.c
> index d6d1bfc..f4fc95b 100644
> --- a/board/freescale/common/vid.c
> +++ b/board/freescale/common/vid.c
> @@ -296,15 +296,28 @@ int adjust_vdd(ulong vdd_override)
>   unsigned long vdd_string_override;
>   char *vdd_string;
>   static const uint16_t vdd[32] = {
> +#ifdef CONFIG_ARCH_LS1088A
> + 10250,
> + 9875,
> +#else
>   10500,
>   0,  /* reserved */
> +#endif
>   9750,
>   0,  /* reserved */
> +#ifdef CONFIG_ARCH_LS1088A
> + 0,  /* reserved */
> +#else
>   9500,
> +#endif
>   0,  /* reserved */
>   0,  /* reserved */
>   0,  /* reserved */
> +#ifdef CONFIG_ARCH_LS1088A
> + 9000,
> +#else
>   0,  /* reserved */
> +#endif
>   0,  /* reserved */
>   0,  /* reserved */
>   0,  /* reserved */
> @@ -313,10 +326,18 @@ int adjust_vdd(ulong vdd_override)
>   0,  /* reserved */
>   0,  /* reserved */
>   1,  /* 1.V */
> +#ifdef CONFIG_ARCH_LS1088A
> + 10125,
> +#else
>   0,  /* reserved */
> +#endif
>   10250,
>   0,  /* reserved */
> +#ifdef CONFIG_ARCH_LS1088A
> + 0,  /* reserved */
> +#else
>   10500,
> +#endif
>   0,  /* reserved */
>   0,  /* reserved */
>   0,  /* reserved */
> 

Since we have so many differences, would it be cleaner if we simply have
two separated vdd arrays?

York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [RESEND PATCH v7 02/10] board: common:vid: Add LS1088A VID Supported voltage values

[Rajesh Bhagat]

Adds below voltage values supported by LS1088A Soc:

1.025 V(default), 0.9875V, 0.9750 V, 0.9V, 1.0 V, 1.0125 V, 1.0250 V

Signed-off-by: Ashish Kumar 
Signed-off-by: Rajesh Bhagat 
---
Changes in v7:  
 None   

Changes in v6:  
 None   

Changes in v5:  
 None   

Changes in v4:  
 None 

 board/freescale/common/vid.c | 21 +
 1 file changed, 21 insertions(+)

diff --git a/board/freescale/common/vid.c b/board/freescale/common/vid.c
index d6d1bfc..f4fc95b 100644
--- a/board/freescale/common/vid.c
+++ b/board/freescale/common/vid.c
@@ -296,15 +296,28 @@ int adjust_vdd(ulong vdd_override)
unsigned long vdd_string_override;
char *vdd_string;
static const uint16_t vdd[32] = {
+#ifdef CONFIG_ARCH_LS1088A
+   10250,
+   9875,
+#else
10500,
0,  /* reserved */
+#endif
9750,
0,  /* reserved */
+#ifdef CONFIG_ARCH_LS1088A
+   0,  /* reserved */
+#else
9500,
+#endif
0,  /* reserved */
0,  /* reserved */
0,  /* reserved */
+#ifdef CONFIG_ARCH_LS1088A
+   9000,
+#else
0,  /* reserved */
+#endif
0,  /* reserved */
0,  /* reserved */
0,  /* reserved */
@@ -313,10 +326,18 @@ int adjust_vdd(ulong vdd_override)
0,  /* reserved */
0,  /* reserved */
1,  /* 1.V */
+#ifdef CONFIG_ARCH_LS1088A
+   10125,
+#else
0,  /* reserved */
+#endif
10250,
0,  /* reserved */
+#ifdef CONFIG_ARCH_LS1088A
+   0,  /* reserved */
+#else
10500,
+#endif
0,  /* reserved */
0,  /* reserved */
0,  /* reserved */
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot