Re: [U-Boot] [U-Boot, v4] NAND: add support for reading ONFI page table

2011-03-17 Thread Florian Fainelli
Le jeudi 17 mars 2011 00:42:55, Scott Wood a écrit :
 On Fri, Feb 25, 2011 at 12:01:34AM -, Florian Fainelli wrote:
  From: Florian Fainelli flor...@openwrt.org
  
  This patch adds support for reading an ONFI page parameter from a NAND
  device supporting it. If this is the case, struct nand_chip onfi_version
  member contains the supported ONFI version, 0 otherwise.
  
  This allows NAND drivers past nand_scan_ident to set the best timings for
  the NAND chip.
  
  Signed-off-by: Florian Fainelli flor...@openwrt.org
 
 Applied to u-boot-nand-flash next with this change:
 
 diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
 index 0d7c819..fa286a8 100644
 --- a/drivers/mtd/nand/nand_base.c
 +++ b/drivers/mtd/nand/nand_base.c
 @@ -2585,7 +2585,7 @@ static const struct nand_flash_dev
 *nand_get_flash_type(st type = nand_flash_ids;
 
 for (; type-name != NULL; type++)
 -   if (dev_id == type-id)
 +   if (*dev_id == type-id)
 break;

My bad, thanks for fixing this and committing the patch!
--
Florian
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [U-Boot, v4] NAND: add support for reading ONFI page table

2011-03-16 Thread Scott Wood
On Fri, Feb 25, 2011 at 12:01:34AM -, Florian Fainelli wrote:
 From: Florian Fainelli flor...@openwrt.org
 
 This patch adds support for reading an ONFI page parameter from a NAND
 device supporting it. If this is the case, struct nand_chip onfi_version
 member contains the supported ONFI version, 0 otherwise.
 
 This allows NAND drivers past nand_scan_ident to set the best timings for the
 NAND chip.
 
 Signed-off-by: Florian Fainelli flor...@openwrt.org

Applied to u-boot-nand-flash next with this change:

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 0d7c819..fa286a8 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2585,7 +2585,7 @@ static const struct nand_flash_dev *nand_get_flash_type(st
type = nand_flash_ids;
 
for (; type-name != NULL; type++)
-   if (dev_id == type-id)
+   if (*dev_id == type-id)
break;
 

-Scott

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot