Re: [U-Boot] [U-Boot, V3] Convert CONFIG_SYS_DV_CLKMODE et al to Kconfig

[Tom Rini]

On Mon, Jan 22, 2018 at 04:27:32PM -0600, Adam Ford wrote:
> On Mon, Jan 22, 2018 at 4:12 PM, Tom Rini  wrote:
> > On Mon, Jan 22, 2018 at 04:07:44PM -0600, Adam Ford wrote:
> >> On Mon, Jan 22, 2018 at 3:30 PM, Tom Rini  wrote:
> >> > On Fri, Jan 12, 2018 at 07:26:06AM -0600, Adam Ford wrote:
> >> >
> >> >> This converts the following to Kconfig:
> >> >>CONFIG_SYS_DV_CLKMODE
> >> >>CONFIG_SYS_DA850_PLL0_POSTDIV
> >> >>CONFIG_SYS_DA850_PLL0_PLLDIV1
> >> >>CONFIG_SYS_DA850_PLL0_PLLDIV2
> >> >>CONFIG_SYS_DA850_PLL0_PLLDIV3
> >> >>CONFIG_SYS_DA850_PLL0_PLLDIV4
> >> >>CONFIG_SYS_DA850_PLL0_PLLDIV5
> >> >>CONFIG_SYS_DA850_PLL0_PLLDIV7
> >> >>CONFIG_SYS_DA850_PLL1_POSTDIV
> >> >>CONFIG_SYS_DA850_PLL1_PLLDIV1
> >> >>CONFIG_SYS_DA850_PLL1_PLLDIV2
> >> >>CONFIG_SYS_DA850_PLL1_PLLDIV3
> >> >>
> >> >> Signed-off-by: Adam Ford 
> >> >> Reviewed-by: David Lechner 
> >> >> ---
> >> >> Changes in V3:
> >> >>   Using the L138 Technical Reference manual, I changed the names to 
> >> >> match
> >> >> the descriptions of the registers as listed in Table 8-2 and 
> >> >> 8-3 of the
> >> >> PLL Control 0 and PLL Control 1 Registers.
> >> >> V2:
> >> >> Expand Kconfig help definitions to give a small explanation of 
> >> >> options
> >> >> V1:
> >> >> This patch is a continuation of Convert CONFIG_SOC_DA8XX et al
> >> >> This also showed warnings when used with the legoev3_defconfig, however
> >> >> it seems like the ev3 board was defining things in the header it didn't 
> >> >> need
> >> >> since it doesn't seem to be building da850_lowlevel.c.  I don't have the
> >> >> hardware to test that board.
> >> >>
> >> >>  arch/arm/mach-davinci/Kconfig   | 85 
> >> >> -
> >> >>  configs/omapl138_lcdk_defconfig |  1 +
> >> >>  include/configs/calimain.h  | 13 ---
> >> >>  include/configs/da850evm.h  | 13 ---
> >> >>  include/configs/ipam390.h   | 13 ---
> >> >>  include/configs/legoev3.h   | 13 ---
> >> >>  include/configs/omapl138_lcdk.h | 13 ---
> >> >>  scripts/config_whitelist.txt| 12 --
> >> >>  8 files changed, 85 insertions(+), 78 deletions(-)
> >> >
> >> > [patchwork link is https://patchwork.ozlabs.org/patch/859919/]
> >> >
> >> > First, this should also cover CONFIG_SYS_DA850_PLL0_PLLM which shouldn't
> >> > be too bad.
> >> >
> >> > Second, this needs to deal with calimain, which has both
> >> > CONFIG_SYS_DA850_PLL1_PLLM and CONFIG_SYS_DA850_PLL0_PLLM as dynamic.
> >> > Ideas?  Thanks!
> >> >
> >> Can we push the low-hanging fruit and come back and revisit the rest
> >> at a later date?   My goal was just try and clean up a bunch of config
> >> files.
> >
> > Yeah, please respin a v4 that drops out CONFIG_SYS_DA850_PLL1_PLLM for
> > now, thanks!
> 
> Since it was a continuation of Convert CONFIG_SOC_DA8XX et al have you
> had a chance to review that patch?   If not, I'd like to wait until
> it's ready so I can rebuild this off any changes from the Convert
> CONFIG_SOC_DA8XX et al  patch.

In build-tests now, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, V3] Convert CONFIG_SYS_DV_CLKMODE et al to Kconfig

[Adam Ford]

On Mon, Jan 22, 2018 at 4:12 PM, Tom Rini  wrote:
> On Mon, Jan 22, 2018 at 04:07:44PM -0600, Adam Ford wrote:
>> On Mon, Jan 22, 2018 at 3:30 PM, Tom Rini  wrote:
>> > On Fri, Jan 12, 2018 at 07:26:06AM -0600, Adam Ford wrote:
>> >
>> >> This converts the following to Kconfig:
>> >>CONFIG_SYS_DV_CLKMODE
>> >>CONFIG_SYS_DA850_PLL0_POSTDIV
>> >>CONFIG_SYS_DA850_PLL0_PLLDIV1
>> >>CONFIG_SYS_DA850_PLL0_PLLDIV2
>> >>CONFIG_SYS_DA850_PLL0_PLLDIV3
>> >>CONFIG_SYS_DA850_PLL0_PLLDIV4
>> >>CONFIG_SYS_DA850_PLL0_PLLDIV5
>> >>CONFIG_SYS_DA850_PLL0_PLLDIV7
>> >>CONFIG_SYS_DA850_PLL1_POSTDIV
>> >>CONFIG_SYS_DA850_PLL1_PLLDIV1
>> >>CONFIG_SYS_DA850_PLL1_PLLDIV2
>> >>CONFIG_SYS_DA850_PLL1_PLLDIV3
>> >>
>> >> Signed-off-by: Adam Ford 
>> >> Reviewed-by: David Lechner 
>> >> ---
>> >> Changes in V3:
>> >>   Using the L138 Technical Reference manual, I changed the names to 
>> >> match
>> >> the descriptions of the registers as listed in Table 8-2 and 8-3 
>> >> of the
>> >> PLL Control 0 and PLL Control 1 Registers.
>> >> V2:
>> >> Expand Kconfig help definitions to give a small explanation of 
>> >> options
>> >> V1:
>> >> This patch is a continuation of Convert CONFIG_SOC_DA8XX et al
>> >> This also showed warnings when used with the legoev3_defconfig, however
>> >> it seems like the ev3 board was defining things in the header it didn't 
>> >> need
>> >> since it doesn't seem to be building da850_lowlevel.c.  I don't have the
>> >> hardware to test that board.
>> >>
>> >>  arch/arm/mach-davinci/Kconfig   | 85 
>> >> -
>> >>  configs/omapl138_lcdk_defconfig |  1 +
>> >>  include/configs/calimain.h  | 13 ---
>> >>  include/configs/da850evm.h  | 13 ---
>> >>  include/configs/ipam390.h   | 13 ---
>> >>  include/configs/legoev3.h   | 13 ---
>> >>  include/configs/omapl138_lcdk.h | 13 ---
>> >>  scripts/config_whitelist.txt| 12 --
>> >>  8 files changed, 85 insertions(+), 78 deletions(-)
>> >
>> > [patchwork link is https://patchwork.ozlabs.org/patch/859919/]
>> >
>> > First, this should also cover CONFIG_SYS_DA850_PLL0_PLLM which shouldn't
>> > be too bad.
>> >
>> > Second, this needs to deal with calimain, which has both
>> > CONFIG_SYS_DA850_PLL1_PLLM and CONFIG_SYS_DA850_PLL0_PLLM as dynamic.
>> > Ideas?  Thanks!
>> >
>> Can we push the low-hanging fruit and come back and revisit the rest
>> at a later date?   My goal was just try and clean up a bunch of config
>> files.
>
> Yeah, please respin a v4 that drops out CONFIG_SYS_DA850_PLL1_PLLM for
> now, thanks!

Since it was a continuation of Convert CONFIG_SOC_DA8XX et al have you
had a chance to review that patch?   If not, I'd like to wait until
it's ready so I can rebuild this off any changes from the Convert
CONFIG_SOC_DA8XX et al  patch.

thanks

adam
>
> --
> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, V3] Convert CONFIG_SYS_DV_CLKMODE et al to Kconfig

[Tom Rini]

On Mon, Jan 22, 2018 at 04:07:44PM -0600, Adam Ford wrote:
> On Mon, Jan 22, 2018 at 3:30 PM, Tom Rini  wrote:
> > On Fri, Jan 12, 2018 at 07:26:06AM -0600, Adam Ford wrote:
> >
> >> This converts the following to Kconfig:
> >>CONFIG_SYS_DV_CLKMODE
> >>CONFIG_SYS_DA850_PLL0_POSTDIV
> >>CONFIG_SYS_DA850_PLL0_PLLDIV1
> >>CONFIG_SYS_DA850_PLL0_PLLDIV2
> >>CONFIG_SYS_DA850_PLL0_PLLDIV3
> >>CONFIG_SYS_DA850_PLL0_PLLDIV4
> >>CONFIG_SYS_DA850_PLL0_PLLDIV5
> >>CONFIG_SYS_DA850_PLL0_PLLDIV7
> >>CONFIG_SYS_DA850_PLL1_POSTDIV
> >>CONFIG_SYS_DA850_PLL1_PLLDIV1
> >>CONFIG_SYS_DA850_PLL1_PLLDIV2
> >>CONFIG_SYS_DA850_PLL1_PLLDIV3
> >>
> >> Signed-off-by: Adam Ford 
> >> Reviewed-by: David Lechner 
> >> ---
> >> Changes in V3:
> >>   Using the L138 Technical Reference manual, I changed the names to 
> >> match
> >> the descriptions of the registers as listed in Table 8-2 and 8-3 
> >> of the
> >> PLL Control 0 and PLL Control 1 Registers.
> >> V2:
> >> Expand Kconfig help definitions to give a small explanation of 
> >> options
> >> V1:
> >> This patch is a continuation of Convert CONFIG_SOC_DA8XX et al
> >> This also showed warnings when used with the legoev3_defconfig, however
> >> it seems like the ev3 board was defining things in the header it didn't 
> >> need
> >> since it doesn't seem to be building da850_lowlevel.c.  I don't have the
> >> hardware to test that board.
> >>
> >>  arch/arm/mach-davinci/Kconfig   | 85 
> >> -
> >>  configs/omapl138_lcdk_defconfig |  1 +
> >>  include/configs/calimain.h  | 13 ---
> >>  include/configs/da850evm.h  | 13 ---
> >>  include/configs/ipam390.h   | 13 ---
> >>  include/configs/legoev3.h   | 13 ---
> >>  include/configs/omapl138_lcdk.h | 13 ---
> >>  scripts/config_whitelist.txt| 12 --
> >>  8 files changed, 85 insertions(+), 78 deletions(-)
> >
> > [patchwork link is https://patchwork.ozlabs.org/patch/859919/]
> >
> > First, this should also cover CONFIG_SYS_DA850_PLL0_PLLM which shouldn't
> > be too bad.
> >
> > Second, this needs to deal with calimain, which has both
> > CONFIG_SYS_DA850_PLL1_PLLM and CONFIG_SYS_DA850_PLL0_PLLM as dynamic.
> > Ideas?  Thanks!
> >
> Can we push the low-hanging fruit and come back and revisit the rest
> at a later date?   My goal was just try and clean up a bunch of config
> files.

Yeah, please respin a v4 that drops out CONFIG_SYS_DA850_PLL1_PLLM for
now, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, V3] Convert CONFIG_SYS_DV_CLKMODE et al to Kconfig

[Adam Ford]

On Mon, Jan 22, 2018 at 3:30 PM, Tom Rini  wrote:
> On Fri, Jan 12, 2018 at 07:26:06AM -0600, Adam Ford wrote:
>
>> This converts the following to Kconfig:
>>CONFIG_SYS_DV_CLKMODE
>>CONFIG_SYS_DA850_PLL0_POSTDIV
>>CONFIG_SYS_DA850_PLL0_PLLDIV1
>>CONFIG_SYS_DA850_PLL0_PLLDIV2
>>CONFIG_SYS_DA850_PLL0_PLLDIV3
>>CONFIG_SYS_DA850_PLL0_PLLDIV4
>>CONFIG_SYS_DA850_PLL0_PLLDIV5
>>CONFIG_SYS_DA850_PLL0_PLLDIV7
>>CONFIG_SYS_DA850_PLL1_POSTDIV
>>CONFIG_SYS_DA850_PLL1_PLLDIV1
>>CONFIG_SYS_DA850_PLL1_PLLDIV2
>>CONFIG_SYS_DA850_PLL1_PLLDIV3
>>
>> Signed-off-by: Adam Ford 
>> Reviewed-by: David Lechner 
>> ---
>> Changes in V3:
>>   Using the L138 Technical Reference manual, I changed the names to match
>> the descriptions of the registers as listed in Table 8-2 and 8-3 of 
>> the
>> PLL Control 0 and PLL Control 1 Registers.
>> V2:
>> Expand Kconfig help definitions to give a small explanation of 
>> options
>> V1:
>> This patch is a continuation of Convert CONFIG_SOC_DA8XX et al
>> This also showed warnings when used with the legoev3_defconfig, however
>> it seems like the ev3 board was defining things in the header it didn't need
>> since it doesn't seem to be building da850_lowlevel.c.  I don't have the
>> hardware to test that board.
>>
>>  arch/arm/mach-davinci/Kconfig   | 85 
>> -
>>  configs/omapl138_lcdk_defconfig |  1 +
>>  include/configs/calimain.h  | 13 ---
>>  include/configs/da850evm.h  | 13 ---
>>  include/configs/ipam390.h   | 13 ---
>>  include/configs/legoev3.h   | 13 ---
>>  include/configs/omapl138_lcdk.h | 13 ---
>>  scripts/config_whitelist.txt| 12 --
>>  8 files changed, 85 insertions(+), 78 deletions(-)
>
> [patchwork link is https://patchwork.ozlabs.org/patch/859919/]
>
> First, this should also cover CONFIG_SYS_DA850_PLL0_PLLM which shouldn't
> be too bad.
>
> Second, this needs to deal with calimain, which has both
> CONFIG_SYS_DA850_PLL1_PLLM and CONFIG_SYS_DA850_PLL0_PLLM as dynamic.
> Ideas?  Thanks!
>
Can we push the low-hanging fruit and come back and revisit the rest
at a later date?   My goal was just try and clean up a bunch of config
files.

adam
> --
> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, V3] Convert CONFIG_SYS_DV_CLKMODE et al to Kconfig

[Tom Rini]

On Fri, Jan 12, 2018 at 07:26:06AM -0600, Adam Ford wrote:

> This converts the following to Kconfig:
>CONFIG_SYS_DV_CLKMODE
>CONFIG_SYS_DA850_PLL0_POSTDIV
>CONFIG_SYS_DA850_PLL0_PLLDIV1
>CONFIG_SYS_DA850_PLL0_PLLDIV2
>CONFIG_SYS_DA850_PLL0_PLLDIV3
>CONFIG_SYS_DA850_PLL0_PLLDIV4
>CONFIG_SYS_DA850_PLL0_PLLDIV5
>CONFIG_SYS_DA850_PLL0_PLLDIV7
>CONFIG_SYS_DA850_PLL1_POSTDIV
>CONFIG_SYS_DA850_PLL1_PLLDIV1
>CONFIG_SYS_DA850_PLL1_PLLDIV2
>CONFIG_SYS_DA850_PLL1_PLLDIV3
> 
> Signed-off-by: Adam Ford 
> Reviewed-by: David Lechner 
> ---
> Changes in V3:
>   Using the L138 Technical Reference manual, I changed the names to match
> the descriptions of the registers as listed in Table 8-2 and 8-3 of 
> the
> PLL Control 0 and PLL Control 1 Registers.
> V2:
> Expand Kconfig help definitions to give a small explanation of options
> V1:
> This patch is a continuation of Convert CONFIG_SOC_DA8XX et al
> This also showed warnings when used with the legoev3_defconfig, however
> it seems like the ev3 board was defining things in the header it didn't need
> since it doesn't seem to be building da850_lowlevel.c.  I don't have the
> hardware to test that board.
> 
>  arch/arm/mach-davinci/Kconfig   | 85 
> -
>  configs/omapl138_lcdk_defconfig |  1 +
>  include/configs/calimain.h  | 13 ---
>  include/configs/da850evm.h  | 13 ---
>  include/configs/ipam390.h   | 13 ---
>  include/configs/legoev3.h   | 13 ---
>  include/configs/omapl138_lcdk.h | 13 ---
>  scripts/config_whitelist.txt| 12 --
>  8 files changed, 85 insertions(+), 78 deletions(-)

[patchwork link is https://patchwork.ozlabs.org/patch/859919/]

First, this should also cover CONFIG_SYS_DA850_PLL0_PLLM which shouldn't
be too bad.

Second, this needs to deal with calimain, which has both
CONFIG_SYS_DA850_PLL1_PLLM and CONFIG_SYS_DA850_PLL0_PLLM as dynamic.
Ideas?  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot