Re: [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available, ping?
On 09/07/2011 11:47 PM, Wolfgang Denk wrote: Dear Stefano Babic, In message4e676571.5090...@denx.de you wrote: On 09/07/2011 07:40 AM, Helmut Raiger wrote: Hi Helmut, This is sitting here for more than 2 months, could someone please ACK and/or apply. I think that one reason for the delay is that you do not add the network maintainer (Wolfgang) as CC in V2 of your patch - I missed also this patch, and I send now after testing my tested-by as I did for V1. Even more so: the patch is flagged as for MX31, so I don;t even look at it. Best regards, Wolfgang Denk Damn, yes, my fault. In the heat of the action ... Thx, Helmut -- Scanned by MailScanner. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available, ping?
On 09/07/2011 07:40 AM, Helmut Raiger wrote: Hi Helmut, This is sitting here for more than 2 months, could someone please ACK and/or apply. I think that one reason for the delay is that you do not add the network maintainer (Wolfgang) as CC in V2 of your patch - I missed also this patch, and I send now after testing my tested-by as I did for V1. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available, ping?
Dear Stefano Babic, In message 4e676571.5090...@denx.de you wrote: On 09/07/2011 07:40 AM, Helmut Raiger wrote: Hi Helmut, This is sitting here for more than 2 months, could someone please ACK and/or apply. I think that one reason for the delay is that you do not add the network maintainer (Wolfgang) as CC in V2 of your patch - I missed also this patch, and I send now after testing my tested-by as I did for V1. Even more so: the patch is flagged as for MX31, so I don;t even look at it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de He'd been wrong, there _was_ a light at the end of the tunnel, and it was a flamethrower. - Terry Pratchett, _Mort_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available, ping?
This is sitting here for more than 2 months, could someone please ACK and/or apply. Helmut -- Scanned by MailScanner. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available
On 06/20/2011 08:10 AM, helmut.rai...@hale.at wrote: From: Helmut Raiger helmut.rai...@hale.at Hi Helmut, The driver already had the MII functions, but they have not been registered using miiphy_register(). Signed-off-by: Helmut Raiger helmut.rai...@hale.at Not noted before, thanks for fixing it. Only to remark the issue, on boards with SMC911x (at least the one I tested your patch) and CONFIG_CMD_MII set, a simple mii info returns Read MDIO failed.. You should always put in CC the maintainer for your patches. Because this patch is related to network, you should send your changes to Wolfgang Denk (Network Maintaner), too. I have already set his name in CC. +#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) +/* wrapper for smc911x_miiphy_read */ +static int _phy_read(char *devname, u8 phy, u8 reg, u16 *val) Is there some reason to use name starting with _ ? They have special meaning, and there is no need here. I have tested your patch on the mx35pdk board. Tested-by: Stefano Babic sba...@denx.de Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
