Re: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM
On 2/25/2014 5:10 PM, Rini, Tom wrote: On Thu, Feb 20, 2014 at 12:55:02PM -0500, Murali Karicheri wrote: This patch series add support for keystone2 SoC and K2HK EVM In general, you ran checkpatch.pl right? I see some '#definetab' cases that need manual fixing up as well. Further comments and acks coming. Tom, Just want to check with you what you want me to fix for #define tab. Generally from my Linux experience, I have seen #define used with tab. I looked at few header files and that have this tab in #define. So where this restriction come from? I looked into the Documentation/CodingStyle in Linux source tree and can't find any rule of not to use #define tab. Murali ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM
On Wed, Mar 12, 2014 at 03:21:26PM -0400, Murali Karicheri wrote: On 2/25/2014 5:10 PM, Rini, Tom wrote: On Thu, Feb 20, 2014 at 12:55:02PM -0500, Murali Karicheri wrote: This patch series add support for keystone2 SoC and K2HK EVM In general, you ran checkpatch.pl right? I see some '#definetab' cases that need manual fixing up as well. Further comments and acks coming. Tom, Just want to check with you what you want me to fix for #define tab. Generally from my Linux experience, I have seen #define used with tab. I looked at few header files and that have this tab in #define. So where this restriction come from? I looked into the Documentation/CodingStyle in Linux source tree and can't find any rule of not to use #define tab. It's a thing here at least that yes, '#definespace' only, and we do have a few things that need cleaning up. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM
-Original Message- From: Tom Rini [mailto:tom.r...@gmail.com] On Behalf Of Rini, Tom Sent: Tuesday, February 25, 2014 5:11 PM To: Karicheri, Muralidharan Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM On Thu, Feb 20, 2014 at 12:55:02PM -0500, Murali Karicheri wrote: This patch series add support for keystone2 SoC and K2HK EVM In general, you ran checkpatch.pl right? I see some '#definetab' cases that need manual fixing up as well. Further comments and acks coming. Errors are fixed. However there are some warnings that doesn't make sense and are left as is. Murali -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM
On Thu, Feb 20, 2014 at 12:55:02PM -0500, Murali Karicheri wrote: This patch series add support for keystone2 SoC and K2HK EVM In general, you ran checkpatch.pl right? I see some '#definetab' cases that need manual fixing up as well. Further comments and acks coming. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM
-Original Message- From: Karicheri, Muralidharan Sent: Thursday, February 20, 2014 12:55 PM To: u-boot@lists.denx.de; Rini, Tom Cc: Karicheri, Muralidharan Subject: [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM This patch series add support for keystone2 SoC and K2HK EVM Change history: v2 - Review comments incorporated. Following are major comments addressed - split network driver to navigator driver + ethernet driver - replaced register base + offset implemenation with struct based register access implementation - Added Readme for NAND no subpage write option - re-use code for davinci i2c driver on keystone2 with updates - clock-k2hk.c merged to clock.c - currently keeping board specific getclk() command. See the thread for the rational. - Added update to davinci spi driver to re-use on keystone v1 - added separate patch for sorting tools/Makefile entries - reworked gpimage patch to allow more re-use across omapimage/gpimage - dropped patch related to ubifs file size - added keystone SoC and K2HK EVM support v0 - preparatory patch for keystone Murali Karicheri (5): tools: sort the entries in Makefile tools: mkimage: add support for gpimage format NAND: DaVinci: allow forced disable of subpage writes i2c, davinci: move i2c_defs.h to the drivers/i2c directory k2hk-evm: add configuration for spi1 and spi2 support Rex Chang (1): spi: davinci: add support for multiple bus and chip select Vitaly Andrianov (6): fdt: call ft_board_setup_ex() at the end of image_setup_libfdt() arm: add support for arch timer i2c, davinci: add support for multiple i2c buses k2hk: add support for k2hk SOC and EVM keystone2: add keystone multicore navigator driver keystone2: net: add keystone ethernet driver Makefile | 19 + README |5 + arch/arm/cpu/armv7/keystone/Makefile | 18 + arch/arm/cpu/armv7/keystone/aemif.c| 71 ++ arch/arm/cpu/armv7/keystone/clock.c| 313 +++ arch/arm/cpu/armv7/keystone/cmd_clock.c| 124 +++ arch/arm/cpu/armv7/keystone/cmd_mon.c | 131 +++ arch/arm/cpu/armv7/keystone/config.mk | 15 + arch/arm/cpu/armv7/keystone/ddr3.c | 69 ++ arch/arm/cpu/armv7/keystone/init.c | 56 ++ arch/arm/cpu/armv7/keystone/keystone_nav.c | 376 + arch/arm/cpu/armv7/keystone/msmc.c | 68 ++ arch/arm/cpu/armv7/keystone/psc.c | 238 ++ arch/arm/cpu/armv7/keystone/spl.c | 45 + arch/arm/include/asm/arch-davinci/i2c_defs.h | 71 +- arch/arm/include/asm/arch-keystone/clock-k2hk.h| 109 +++ arch/arm/include/asm/arch-keystone/clock.h | 17 + arch/arm/include/asm/arch-keystone/clock_defs.h| 121 +++ arch/arm/include/asm/arch-keystone/emac_defs.h | 250 ++ arch/arm/include/asm/arch-keystone/emif_defs.h | 73 ++ arch/arm/include/asm/arch-keystone/hardware-k2hk.h | 145 arch/arm/include/asm/arch-keystone/hardware.h | 175 arch/arm/include/asm/arch-keystone/i2c_defs.h | 17 + arch/arm/include/asm/arch-keystone/keystone_nav.h | 193 + arch/arm/include/asm/arch-keystone/nand_defs.h | 25 + arch/arm/include/asm/arch-keystone/psc_defs.h | 90 ++ arch/arm/include/asm/arch-keystone/spl.h | 12 + arch/arm/lib/Makefile |1 + arch/arm/lib/arch_timer.c | 58 ++ board/ti/k2hk_evm/Makefile |9 + board/ti/k2hk_evm/README | 56 ++ board/ti/k2hk_evm/board.c | 301 +++ board/ti/k2hk_evm/ddr3.c | 269 ++ boards.cfg |1 + common/image-fdt.c |5 + common/image.c |1 + drivers/i2c/davinci_i2c.c | 345 drivers/i2c/davinci_i2c.h | 78 ++ drivers/mtd/nand/davinci_nand.c|3 + drivers/net/Makefile |1 + drivers/net/keystone_net.c | 859 drivers/serial/ns16550.c |8 + drivers/spi/davinci_spi.c | 62 +- drivers/spi/davinci_spi.h | 33 + include/configs/k2hk_evm.h | 268 ++ include/fdt_support.h |1 + include/image.h|1 + tools/Makefile
Re: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/25/2014 05:49 PM, Karicheri, Muralidharan wrote: -Original Message- From: Karicheri, Muralidharan Sent: Thursday, February 20, 2014 12:55 PM To: u-boot@lists.denx.de; Rini, Tom Cc: Karicheri, Muralidharan Subject: [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM This patch series add support for keystone2 SoC and K2HK EVM Change history: v2 - Review comments incorporated. Following are major comments addressed - split network driver to navigator driver + ethernet driver - replaced register base + offset implemenation with struct based register access implementation - Added Readme for NAND no subpage write option - re-use code for davinci i2c driver on keystone2 with updates - clock-k2hk.c merged to clock.c - currently keeping board specific getclk() command. See the thread for the rational. - Added update to davinci spi driver to re-use on keystone v1 - added separate patch for sorting tools/Makefile entries - reworked gpimage patch to allow more re-use across omapimage/gpimage - dropped patch related to ubifs file size - added keystone SoC and K2HK EVM support v0 - preparatory patch for keystone Murali Karicheri (5): tools: sort the entries in Makefile tools: mkimage: add support for gpimage format NAND: DaVinci: allow forced disable of subpage writes i2c, davinci: move i2c_defs.h to the drivers/i2c directory k2hk-evm: add configuration for spi1 and spi2 support Rex Chang (1): spi: davinci: add support for multiple bus and chip select Vitaly Andrianov (6): fdt: call ft_board_setup_ex() at the end of image_setup_libfdt() arm: add support for arch timer i2c, davinci: add support for multiple i2c buses k2hk: add support for k2hk SOC and EVM keystone2: add keystone multicore navigator driver keystone2: net: add keystone ethernet driver Makefile | 19 + README |5 + arch/arm/cpu/armv7/keystone/Makefile | 18 + arch/arm/cpu/armv7/keystone/aemif.c| 71 ++ arch/arm/cpu/armv7/keystone/clock.c| 313 +++ arch/arm/cpu/armv7/keystone/cmd_clock.c| 124 +++ arch/arm/cpu/armv7/keystone/cmd_mon.c | 131 +++ arch/arm/cpu/armv7/keystone/config.mk | 15 + arch/arm/cpu/armv7/keystone/ddr3.c | 69 ++ arch/arm/cpu/armv7/keystone/init.c | 56 ++ arch/arm/cpu/armv7/keystone/keystone_nav.c | 376 + arch/arm/cpu/armv7/keystone/msmc.c | 68 ++ arch/arm/cpu/armv7/keystone/psc.c | 238 ++ arch/arm/cpu/armv7/keystone/spl.c | 45 + arch/arm/include/asm/arch-davinci/i2c_defs.h | 71 +- arch/arm/include/asm/arch-keystone/clock-k2hk.h| 109 +++ arch/arm/include/asm/arch-keystone/clock.h | 17 + arch/arm/include/asm/arch-keystone/clock_defs.h| 121 +++ arch/arm/include/asm/arch-keystone/emac_defs.h | 250 ++ arch/arm/include/asm/arch-keystone/emif_defs.h | 73 ++ arch/arm/include/asm/arch-keystone/hardware-k2hk.h | 145 arch/arm/include/asm/arch-keystone/hardware.h | 175 arch/arm/include/asm/arch-keystone/i2c_defs.h | 17 + arch/arm/include/asm/arch-keystone/keystone_nav.h | 193 + arch/arm/include/asm/arch-keystone/nand_defs.h | 25 + arch/arm/include/asm/arch-keystone/psc_defs.h | 90 ++ arch/arm/include/asm/arch-keystone/spl.h | 12 + arch/arm/lib/Makefile |1 + arch/arm/lib/arch_timer.c | 58 ++ board/ti/k2hk_evm/Makefile |9 + board/ti/k2hk_evm/README | 56 ++ board/ti/k2hk_evm/board.c | 301 +++ board/ti/k2hk_evm/ddr3.c | 269 ++ boards.cfg |1 + common/image-fdt.c |5 + common/image.c |1 + drivers/i2c/davinci_i2c.c | 345 drivers/i2c/davinci_i2c.h | 78 ++ drivers/mtd/nand/davinci_nand.c|3 + drivers/net/Makefile |1 + drivers/net/keystone_net.c | 859 drivers/serial/ns16550.c |8 + drivers/spi/davinci_spi.c | 62 +- drivers/spi/davinci_spi.h | 33 + include/configs/k2hk_evm.h | 268 ++ include/fdt_support.h |1 + include/image.h|1 + tools/Makefile | 20 +- tools/gpheader.h | 40 + tools/gpimage-common.c
[U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM
This patch series add support for keystone2 SoC and K2HK EVM Change history: v2 - Review comments incorporated. Following are major comments addressed - split network driver to navigator driver + ethernet driver - replaced register base + offset implemenation with struct based register access implementation - Added Readme for NAND no subpage write option - re-use code for davinci i2c driver on keystone2 with updates - clock-k2hk.c merged to clock.c - currently keeping board specific getclk() command. See the thread for the rational. - Added update to davinci spi driver to re-use on keystone v1 - added separate patch for sorting tools/Makefile entries - reworked gpimage patch to allow more re-use across omapimage/gpimage - dropped patch related to ubifs file size - added keystone SoC and K2HK EVM support v0 - preparatory patch for keystone Murali Karicheri (5): tools: sort the entries in Makefile tools: mkimage: add support for gpimage format NAND: DaVinci: allow forced disable of subpage writes i2c, davinci: move i2c_defs.h to the drivers/i2c directory k2hk-evm: add configuration for spi1 and spi2 support Rex Chang (1): spi: davinci: add support for multiple bus and chip select Vitaly Andrianov (6): fdt: call ft_board_setup_ex() at the end of image_setup_libfdt() arm: add support for arch timer i2c, davinci: add support for multiple i2c buses k2hk: add support for k2hk SOC and EVM keystone2: add keystone multicore navigator driver keystone2: net: add keystone ethernet driver Makefile | 19 + README |5 + arch/arm/cpu/armv7/keystone/Makefile | 18 + arch/arm/cpu/armv7/keystone/aemif.c| 71 ++ arch/arm/cpu/armv7/keystone/clock.c| 313 +++ arch/arm/cpu/armv7/keystone/cmd_clock.c| 124 +++ arch/arm/cpu/armv7/keystone/cmd_mon.c | 131 +++ arch/arm/cpu/armv7/keystone/config.mk | 15 + arch/arm/cpu/armv7/keystone/ddr3.c | 69 ++ arch/arm/cpu/armv7/keystone/init.c | 56 ++ arch/arm/cpu/armv7/keystone/keystone_nav.c | 376 + arch/arm/cpu/armv7/keystone/msmc.c | 68 ++ arch/arm/cpu/armv7/keystone/psc.c | 238 ++ arch/arm/cpu/armv7/keystone/spl.c | 45 + arch/arm/include/asm/arch-davinci/i2c_defs.h | 71 +- arch/arm/include/asm/arch-keystone/clock-k2hk.h| 109 +++ arch/arm/include/asm/arch-keystone/clock.h | 17 + arch/arm/include/asm/arch-keystone/clock_defs.h| 121 +++ arch/arm/include/asm/arch-keystone/emac_defs.h | 250 ++ arch/arm/include/asm/arch-keystone/emif_defs.h | 73 ++ arch/arm/include/asm/arch-keystone/hardware-k2hk.h | 145 arch/arm/include/asm/arch-keystone/hardware.h | 175 arch/arm/include/asm/arch-keystone/i2c_defs.h | 17 + arch/arm/include/asm/arch-keystone/keystone_nav.h | 193 + arch/arm/include/asm/arch-keystone/nand_defs.h | 25 + arch/arm/include/asm/arch-keystone/psc_defs.h | 90 ++ arch/arm/include/asm/arch-keystone/spl.h | 12 + arch/arm/lib/Makefile |1 + arch/arm/lib/arch_timer.c | 58 ++ board/ti/k2hk_evm/Makefile |9 + board/ti/k2hk_evm/README | 56 ++ board/ti/k2hk_evm/board.c | 301 +++ board/ti/k2hk_evm/ddr3.c | 269 ++ boards.cfg |1 + common/image-fdt.c |5 + common/image.c |1 + drivers/i2c/davinci_i2c.c | 345 drivers/i2c/davinci_i2c.h | 78 ++ drivers/mtd/nand/davinci_nand.c|3 + drivers/net/Makefile |1 + drivers/net/keystone_net.c | 859 drivers/serial/ns16550.c |8 + drivers/spi/davinci_spi.c | 62 +- drivers/spi/davinci_spi.h | 33 + include/configs/k2hk_evm.h | 268 ++ include/fdt_support.h |1 + include/image.h|1 + tools/Makefile | 20 +- tools/gpheader.h | 40 + tools/gpimage-common.c | 80 ++ tools/gpimage.c| 77 ++
