Re: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command

2011-08-11 Thread York Sun 
On Wed, 2011-08-10 at 20:27 -0500, Tabi Timur-B04825 wrote:
 York Sun wrote:
  Change the help message to be more helpful. Print argument format.
  Fix MAX_NUM_PORTS to comply with v1 NXID format.
 
  Signed-off-by: York Sunyork...@freescale.com
 
 Could you also fix the commands so that they take a number in decimal 
 instead of hex?
 
 
  e.mac[index][i] = simple_strtoul(p, p, 16);
 
 ...
 
   e.mac_count = simple_strtoul(argv[2], NULL, 16);
 
 I know U-Boot uses hex for everything, but it doesn't make sense for 
 this command.


Yes, I can change it. But not all of them. We use hexadecimal for mac
address but not the count of ports. Please comment on my next version.

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command

2011-08-10 Thread Tabi Timur-B04825 
York Sun wrote:
 Change the help message to be more helpful. Print argument format.
 Fix MAX_NUM_PORTS to comply with v1 NXID format.

 Signed-off-by: York Sunyork...@freescale.com

Could you also fix the commands so that they take a number in decimal 
instead of hex?


 e.mac[index][i] = simple_strtoul(p, p, 16);

...

e.mac_count = simple_strtoul(argv[2], NULL, 16);

I know U-Boot uses hex for everything, but it doesn't make sense for 
this command.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command

2011-08-10 Thread Mike Frysinger 
On Wednesday, August 10, 2011 21:27:28 Tabi Timur-B04825 wrote:
 York Sun wrote:
  Change the help message to be more helpful. Print argument format.
  Fix MAX_NUM_PORTS to comply with v1 NXID format.
  
  Signed-off-by: York Sunyork...@freescale.com
 
 Could you also fix the commands so that they take a number in decimal
 instead of hex?
 
 
  e.mac[index][i] = simple_strtoul(p, p, 16);
 
 ...
 
   e.mac_count = simple_strtoul(argv[2], NULL, 16);
 
 I know U-Boot uses hex for everything, but it doesn't make sense for
 this command.

change it to 0 and then both should work
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot