Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2017-04-09 Thread Simon Glass 
Hi,

On 8 November 2016 at 05:10, Raschen Josef  wrote:
> Hi,
>
>> From my tests it should be somewhere between these two commits:
>> 1c62d999528da1f052cb4b07cbb540b148c52537OK
>> ceec08f50b66df0c988033842ec057a32658cfe0NOK
>
> I did some more tests and it looks like commit 
> 14bed52d276afd36b9674ee7aa2c2ad9d2f4e59e introduced the issue. From the code 
> I would guess that the max clock of the mmc controller is not set up 
> correctly for the x86/BayTrail platform (minnowmax_defconfig in my case).
>
> Thanks,
> Josef
>

I made some time to dig into this recently.

From what I can this is a bug in the old code. Since pci_mmc.c does
not read the version number into host->version, add_sdhci() used to
just use a value of 0. Now it reads the correct version number.

old code:
MMC:   sdhci_setup_cfg: name=ValleyView SDHCI, host_caps=0,
cfg->host_caps=7, f_min=140625, f_max=3600
sdhci_setup_cfg: name=ValleyView SDHCI, host_caps=0, cfg->host_caps=7,
f_min=140625, f_max=3600
ValleyView SDHCI: 0, ValleyView SDHCI: 1


new code:
sdhci_setup_cfg: version = b502
sdhci_setup_cfg: name=ValleyView SDHCI, host_caps=0, cfg->host_caps=7,
f_min=48875, f_max=1
add_sdhci: version = 0
sdhci_setup_cfg: version = b502
sdhci_setup_cfg: name=ValleyView SDHCI, host_caps=0, cfg->host_caps=7,
f_min=48875, f_max=1
add_sdhci: version = 0
sdhci_setup_cfg: version = 1002
sdhci_setup_cfg: name=ValleyView SDHCI, host_caps=0, cfg->host_caps=7,
f_min=97751, f_max=2


So the clock speed is showing as faster with the new code (the MMC
card is the second one above. I suspect the old card was programming
the registers incorrectly and happening to get a higher speed.

That said, I do see twice the performance with the old code. I wonder
if there is a way to detect that the card or host can run faster?

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-11-08 Thread Raschen Josef 
Hi,

> From my tests it should be somewhere between these two commits:
> 1c62d999528da1f052cb4b07cbb540b148c52537OK
> ceec08f50b66df0c988033842ec057a32658cfe0NOK

I did some more tests and it looks like commit 
14bed52d276afd36b9674ee7aa2c2ad9d2f4e59e introduced the issue. From the code I 
would guess that the max clock of the mmc controller is not set up correctly 
for the x86/BayTrail platform (minnowmax_defconfig in my case).

Thanks,
Josef

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-25 Thread Raschen Josef 

Von: Jaehoon Chung [jh80.ch...@samsung.com]
Gesendet: Freitag, 21. Oktober 2016 14:11

>>>From my tests it should be somewhere between these two commits:
>> 1c62d999528da1f052cb4b07cbb540b148c52537OK
>> ceec08f50b66df0c988033842ec057a32658cfe0NOK

> Thanks for checking..Could you share which controller you use?
> I needs to check the driver codes for this...but i didn't know which driver 
> you use..
> It should be helpful to me..

Unfortunately, I have no access to the board for the next two weeks. I can only 
tell you, that the Board uses a an Intel Atom E3826 (Bay Trail) SoC. I think 
the data sheet does not say which type of MMC controller it uses. 

http://www.intel.com/content/www/us/en/embedded/products/bay-trail/atom-e3800-family-datasheet.html
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-22 Thread Raschen Josef 

> I think this is related with below commit...

> commit 6dffdbc3a5911e768be21850a612bfb4871a23ef
> Author: Wenyou Yang 
> Date:   Sun Sep 18 09:01:22 2016 +0800
>
>mmc: sdhci: Add the programmable clock mode support
>
>Add the programmable clock mode for the clock generator.
>
> Signed-off-by: Wenyou Yang 
>
> I'm checking with SD3.0..If this patch cause this issue..i will fix it.

>From my tests it should be somewhere between these two commits:
1c62d999528da1f052cb4b07cbb540b148c52537OK
ceec08f50b66df0c988033842ec057a32658cfe0NOK

>
> Best Regards,
> Jaehoon Chung

Thanks,
Josef


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-21 Thread Jaehoon Chung 
Hi

On 10/21/2016 08:52 PM, Raschen Josef wrote:
> 
>> I think this is related with below commit...
> 
>> commit 6dffdbc3a5911e768be21850a612bfb4871a23ef
>> Author: Wenyou Yang 
>> Date:   Sun Sep 18 09:01:22 2016 +0800
>>
>>mmc: sdhci: Add the programmable clock mode support
>>
>>Add the programmable clock mode for the clock generator.
>>
>> Signed-off-by: Wenyou Yang 
>>
>> I'm checking with SD3.0..If this patch cause this issue..i will fix it.
> 
>>From my tests it should be somewhere between these two commits:
> 1c62d999528da1f052cb4b07cbb540b148c52537OK
> ceec08f50b66df0c988033842ec057a32658cfe0NOK

Thanks for checking..Could you share which controller you use?
I needs to check the driver codes for this...but i didn't know which driver you 
use..
It should be helpful to me..

Best Regards,
Jaehoon Chung

> 
>>
>> Best Regards,
>> Jaehoon Chung
> 
> Thanks,
> Josef
> 
> 
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-21 Thread Jaehoon Chung 
Hi

On 10/21/2016 04:40 PM, Jaehoon Chung wrote:
> Hi,
> 
> On 10/21/2016 03:32 PM, Bin Meng wrote:
>> +Simon, Stefan,
>>
>> On Fri, Oct 21, 2016 at 12:36 PM, Jaehoon Chung  
>> wrote:
>>> Hi,
>>>
>>> On 10/21/2016 01:27 AM, Raschen Josef wrote:
 Hi,

 Reading a kernel image from an SD card via the fatload command on the 
 MinnowBoard Turbot seems to be significantly slower since v2016.09 
 compared to v2016.07:

 v2016.07
 => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
 reading bzImage
 5749232 bytes read in 129 ms (42.5 MiB/s)

 v2016.09
 => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
 reading bzImage
 5749232 bytes read in 249 ms (22 MiB/s)

 The same for v2016.11-rc1.

 I am using U-Boot in bare mode on the board. Any idea what causes this?
>>>
>>> Could you share which driver you use?
>>>
>>
>> Could you bisect to see which commit introduced this regression?
> 
> I did..but i didn't see this issue on my boards. :(
> So as Bin's suggestion, could you try to bisect..?

I think this is related with below commit...

commit 6dffdbc3a5911e768be21850a612bfb4871a23ef
Author: Wenyou Yang 
Date:   Sun Sep 18 09:01:22 2016 +0800

mmc: sdhci: Add the programmable clock mode support

Add the programmable clock mode for the clock generator.

Signed-off-by: Wenyou Yang 

I'm checking with SD3.0..If this patch cause this issue..i will fix it.

Best Regards,
Jaehoon Chung

> 
> Best Regards,
> Jaehoon Chung
> 
>>
>> Regards,
>> Bin
>>
>>
>>
> 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-21 Thread Jaehoon Chung 
Hi,

On 10/21/2016 03:32 PM, Bin Meng wrote:
> +Simon, Stefan,
> 
> On Fri, Oct 21, 2016 at 12:36 PM, Jaehoon Chung  
> wrote:
>> Hi,
>>
>> On 10/21/2016 01:27 AM, Raschen Josef wrote:
>>> Hi,
>>>
>>> Reading a kernel image from an SD card via the fatload command on the 
>>> MinnowBoard Turbot seems to be significantly slower since v2016.09 compared 
>>> to v2016.07:
>>>
>>> v2016.07
>>> => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
>>> reading bzImage
>>> 5749232 bytes read in 129 ms (42.5 MiB/s)
>>>
>>> v2016.09
>>> => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
>>> reading bzImage
>>> 5749232 bytes read in 249 ms (22 MiB/s)
>>>
>>> The same for v2016.11-rc1.
>>>
>>> I am using U-Boot in bare mode on the board. Any idea what causes this?
>>
>> Could you share which driver you use?
>>
> 
> Could you bisect to see which commit introduced this regression?

I did..but i didn't see this issue on my boards. :(
So as Bin's suggestion, could you try to bisect..?

Best Regards,
Jaehoon Chung

> 
> Regards,
> Bin
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-21 Thread Bin Meng 
+Simon, Stefan,

On Fri, Oct 21, 2016 at 12:36 PM, Jaehoon Chung  wrote:
> Hi,
>
> On 10/21/2016 01:27 AM, Raschen Josef wrote:
>> Hi,
>>
>> Reading a kernel image from an SD card via the fatload command on the 
>> MinnowBoard Turbot seems to be significantly slower since v2016.09 compared 
>> to v2016.07:
>>
>> v2016.07
>> => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
>> reading bzImage
>> 5749232 bytes read in 129 ms (42.5 MiB/s)
>>
>> v2016.09
>> => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
>> reading bzImage
>> 5749232 bytes read in 249 ms (22 MiB/s)
>>
>> The same for v2016.11-rc1.
>>
>> I am using U-Boot in bare mode on the board. Any idea what causes this?
>
> Could you share which driver you use?
>

Could you bisect to see which commit introduced this regression?

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-20 Thread Jaehoon Chung 
Hi,

On 10/21/2016 01:27 AM, Raschen Josef wrote:
> Hi,
> 
> Reading a kernel image from an SD card via the fatload command on the 
> MinnowBoard Turbot seems to be significantly slower since v2016.09 compared 
> to v2016.07:
> 
> v2016.07
> => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
> reading bzImage
> 5749232 bytes read in 129 ms (42.5 MiB/s)
> 
> v2016.09
> => fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
> reading bzImage
> 5749232 bytes read in 249 ms (22 MiB/s)
> 
> The same for v2016.11-rc1. 
> 
> I am using U-Boot in bare mode on the board. Any idea what causes this?

Could you share which driver you use?

Best Regards,
Jaehoon Chung

> 
> Thanks,
> Josef
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Loading kernel from SD card slow on MinnowBoard Turbot since v2016.09

2016-10-20 Thread Raschen Josef 
Hi,

Reading a kernel image from an SD card via the fatload command on the 
MinnowBoard Turbot seems to be significantly slower since v2016.09 compared to 
v2016.07:

v2016.07
=> fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
reading bzImage
5749232 bytes read in 129 ms (42.5 MiB/s)

v2016.09
=> fatload mmc 1:1 ${loadaddr} bzImage ; zboot ${loadaddr}
reading bzImage
5749232 bytes read in 249 ms (22 MiB/s)

The same for v2016.11-rc1. 

I am using U-Boot in bare mode on the board. Any idea what causes this?

Thanks,
Josef
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot