Re: [U-Boot] Usage of bi_env ?
On 15.07.2010 23:21, Wolfgang Denk wrote: Dear Dirk Behme, In message4c349814.2000...@googlemail.com you wrote: With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives: ... env_t = 0x ... The code in common/cmd_bdinfo.c for this is bd_t *bd = gd-bd; ... print_num (env_t, (ulong)bd-bi_env); While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here? You missed sending a patch that cleans this up :-) Fixed some minutes ago ;) Best regards Dirk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Usage of bi_env ?
Dear Dirk Behme, In message 4c349814.2000...@googlemail.com you wrote: With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives: ... env_t = 0x ... The code in common/cmd_bdinfo.c for this is bd_t *bd = gd-bd; ... print_num (env_t, (ulong)bd-bi_env); While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here? You missed sending a patch that cleans this up :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The trouble with our times is that the future is not what it used to be. - Paul Valery ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Usage of bi_env ?
With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives: ... env_t = 0x ... The code in common/cmd_bdinfo.c for this is bd_t *bd = gd-bd; ... print_num (env_t, (ulong)bd-bi_env); While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here? Best regards Dirk [1] grep for bi_env in 2010.03: ./include/asm-i386/u-boot.h:54: struct environment_s *bi_env; ./include/asm-i386/u-boot.h:62:#define bi_env_data bi_env-data ./include/asm-i386/u-boot.h:63:#define bi_env_crc bi_env-crc ./include/asm-arm/u-boot.h:42:struct environment_s *bi_env; ./include/asm-arm/u-boot.h:52:#define bi_env_data bi_env-data ./include/asm-arm/u-boot.h:53:#define bi_env_crc bi_env-crc ./include/asm-mips/u-boot.h:45:#define bi_env_data bi_env-data ./include/asm-mips/u-boot.h:46:#define bi_env_crc bi_env-crc ./include/asm-avr32/u-boot.h:29:struct environment_s*bi_env; ./common/cmd_bdinfo.c:328: print_num (env_t, (ulong)bd-bi_env); ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
