Re: [U-Boot] serial: ns16550: fix debug uart putc called before init
On Wed, Jan 16, 2019 at 05:52:24PM +0100, Simon Goldschmidt wrote: > On Wed, Jan 16, 2019 at 3:44 AM Tom Rini wrote: > > > > On Wed, Jan 09, 2019 at 08:35:31PM +0100, Simon Goldschmidt wrote: > > > > > If _debug_uart_putc() is called before _debug_uart_init(), the > > > ns16550 debug uart driver hangs in a tight loop waiting for the > > > tx FIFO to get empty. > > > > > > As this can happen via a printf sneaking in before the port calls > > > debug_uart_init(), introduce a config option to ignore characters > > > before the debug uart is initialized. > > > > > > This is done by reading the baudrate divisor and aborting if is zero. > > > > > > The Kconfig option is required as reading the baudrate divisor does > > > not seem to work for all ns16500 compatibles (which is why the last > > > attempt on this has been reverted in 1a67969a99). > > > > > > Tested on socfpga_cyclone5_socrates. > > > > > > Signed-off-by: Simon Goldschmidt > > > Reviewed-by: Simon Glass > > > > Applied to u-boot/master, thanks! > > I don't see this or any of my other patches in u-boot/master (neither github > nor denx.de), is that expected? No, that was strange. While I swore I had pushed, apparently I had not. Fixed, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] serial: ns16550: fix debug uart putc called before init
On Wed, Jan 16, 2019 at 3:44 AM Tom Rini wrote: > > On Wed, Jan 09, 2019 at 08:35:31PM +0100, Simon Goldschmidt wrote: > > > If _debug_uart_putc() is called before _debug_uart_init(), the > > ns16550 debug uart driver hangs in a tight loop waiting for the > > tx FIFO to get empty. > > > > As this can happen via a printf sneaking in before the port calls > > debug_uart_init(), introduce a config option to ignore characters > > before the debug uart is initialized. > > > > This is done by reading the baudrate divisor and aborting if is zero. > > > > The Kconfig option is required as reading the baudrate divisor does > > not seem to work for all ns16500 compatibles (which is why the last > > attempt on this has been reverted in 1a67969a99). > > > > Tested on socfpga_cyclone5_socrates. > > > > Signed-off-by: Simon Goldschmidt > > Reviewed-by: Simon Glass > > Applied to u-boot/master, thanks! I don't see this or any of my other patches in u-boot/master (neither github nor denx.de), is that expected? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] serial: ns16550: fix debug uart putc called before init
On Wed, Jan 09, 2019 at 08:35:31PM +0100, Simon Goldschmidt wrote: > If _debug_uart_putc() is called before _debug_uart_init(), the > ns16550 debug uart driver hangs in a tight loop waiting for the > tx FIFO to get empty. > > As this can happen via a printf sneaking in before the port calls > debug_uart_init(), introduce a config option to ignore characters > before the debug uart is initialized. > > This is done by reading the baudrate divisor and aborting if is zero. > > The Kconfig option is required as reading the baudrate divisor does > not seem to work for all ns16500 compatibles (which is why the last > attempt on this has been reverted in 1a67969a99). > > Tested on socfpga_cyclone5_socrates. > > Signed-off-by: Simon Goldschmidt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
