Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity
On 7/24/23 11:49, mihai.s...@microchip.com wrote: Hello Eugen, Thank you for applying the patch. For this board we don't want to use SPL. I will send v2 patch to remove the custom prompt. Thanks. As I said, I won't be applying any patches to at91 tree unless someone helps with the testing below. SPL for this board has nothing to do with my request. These also have to be removed: + +#define CONFIG_SYS_SDRAM_BASE 0x2000 +#define CONFIG_SYS_SDRAM_SIZE 0x2000 as they are forbidden to set in the config file and appear to be unused anyway. Eugen Best regards, Mihai Sain -Original Message- From: Eugen Hristev Sent: Monday, July 24, 2023 11:13 AM To: Mihai Sain - M19926 ; u-boot@lists.denx.de Cc: Cristian Birsan - M91496 Subject: Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hello Mihai, Thank you for the patch. However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow. There is a pending patch that fixes it, but it has not been tested. Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) : https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads Once this is tested you can reply with a Tested-by: tag, and we can move along. Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled. One small nitpick below, and I am looking forward for your reply, Eugen On 7/20/23 10:54, Mihai Sain wrote: Add initial support for sama5d29_curiosity board. Hardware: SoC: SAMA5D29 500 MHz DRAM: LPDDR2 512 MiB PMIC: MCP16502 Debug: UART0 Flash: QSPI NOR 8 MiB RGB LCD connector Mikrobus connectors x 2 SD-Card connectors x 2 USB 2.0 x 2 Signed-off-by: Mihai Sain --- +CONFIG_SYS_PROMPT="[root@sama5d29 ~]$ " Can you remove this. It looks like a Linux prompt and might be confusing for people (and everywhere below)
RE: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity
Hello Eugen, Thank you for applying the patch. For this board we don't want to use SPL. I will send v2 patch to remove the custom prompt. Thanks. Best regards, Mihai Sain -Original Message- From: Eugen Hristev Sent: Monday, July 24, 2023 11:13 AM To: Mihai Sain - M19926 ; u-boot@lists.denx.de Cc: Cristian Birsan - M91496 Subject: Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hello Mihai, Thank you for the patch. However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow. There is a pending patch that fixes it, but it has not been tested. Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) : https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads Once this is tested you can reply with a Tested-by: tag, and we can move along. Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled. One small nitpick below, and I am looking forward for your reply, Eugen On 7/20/23 10:54, Mihai Sain wrote: > Add initial support for sama5d29_curiosity board. > > Hardware: > SoC: SAMA5D29 500 MHz > DRAM: LPDDR2 512 MiB > PMIC: MCP16502 > Debug: UART0 > Flash: QSPI NOR 8 MiB > RGB LCD connector > Mikrobus connectors x 2 > SD-Card connectors x 2 > USB 2.0 x 2 > > Signed-off-by: Mihai Sain > --- > +CONFIG_SYS_PROMPT="[root@sama5d29 ~]$ " Can you remove this. It looks like a Linux prompt and might be confusing for people (and everywhere below)
Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity
Hello Mihai, Thank you for the patch. However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow. There is a pending patch that fixes it, but it has not been tested. Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) : https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads Once this is tested you can reply with a Tested-by: tag, and we can move along. Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled. One small nitpick below, and I am looking forward for your reply, Eugen On 7/20/23 10:54, Mihai Sain wrote: Add initial support for sama5d29_curiosity board. Hardware: SoC: SAMA5D29 500 MHz DRAM: LPDDR2 512 MiB PMIC: MCP16502 Debug: UART0 Flash: QSPI NOR 8 MiB RGB LCD connector Mikrobus connectors x 2 SD-Card connectors x 2 USB 2.0 x 2 Signed-off-by: Mihai Sain --- +CONFIG_SYS_PROMPT="[root@sama5d29 ~]$ " Can you remove this. It looks like a Linux prompt and might be confusing for people (and everywhere below)
[u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity
Add initial support for sama5d29_curiosity board.
Hardware:
SoC: SAMA5D29 500 MHz
DRAM: LPDDR2 512 MiB
PMIC: MCP16502
Debug: UART0
Flash: QSPI NOR 8 MiB
RGB LCD connector
Mikrobus connectors x 2
SD-Card connectors x 2
USB 2.0 x 2
Signed-off-by: Mihai Sain
---
arch/arm/dts/Makefile | 3 +
.../dts/at91-sama5d29_curiosity-u-boot.dtsi | 55 +
arch/arm/dts/at91-sama5d29_curiosity.dts | 219 ++
arch/arm/mach-at91/Kconfig| 12 +
board/atmel/sama5d29_curiosity/Kconfig| 15 ++
board/atmel/sama5d29_curiosity/MAINTAINERS| 8 +
board/atmel/sama5d29_curiosity/Makefile | 7 +
.../sama5d29_curiosity/sama5d29_curiosity.c | 86 +++
configs/sama5d29_curiosity_mmc1_defconfig | 122 ++
configs/sama5d29_curiosity_mmc_defconfig | 121 ++
.../sama5d29_curiosity_qspiflash_defconfig| 121 ++
include/configs/sama5d29_curiosity.h | 20 ++
12 files changed, 789 insertions(+)
create mode 100644 arch/arm/dts/at91-sama5d29_curiosity-u-boot.dtsi
create mode 100644 arch/arm/dts/at91-sama5d29_curiosity.dts
create mode 100644 board/atmel/sama5d29_curiosity/Kconfig
create mode 100644 board/atmel/sama5d29_curiosity/MAINTAINERS
create mode 100644 board/atmel/sama5d29_curiosity/Makefile
create mode 100644 board/atmel/sama5d29_curiosity/sama5d29_curiosity.c
create mode 100644 configs/sama5d29_curiosity_mmc1_defconfig
create mode 100644 configs/sama5d29_curiosity_mmc_defconfig
create mode 100644 configs/sama5d29_curiosity_qspiflash_defconfig
create mode 100644 include/configs/sama5d29_curiosity.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 07b26df275..bf0dc876d4 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -1169,6 +1169,9 @@ dtb-$(CONFIG_TARGET_SAMA5D27_WLSOM1_EK) += \
dtb-$(CONFIG_TARGET_SAMA5D2_ICP) += \
at91-sama5d2_icp.dtb
+dtb-$(CONFIG_TARGET_SAMA5D29_CURIOSITY) += \
+ at91-sama5d29_curiosity.dtb
+
dtb-$(CONFIG_TARGET_SAMA5D3XEK) += \
sama5d31ek.dtb \
sama5d33ek.dtb \
diff --git a/arch/arm/dts/at91-sama5d29_curiosity-u-boot.dtsi
b/arch/arm/dts/at91-sama5d29_curiosity-u-boot.dtsi
new file mode 100644
index 00..798761c98a
--- /dev/null
+++ b/arch/arm/dts/at91-sama5d29_curiosity-u-boot.dtsi
@@ -0,0 +1,55 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * at91-sama5d29_curiosity-u-boot.dtsi - Device Tree file for SAMA5D2 SoC
u-boot properties.
+ *
+ * Copyright (c) 2023, Microchip Technology Inc. and its subsidiaries
+ *
+ * Author: Mihai Sain
+ *
+ */
+
+/ {
+ chosen {
+ bootph-all;
+ };
+};
+
+_qspi1_default {
+ bootph-all;
+};
+
+_sdmmc0_default {
+ bootph-all;
+};
+
+_sdmmc1_default {
+ bootph-all;
+};
+
+ {
+ bootph-all;
+};
+
+ {
+ bootph-all;
+};
+
+ {
+ bootph-all;
+
+ flash@0 {
+ bootph-all;
+ };
+};
+
+ {
+ bootph-all;
+};
+
+ {
+ bootph-all;
+};
+
+ {
+ bootph-all;
+};
diff --git a/arch/arm/dts/at91-sama5d29_curiosity.dts
b/arch/arm/dts/at91-sama5d29_curiosity.dts
new file mode 100644
index 00..eff0e9175a
--- /dev/null
+++ b/arch/arm/dts/at91-sama5d29_curiosity.dts
@@ -0,0 +1,219 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * at91-sama5d29_curiosity.dts - Device Tree file for SAMA5D29 CURIOSITY board
+ *
+ * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries
+ *
+ * Author: Mihai Sain
+ *
+ */
+/dts-v1/;
+#include
+#include
+#include "sama5d2.dtsi"
+#include "sama5d2-pinfunc.h"
+
+/ {
+ model = "Microchip SAMA5D29-Curiosity";
+ compatible = "atmel,sama5d29-curiosity", "atmel,sama5d2", "atmel,sama5";
+
+ chosen {
+ bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw
rootwait";
+ stdout-path =
+ };
+
+ memory {
+ reg = <0x2000 0x2000>; // 512 MiB LPDDR2-333
+ };
+
+ clocks {
+ slow_xtal: slow_xtal {
+ clock-frequency = <32768>;
+ };
+
+ main_xtal: main_xtal {
+ clock-frequency = <2400>;
+ };
+ };
+
+ onewire_tm: onewire {
+ gpios = < PIN_PC9 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <_onewire_tm_default>;
+ status = "okay";
+
+ w1_eeprom: w1_eeprom@0 {
+ compatible = "maxim,ds24b33";
+ status = "okay";
+ };
+ };
+
+ ahb {
+ usb1: ohci@40 {
+ num-ports = <3>;
+ atmel,vbus-gpio = < PIN_PB13 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <_usb_default>;
+ status = "okay";
+ };
+
+ usb2: ehci@50 {
+
