Re: [PATCH] cmd: Add a pwm command
Hi, On Tue, 24 Nov 2020 at 06:23, Tom Rini wrote: > > On Tue, Nov 24, 2020 at 12:41:34PM +, Pragnesh Patel wrote: > > > > > > >-Original Message- > > >From: Tom Rini > > >Sent: 23 November 2020 21:22 > > >To: Pragnesh Patel > > >Cc: u-boot@lists.denx.de; atish.pa...@wdc.com; palmerdabb...@google.com; > > >bmeng...@gmail.com; Paul Walmsley ( Sifive) ; > > >anup.pa...@wdc.com; Sagar Kadam ; > > >r...@andestech.com; Simon Glass ; Heinrich Schuchardt > > >; Bin Meng ; Miquel Raynal > > >; Patrick Delaunay ; > > >Sam Protsenko ; Philippe Reynes > > >; Frédéric Danis > > >; Patrice Chotard ; > > >Vladimir Olovyannikov ; Ramon Fried > > >; Eugeniu Rosca > > >Subject: Re: [PATCH] cmd: Add a pwm command > > > > > >On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > > > > > >> Add the command "pwm" for controlling the pwm channels. This command > > >> provides pwm invert/config/enable/disable functionalities via PWM > > >> uclass drivers > > >> > > >> Signed-off-by: Pragnesh Patel > > >> --- > > >> cmd/Kconfig | 6 +++ > > >> cmd/Makefile | 1 + > > >> cmd/pwm.c| 119 > > >+++ > > >> 3 files changed, 126 insertions(+) > > >> create mode 100644 cmd/pwm.c > > > > > >Can you please add some tests and dt fragments to sandbox for this? > > > > There is already a "test/dm/pwm.c". > > Right, but for the new command as well please, similar to > test/py/tests/test_gpio.py. I would be happier with a C test like [1] as it is faster and allows debugging, etc. Regards, Simon [1] test/cmd/mem_search.c
Re: [PATCH] cmd: Add a pwm command
On Tue, Nov 24, 2020 at 12:41:34PM +, Pragnesh Patel wrote: > > > >-Original Message- > >From: Tom Rini > >Sent: 23 November 2020 21:22 > >To: Pragnesh Patel > >Cc: u-boot@lists.denx.de; atish.pa...@wdc.com; palmerdabb...@google.com; > >bmeng...@gmail.com; Paul Walmsley ( Sifive) ; > >anup.pa...@wdc.com; Sagar Kadam ; > >r...@andestech.com; Simon Glass ; Heinrich Schuchardt > >; Bin Meng ; Miquel Raynal > >; Patrick Delaunay ; > >Sam Protsenko ; Philippe Reynes > >; Frédéric Danis > >; Patrice Chotard ; > >Vladimir Olovyannikov ; Ramon Fried > >; Eugeniu Rosca > >Subject: Re: [PATCH] cmd: Add a pwm command > > > >On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > > > >> Add the command "pwm" for controlling the pwm channels. This command > >> provides pwm invert/config/enable/disable functionalities via PWM > >> uclass drivers > >> > >> Signed-off-by: Pragnesh Patel > >> --- > >> cmd/Kconfig | 6 +++ > >> cmd/Makefile | 1 + > >> cmd/pwm.c| 119 > >+++ > >> 3 files changed, 126 insertions(+) > >> create mode 100644 cmd/pwm.c > > > >Can you please add some tests and dt fragments to sandbox for this? > > There is already a "test/dm/pwm.c". Right, but for the new command as well please, similar to test/py/tests/test_gpio.py. -- Tom signature.asc Description: PGP signature
RE: [PATCH] cmd: Add a pwm command
>-Original Message- >From: Tom Rini >Sent: 23 November 2020 21:22 >To: Pragnesh Patel >Cc: u-boot@lists.denx.de; atish.pa...@wdc.com; palmerdabb...@google.com; >bmeng...@gmail.com; Paul Walmsley ( Sifive) ; >anup.pa...@wdc.com; Sagar Kadam ; >r...@andestech.com; Simon Glass ; Heinrich Schuchardt >; Bin Meng ; Miquel Raynal >; Patrick Delaunay ; >Sam Protsenko ; Philippe Reynes >; Frédéric Danis >; Patrice Chotard ; >Vladimir Olovyannikov ; Ramon Fried >; Eugeniu Rosca >Subject: Re: [PATCH] cmd: Add a pwm command > >On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > >> Add the command "pwm" for controlling the pwm channels. This command >> provides pwm invert/config/enable/disable functionalities via PWM >> uclass drivers >> >> Signed-off-by: Pragnesh Patel >> --- >> cmd/Kconfig | 6 +++ >> cmd/Makefile | 1 + >> cmd/pwm.c| 119 >+++ >> 3 files changed, 126 insertions(+) >> create mode 100644 cmd/pwm.c > >Can you please add some tests and dt fragments to sandbox for this? There is already a "test/dm/pwm.c". >Thanks. > >-- >Tom
Re: [PATCH] cmd: Add a pwm command
On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > Add the command "pwm" for controlling the pwm channels. This > command provides pwm invert/config/enable/disable functionalities > via PWM uclass drivers > > Signed-off-by: Pragnesh Patel > --- > cmd/Kconfig | 6 +++ > cmd/Makefile | 1 + > cmd/pwm.c| 119 +++ > 3 files changed, 126 insertions(+) > create mode 100644 cmd/pwm.c Can you please add some tests and dt fragments to sandbox for this? Thanks. -- Tom signature.asc Description: PGP signature
