RE: [PATCH] mtd: spi: Add Macronix MX25U3235F device

2020-03-31 Thread Tom Warren 
-Original Message-
From: Peter Robinson  
Sent: Tuesday, March 31, 2020 3:00 AM
To: tomcwarren3...@gmail.com
Cc: u-boot@lists.denx.de; Stephen Warren ; Thierry Reding 
; Jonathan Hunter ; Tom Warren 
; ja...@amarulasolutions.com
Subject: Re: [PATCH] mtd: spi: Add Macronix MX25U3235F device

External email: Use caution opening links or attachments


On Thu, Mar 26, 2020 at 9:59 PM  wrote:
>
> From: Tom Warren 
>
> Add Macronix MX25U3235F flash device description.
> This is a 4MiB part.

Is there potentially more than one part used on the Jetson nano as I get the 
following on mine:

Loading Environment from SPI Flash... unrecognized JEDEC id bytes: 00, 40, ff
[Tom] No, just the Macronix 4MB part. You probably need the VI_I2C fix, there 
was a problem with the index of the internal_id table. The Macronix part is 
JEDEC C2, 25, 36 IIRC.
See "i2c: t210: Add VI_I2C clock source support", just posted a few days ago, 
should be in tegra-next.

--nvpublic

> Signed-off-by: Tom Warren 
> ---
>  drivers/mtd/spi/spi-nor-ids.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c 
> b/drivers/mtd/spi/spi-nor-ids.c index 973b6f8..abdf560 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -147,6 +147,7 @@ const struct flash_info spi_nor_ids[] = {
> { INFO("mx25l6405d",  0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> { INFO("mx25u2033e",  0xc22532, 0, 64 * 1024,   4, SECT_4K) },
> { INFO("mx25u1635e",  0xc22535, 0, 64 * 1024,  32, SECT_4K) },
> +   { INFO("mx25u3235f",  0xc22536, 0, 4 * 1024,  1024, SECT_4K) 
> + },
> { INFO("mx25u6435f",  0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, 0) },
> { INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) },
> --
> 1.8.2.1.610.g562af5b
>
>
> --
> - This email message is for the sole use of the intended 
> recipient(s) and may contain confidential information.  Any 
> unauthorized review, use, disclosure or distribution is prohibited.  
> If you are not the intended recipient, please contact the sender by 
> reply email and destroy all copies of the original message.
> --
> -

Re: [PATCH] mtd: spi: Add Macronix MX25U3235F device

2020-03-31 Thread Peter Robinson 
On Thu, Mar 26, 2020 at 9:59 PM  wrote:
>
> From: Tom Warren 
>
> Add Macronix MX25U3235F flash device description.
> This is a 4MiB part.

Is there potentially more than one part used on the Jetson nano as I
get the following on mine:

Loading Environment from SPI Flash... unrecognized JEDEC id bytes: 00, 40, ff

> Signed-off-by: Tom Warren 
> ---
>  drivers/mtd/spi/spi-nor-ids.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 973b6f8..abdf560 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -147,6 +147,7 @@ const struct flash_info spi_nor_ids[] = {
> { INFO("mx25l6405d",  0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> { INFO("mx25u2033e",  0xc22532, 0, 64 * 1024,   4, SECT_4K) },
> { INFO("mx25u1635e",  0xc22535, 0, 64 * 1024,  32, SECT_4K) },
> +   { INFO("mx25u3235f",  0xc22536, 0, 4 * 1024,  1024, SECT_4K) },
> { INFO("mx25u6435f",  0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> { INFO("mx25l12805d", 0xc22018, 0, 64 * 1024, 256, 0) },
> { INFO("mx25l12855e", 0xc22618, 0, 64 * 1024, 256, 0) },
> --
> 1.8.2.1.610.g562af5b
>
>
> ---
> This email message is for the sole use of the intended recipient(s) and may 
> contain
> confidential information.  Any unauthorized review, use, disclosure or 
> distribution
> is prohibited.  If you are not the intended recipient, please contact the 
> sender by
> reply email and destroy all copies of the original message.
> ---