Re: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices
чт, 20 лип. 2023 р. о 09:17 Jaehoon Chung пише: > > > > > -Original Message- > > From: Svyatoslav Ryhel > > Sent: Thursday, July 20, 2023 12:26 PM > > To: Jaehoon Chung ; 'Simon Glass' > > > > Cc: u-boot@lists.denx.de > > Subject: RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices > > > > > > > > 20 липня 2023 р. 06:12:23 GMT+03:00, Jaehoon Chung > > написав(-ла): > > >Hi > > > > > >> -Original Message- > > >> From: Svyatoslav Ryhel > > >> Sent: Saturday, July 15, 2023 1:16 AM > > >> To: Jaehoon Chung ; Simon Glass > > >> ; Svyatoslav Ryhel > > >> > > >> Cc: u-boot@lists.denx.de > > >> Subject: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices > > >> > > >> Patch set adds basic support for PMICs used in many Tegra 3 devices. > > >> All PMIC drivers are based on datasheets provided by vendors. > > >> Implemented API include regulator set/get voltage enable/disable and > > >> basic PMIC r/w capabilities. > > >> > > >> Drivers were tested by me on LG P895 (max77663), HTC One X (TPS80032) > > >> and ASUS TF300T (tps65911). Calculations and behavior were correct, > > >> predictable and reproducible. > > > > > >I didn't find where those drivers is using. Do you have any plan to update > > >the enabling CONFIG? > > >I hope the enabling CONFIG will be included. Otherwise, I can't check > > >whether its building is fine or > > not. > > >If I missed some patches, let me know, plz > > > > > >Until enabled CONFIG, these drivers can be dead codes. > > > > Enabling configs is planned as next step of this > > https://protect2.fireeye.com/v1/url?k=a8a63aa5- > > c92d2f85-a8a7b1ea-74fe485fb347-c1cc2b9c6f97e343=1=c08f18ed-4f66-46bb-b871- > > 17167bc5b502=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D361808 > > patchset (initial bringup of devices). Unfortunately tegra custodians are > > too "busy" to initiate merge > > of those devices. > > Thanks for sharing information. :) Ye, you're welcome I guess :) These mailing lists kill me. Search in patchwork for series called "Tegra: add ASUS/Google Nexus 7 (2012) support" it contains devices I have mentioned. > Best Regards, > Jaehoon Chung > > > > > >Best Regards, > > >Jaehoon Chung > > > > > >> > > >> Svyatoslav Ryhel (6): > > >> power: pmic: add the base max77663 pmic support > > >> power: regulator: max77663: add regulator support > > >> power: pmic: add the base TPS80031 PMIC support > > >> power: regulator: tps80031: add regulator support > > >> power: pmic: tps65910: add TPS65911 PMIC support > > >> power: regulator: tps65911: add regulator support > > >> > > >> doc/device-tree-bindings/pmic/max77663.txt | 84 + > > >> doc/device-tree-bindings/pmic/tps65911.txt | 78 > > >> doc/device-tree-bindings/pmic/tps80031.txt | 76 > > >> drivers/power/pmic/Kconfig | 12 + > > >> drivers/power/pmic/Makefile | 2 + > > >> drivers/power/pmic/max77663.c| 81 > > >> drivers/power/pmic/pmic_tps65910_dm.c| 26 +- > > >> drivers/power/pmic/tps80031.c| 82 > > >> drivers/power/regulator/Kconfig | 24 ++ > > >> drivers/power/regulator/Makefile | 3 + > > >> drivers/power/regulator/max77663_regulator.c | 362 ++ > > >> drivers/power/regulator/tps65911_regulator.c | 375 +++ > > >> drivers/power/regulator/tps80031_regulator.c | 296 +++ > > >> include/power/max77663.h | 40 ++ > > >> include/power/tps65910_pmic.h| 47 +++ > > >> include/power/tps80031.h | 42 +++ > > >> 16 files changed, 1627 insertions(+), 3 deletions(-) > > >> create mode 100644 doc/device-tree-bindings/pmic/max77663.txt > > >> create mode 100644 doc/device-tree-bindings/pmic/tps65911.txt > > >> create mode 100644 doc/device-tree-bindings/pmic/tps80031.txt > > >> create mode 100644 drivers/power/pmic/max77663.c > > >> create mode 100644 drivers/power/pmic/tps80031.c > > >> create mode 100644 drivers/power/regulator/max77663_regulator.c > > >> create mode 100644 drivers/power/regulator/tps65911_regulator.c > > >> create mode 100644 drivers/power/regulator/tps80031_regulator.c > > >> create mode 100644 include/power/max77663.h > > >> create mode 100644 include/power/tps80031.h > > >> > > >> -- > > >> 2.39.2 > > > > > > > >
RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices
> -Original Message- > From: Svyatoslav Ryhel > Sent: Thursday, July 20, 2023 12:26 PM > To: Jaehoon Chung ; 'Simon Glass' > Cc: u-boot@lists.denx.de > Subject: RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices > > > > 20 липня 2023 р. 06:12:23 GMT+03:00, Jaehoon Chung > написав(-ла): > >Hi > > > >> -Original Message- > >> From: Svyatoslav Ryhel > >> Sent: Saturday, July 15, 2023 1:16 AM > >> To: Jaehoon Chung ; Simon Glass > >> ; Svyatoslav Ryhel > >> > >> Cc: u-boot@lists.denx.de > >> Subject: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices > >> > >> Patch set adds basic support for PMICs used in many Tegra 3 devices. > >> All PMIC drivers are based on datasheets provided by vendors. > >> Implemented API include regulator set/get voltage enable/disable and > >> basic PMIC r/w capabilities. > >> > >> Drivers were tested by me on LG P895 (max77663), HTC One X (TPS80032) > >> and ASUS TF300T (tps65911). Calculations and behavior were correct, > >> predictable and reproducible. > > > >I didn't find where those drivers is using. Do you have any plan to update > >the enabling CONFIG? > >I hope the enabling CONFIG will be included. Otherwise, I can't check > >whether its building is fine or > not. > >If I missed some patches, let me know, plz > > > >Until enabled CONFIG, these drivers can be dead codes. > > Enabling configs is planned as next step of this > https://protect2.fireeye.com/v1/url?k=a8a63aa5- > c92d2f85-a8a7b1ea-74fe485fb347-c1cc2b9c6f97e343=1=c08f18ed-4f66-46bb-b871- > 17167bc5b502=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D361808 > patchset (initial bringup of devices). Unfortunately tegra custodians are too > "busy" to initiate merge > of those devices. Thanks for sharing information. :) Best Regards, Jaehoon Chung > > >Best Regards, > >Jaehoon Chung > > > >> > >> Svyatoslav Ryhel (6): > >> power: pmic: add the base max77663 pmic support > >> power: regulator: max77663: add regulator support > >> power: pmic: add the base TPS80031 PMIC support > >> power: regulator: tps80031: add regulator support > >> power: pmic: tps65910: add TPS65911 PMIC support > >> power: regulator: tps65911: add regulator support > >> > >> doc/device-tree-bindings/pmic/max77663.txt | 84 + > >> doc/device-tree-bindings/pmic/tps65911.txt | 78 > >> doc/device-tree-bindings/pmic/tps80031.txt | 76 > >> drivers/power/pmic/Kconfig | 12 + > >> drivers/power/pmic/Makefile | 2 + > >> drivers/power/pmic/max77663.c| 81 > >> drivers/power/pmic/pmic_tps65910_dm.c| 26 +- > >> drivers/power/pmic/tps80031.c| 82 > >> drivers/power/regulator/Kconfig | 24 ++ > >> drivers/power/regulator/Makefile | 3 + > >> drivers/power/regulator/max77663_regulator.c | 362 ++ > >> drivers/power/regulator/tps65911_regulator.c | 375 +++ > >> drivers/power/regulator/tps80031_regulator.c | 296 +++ > >> include/power/max77663.h | 40 ++ > >> include/power/tps65910_pmic.h| 47 +++ > >> include/power/tps80031.h | 42 +++ > >> 16 files changed, 1627 insertions(+), 3 deletions(-) > >> create mode 100644 doc/device-tree-bindings/pmic/max77663.txt > >> create mode 100644 doc/device-tree-bindings/pmic/tps65911.txt > >> create mode 100644 doc/device-tree-bindings/pmic/tps80031.txt > >> create mode 100644 drivers/power/pmic/max77663.c > >> create mode 100644 drivers/power/pmic/tps80031.c > >> create mode 100644 drivers/power/regulator/max77663_regulator.c > >> create mode 100644 drivers/power/regulator/tps65911_regulator.c > >> create mode 100644 drivers/power/regulator/tps80031_regulator.c > >> create mode 100644 include/power/max77663.h > >> create mode 100644 include/power/tps80031.h > >> > >> -- > >> 2.39.2 > > > >
RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices
20 липня 2023 р. 06:12:23 GMT+03:00, Jaehoon Chung написав(-ла): >Hi > >> -Original Message- >> From: Svyatoslav Ryhel >> Sent: Saturday, July 15, 2023 1:16 AM >> To: Jaehoon Chung ; Simon Glass ; >> Svyatoslav Ryhel >> >> Cc: u-boot@lists.denx.de >> Subject: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices >> >> Patch set adds basic support for PMICs used in many Tegra 3 devices. >> All PMIC drivers are based on datasheets provided by vendors. >> Implemented API include regulator set/get voltage enable/disable and >> basic PMIC r/w capabilities. >> >> Drivers were tested by me on LG P895 (max77663), HTC One X (TPS80032) >> and ASUS TF300T (tps65911). Calculations and behavior were correct, >> predictable and reproducible. > >I didn't find where those drivers is using. Do you have any plan to update the >enabling CONFIG? >I hope the enabling CONFIG will be included. Otherwise, I can't check whether >its building is fine or not. >If I missed some patches, let me know, plz > >Until enabled CONFIG, these drivers can be dead codes. Enabling configs is planned as next step of this https://patchwork.ozlabs.org/project/uboot/list/?series=361808 patchset (initial bringup of devices). Unfortunately tegra custodians are too "busy" to initiate merge of those devices. >Best Regards, >Jaehoon Chung > >> >> Svyatoslav Ryhel (6): >> power: pmic: add the base max77663 pmic support >> power: regulator: max77663: add regulator support >> power: pmic: add the base TPS80031 PMIC support >> power: regulator: tps80031: add regulator support >> power: pmic: tps65910: add TPS65911 PMIC support >> power: regulator: tps65911: add regulator support >> >> doc/device-tree-bindings/pmic/max77663.txt | 84 + >> doc/device-tree-bindings/pmic/tps65911.txt | 78 >> doc/device-tree-bindings/pmic/tps80031.txt | 76 >> drivers/power/pmic/Kconfig | 12 + >> drivers/power/pmic/Makefile | 2 + >> drivers/power/pmic/max77663.c| 81 >> drivers/power/pmic/pmic_tps65910_dm.c| 26 +- >> drivers/power/pmic/tps80031.c| 82 >> drivers/power/regulator/Kconfig | 24 ++ >> drivers/power/regulator/Makefile | 3 + >> drivers/power/regulator/max77663_regulator.c | 362 ++ >> drivers/power/regulator/tps65911_regulator.c | 375 +++ >> drivers/power/regulator/tps80031_regulator.c | 296 +++ >> include/power/max77663.h | 40 ++ >> include/power/tps65910_pmic.h| 47 +++ >> include/power/tps80031.h | 42 +++ >> 16 files changed, 1627 insertions(+), 3 deletions(-) >> create mode 100644 doc/device-tree-bindings/pmic/max77663.txt >> create mode 100644 doc/device-tree-bindings/pmic/tps65911.txt >> create mode 100644 doc/device-tree-bindings/pmic/tps80031.txt >> create mode 100644 drivers/power/pmic/max77663.c >> create mode 100644 drivers/power/pmic/tps80031.c >> create mode 100644 drivers/power/regulator/max77663_regulator.c >> create mode 100644 drivers/power/regulator/tps65911_regulator.c >> create mode 100644 drivers/power/regulator/tps80031_regulator.c >> create mode 100644 include/power/max77663.h >> create mode 100644 include/power/tps80031.h >> >> -- >> 2.39.2 > >
RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices
Hi > -Original Message- > From: Svyatoslav Ryhel > Sent: Saturday, July 15, 2023 1:16 AM > To: Jaehoon Chung ; Simon Glass ; > Svyatoslav Ryhel > > Cc: u-boot@lists.denx.de > Subject: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices > > Patch set adds basic support for PMICs used in many Tegra 3 devices. > All PMIC drivers are based on datasheets provided by vendors. > Implemented API include regulator set/get voltage enable/disable and > basic PMIC r/w capabilities. > > Drivers were tested by me on LG P895 (max77663), HTC One X (TPS80032) > and ASUS TF300T (tps65911). Calculations and behavior were correct, > predictable and reproducible. I didn't find where those drivers is using. Do you have any plan to update the enabling CONFIG? I hope the enabling CONFIG will be included. Otherwise, I can't check whether its building is fine or not. If I missed some patches, let me know, plz Until enabled CONFIG, these drivers can be dead codes. Best Regards, Jaehoon Chung > > Svyatoslav Ryhel (6): > power: pmic: add the base max77663 pmic support > power: regulator: max77663: add regulator support > power: pmic: add the base TPS80031 PMIC support > power: regulator: tps80031: add regulator support > power: pmic: tps65910: add TPS65911 PMIC support > power: regulator: tps65911: add regulator support > > doc/device-tree-bindings/pmic/max77663.txt | 84 + > doc/device-tree-bindings/pmic/tps65911.txt | 78 > doc/device-tree-bindings/pmic/tps80031.txt | 76 > drivers/power/pmic/Kconfig | 12 + > drivers/power/pmic/Makefile | 2 + > drivers/power/pmic/max77663.c| 81 > drivers/power/pmic/pmic_tps65910_dm.c| 26 +- > drivers/power/pmic/tps80031.c| 82 > drivers/power/regulator/Kconfig | 24 ++ > drivers/power/regulator/Makefile | 3 + > drivers/power/regulator/max77663_regulator.c | 362 ++ > drivers/power/regulator/tps65911_regulator.c | 375 +++ > drivers/power/regulator/tps80031_regulator.c | 296 +++ > include/power/max77663.h | 40 ++ > include/power/tps65910_pmic.h| 47 +++ > include/power/tps80031.h | 42 +++ > 16 files changed, 1627 insertions(+), 3 deletions(-) > create mode 100644 doc/device-tree-bindings/pmic/max77663.txt > create mode 100644 doc/device-tree-bindings/pmic/tps65911.txt > create mode 100644 doc/device-tree-bindings/pmic/tps80031.txt > create mode 100644 drivers/power/pmic/max77663.c > create mode 100644 drivers/power/pmic/tps80031.c > create mode 100644 drivers/power/regulator/max77663_regulator.c > create mode 100644 drivers/power/regulator/tps65911_regulator.c > create mode 100644 drivers/power/regulator/tps80031_regulator.c > create mode 100644 include/power/max77663.h > create mode 100644 include/power/tps80031.h > > -- > 2.39.2
Re: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices
Greetings! I have one more improvement for these drivers which is implementation of do_poweroff ability directly into them. I have tested it already and it is a trivial task. What is non trivial is that pmic can be not responsible for poweroff if the device uses 2 or more pmics. Solution I am looking into is use of 'system-power-controller' device tree property to indicate PMIC used for poweroff function. Issue I have encountered is how to properly convert dts prop into #ifdef to be able to hide or expose do_poweroff at will, and if this is allowed at all in u-boot. Best regards, Svyatoslav R. пт, 14 лип. 2023 р. о 19:16 Svyatoslav Ryhel пише: > > Patch set adds basic support for PMICs used in many Tegra 3 devices. > All PMIC drivers are based on datasheets provided by vendors. > Implemented API include regulator set/get voltage enable/disable and > basic PMIC r/w capabilities. > > Drivers were tested by me on LG P895 (max77663), HTC One X (TPS80032) > and ASUS TF300T (tps65911). Calculations and behavior were correct, > predictable and reproducible. > > Svyatoslav Ryhel (6): > power: pmic: add the base max77663 pmic support > power: regulator: max77663: add regulator support > power: pmic: add the base TPS80031 PMIC support > power: regulator: tps80031: add regulator support > power: pmic: tps65910: add TPS65911 PMIC support > power: regulator: tps65911: add regulator support > > doc/device-tree-bindings/pmic/max77663.txt | 84 + > doc/device-tree-bindings/pmic/tps65911.txt | 78 > doc/device-tree-bindings/pmic/tps80031.txt | 76 > drivers/power/pmic/Kconfig | 12 + > drivers/power/pmic/Makefile | 2 + > drivers/power/pmic/max77663.c| 81 > drivers/power/pmic/pmic_tps65910_dm.c| 26 +- > drivers/power/pmic/tps80031.c| 82 > drivers/power/regulator/Kconfig | 24 ++ > drivers/power/regulator/Makefile | 3 + > drivers/power/regulator/max77663_regulator.c | 362 ++ > drivers/power/regulator/tps65911_regulator.c | 375 +++ > drivers/power/regulator/tps80031_regulator.c | 296 +++ > include/power/max77663.h | 40 ++ > include/power/tps65910_pmic.h| 47 +++ > include/power/tps80031.h | 42 +++ > 16 files changed, 1627 insertions(+), 3 deletions(-) > create mode 100644 doc/device-tree-bindings/pmic/max77663.txt > create mode 100644 doc/device-tree-bindings/pmic/tps65911.txt > create mode 100644 doc/device-tree-bindings/pmic/tps80031.txt > create mode 100644 drivers/power/pmic/max77663.c > create mode 100644 drivers/power/pmic/tps80031.c > create mode 100644 drivers/power/regulator/max77663_regulator.c > create mode 100644 drivers/power/regulator/tps65911_regulator.c > create mode 100644 drivers/power/regulator/tps80031_regulator.c > create mode 100644 include/power/max77663.h > create mode 100644 include/power/tps80031.h > > -- > 2.39.2 >
