RE: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
> Subject: Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to
> OF_UPSTREAM
>
> On Wed, Mar 27, 2024 at 8:53 PM Peng Fan (OSS)
> wrote:
>
> > + {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clock-frequency = <40>;
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <_lpi2c2>;
> > + pinctrl-1 = <_lpi2c2>;
> > + status = "okay";
> > +
> > + pmic@25 {
>
> > + adp5585gpio: gpio@34 {
> > + compatible = "adp5585";
> > + reg = <0x34>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
>
> Please add a comment saying these nodes are already available in 6.9-rc1.
Just gave a check on linux-next/master, the nodes are not there.
Thanks,
Peng
>
> > --- a/arch/arm/mach-imx/imx9/Kconfig
> > +++ b/arch/arm/mach-imx/imx9/Kconfig
> > @@ -31,6 +31,7 @@ choice
> > config TARGET_IMX93_11X11_EVK
> > bool "imx93_11x11_evk"
> > select IMX93
> > + imply OF_UPSTREAM
>
> Sumit and I asked you to add OF_UPSTREAM to all imx93 boards, not just this
> one.
>
> Please don't ignore review comments.
RE: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
> Subject: Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to > OF_UPSTREAM > > Hi Peng, > > On Wed, Mar 27, 2024 at 9:40 PM Peng Fan wrote: > > > I could help convert all imx93 boards, but I could only test nxp > > imx93 boards, not able to test others. > > Just copy the board maintainers in your patch and they could help test the > conversion to OF_UPSTREAM. ok, I need use v6.9-rc1-dts for the dts upstream. Some dts not in v6.8-dts. Thanks, Peng. > > Thanks!
Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
Hi Peng, On Wed, Mar 27, 2024 at 9:40 PM Peng Fan wrote: > I could help convert all imx93 boards, but I could only test nxp > imx93 boards, not able to test others. Just copy the board maintainers in your patch and they could help test the conversion to OF_UPSTREAM. Thanks!
RE: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
> Subject: Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to
> OF_UPSTREAM
>
> On Wed, Mar 27, 2024 at 8:53 PM Peng Fan (OSS)
> wrote:
>
> > + {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + clock-frequency = <40>;
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <_lpi2c2>;
> > + pinctrl-1 = <_lpi2c2>;
> > + status = "okay";
> > +
> > + pmic@25 {
>
> > + adp5585gpio: gpio@34 {
> > + compatible = "adp5585";
> > + reg = <0x34>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
>
> Please add a comment saying these nodes are already available in 6.9-rc1.
>
> > --- a/arch/arm/mach-imx/imx9/Kconfig
> > +++ b/arch/arm/mach-imx/imx9/Kconfig
> > @@ -31,6 +31,7 @@ choice
> > config TARGET_IMX93_11X11_EVK
> > bool "imx93_11x11_evk"
> > select IMX93
> > + imply OF_UPSTREAM
>
> Sumit and I asked you to add OF_UPSTREAM to all imx93 boards, not just this
> one.
I could help convert all imx93 boards, but I could only test nxp
imx93 boards, not able to test others.
Thanks,
Peng.
>
> Please don't ignore review comments.
Re: [PATCH v3 6/6] imx: imx93-11x11-evk: convert to OF_UPSTREAM
On Wed, Mar 27, 2024 at 8:53 PM Peng Fan (OSS) wrote:
> + {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clock-frequency = <40>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <_lpi2c2>;
> + pinctrl-1 = <_lpi2c2>;
> + status = "okay";
> +
> + pmic@25 {
> + adp5585gpio: gpio@34 {
> + compatible = "adp5585";
> + reg = <0x34>;
> + gpio-controller;
> + #gpio-cells = <2>;
Please add a comment saying these nodes are already available in 6.9-rc1.
> --- a/arch/arm/mach-imx/imx9/Kconfig
> +++ b/arch/arm/mach-imx/imx9/Kconfig
> @@ -31,6 +31,7 @@ choice
> config TARGET_IMX93_11X11_EVK
> bool "imx93_11x11_evk"
> select IMX93
> + imply OF_UPSTREAM
Sumit and I asked you to add OF_UPSTREAM to all imx93 boards, not just this one.
Please don't ignore review comments.
