Re: [PATCH v4 0/6] board: siemens: clean up subfolders
On Mon, Jan 22, 2024 at 08:33:14AM +, Leto, Enrico wrote: > > > > -Original Message- > > From: Tom Rini > > Sent: Thursday, January 18, 2024 4:16 PM > > To: Leto, Enrico (SI BP R&D ZG FW CCP) > > Cc: u-boot@lists.denx.de; Sverdlin, Alexander (SI BP R&D ZG FW CCP) > > > > Subject: Re: [PATCH v4 0/6] board: siemens: clean up subfolders > > > > On Wed, Jan 03, 2024 at 02:31:48PM +0100, Enrico Leto wrote: > > > > > This serie depends on the serie: > > > [PATCH 0/6] siemens,am335x: clean up the draco board family > > > > Is this not applied already? If not, where is it? Can you please repost it? > > > > Yes, it's applied. I'll remove these lines. OK. > > > The common folder was initialially created for the common parts of > > > the products based on draco-am355x board family. We have the > > > product lines 'pxm2', 'rut' and the base line unfortunately named > > > 'draco'! Adding the new capricorn-imx8 board family, the files > > > were enhanced without cleanup. > > > > > > Simplify first EEPROM probe and access that implements both i2c > > > with & without driver model. Use abstraction functions for this. > > > > > > Move all am355x specifics to a new file 'board_am335x'. > > > > > > Clean-up includes, config checks, maintainer. > > > > > > Signed-off-by: Enrico Leto > > > > The problem is that I see: > > > > > > > --- > > >rm: + draco-etamin > > +(draco-etamin) board/siemens/draco/../common/board.c: In function > > 'board_init': > > +(draco-etamin) board/siemens/draco/../common/board.c:88:9: error: > > implicit declaration of function 'board_nand_cs_init' [-Werror=implicit- > > function-declaration] > > +(draco-etamin)88 | board_nand_cs_init(); > > +(draco-etamin) | ^~ > > +(draco-etamin) cc1: all warnings being treated as errors > > +(draco-etamin) make[2]: *** [scripts/Makefile.build:257: > > +board/siemens/draco/../common/board.o] Error 1 > > +(draco-etamin) make[1]: *** [Makefile:1859: board/siemens/draco] Error > > +2 > > +(draco-etamin) make: *** [Makefile:177: sub-make] Error 2 > > I'll check why I have not seen this problem by me and fix it. Thanks. > >aarch64: + Deneb > > +(deneb) WARNING 'ahab-container.img' not found, resulting binary is > > +not-functional > > +(deneb) aarch64-linux-ld.bfd: > > board/siemens/capricorn/../common/factoryset.o: in function > > `factoryset_read_eeprom': > > +(deneb) > > board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read > > _eeprom+0x2c): undefined reference to `siemens_ee_read_data' > > +(deneb) aarch64-linux-ld.bfd: > > board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read > > _eeprom+0xb4): undefined reference to `siemens_ee_read_data' > > +(deneb) aarch64-linux-ld.bfd: > > board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read > > _eeprom+0x264): undefined reference to `siemens_ee_read_data' > > +(deneb) make[1]: *** [Makefile:1766: u-boot] Error 139 > > +(deneb) make[1]: *** Deleting file 'u-boot' > > +(deneb) make: *** [Makefile:177: sub-make] Error 2 > >aarch64: + giedi > > +(giedi) WARNING 'ahab-container.img' not found, resulting binary is > > +not-functional > > +(giedi) aarch64-linux-ld.bfd: > > board/siemens/capricorn/../common/factoryset.o: in function > > `factoryset_read_eeprom': > > +(giedi) > > board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read > > _eeprom+0x2c): undefined reference to `siemens_ee_read_data' > > +(giedi) aarch64-linux-ld.bfd: > > board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read > > _eeprom+0xb4): undefined reference to `siemens_ee_read_data' > > +(giedi) aarch64-linux-ld.bfd: > > board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read > > _eeprom+0x264): undefined reference to `siemens_ee_read_data' > > +(giedi) make[1]: *** [Makefile:1766: u-boot] Error 139 > > +(giedi) make[1]: *** Deleting file 'u-boot' > > +(giedi) make: *** [Makefile:177: sub-make] Error 2 > > 'giedi' & 'deneb' are based on imx8x board. This is another family that are > not affected from this patch serie. Well, you're changing the common siemens code and that does change those platforms as they use it too, which is why they fail now. > This patch serie is not the cause of these warnings and will not resolve them. The ahab messages are expected when we don't have all of the blobs, and that's fine. > Additional info. > We also have everywhere this warning since u-boot version 2020 or 2021. This > doesn't affect the u-boot/SPL outputs. The complete boot container incl. > 'ahab-container.img' is built separately with the mkimage tool of NXP. > On first appearing of this warning we asked NXP. They didn't improve any > solution. Maybe there is now a setting to remove this warning. > A patch serie is planned for our imx8x boards. OK. -- Tom signature.asc Description: PGP signature
RE: [PATCH v4 0/6] board: siemens: clean up subfolders
Hi Tom, > -Original Message- > From: Tom Rini > Sent: Thursday, January 18, 2024 4:16 PM > To: Leto, Enrico (SI BP R&D ZG FW CCP) > Cc: u-boot@lists.denx.de; Sverdlin, Alexander (SI BP R&D ZG FW CCP) > > Subject: Re: [PATCH v4 0/6] board: siemens: clean up subfolders > > On Wed, Jan 03, 2024 at 02:31:48PM +0100, Enrico Leto wrote: > > > This serie depends on the serie: > > [PATCH 0/6] siemens,am335x: clean up the draco board family > > Is this not applied already? If not, where is it? Can you please repost it? > Yes, it's applied. I'll remove these lines. > > > > The common folder was initialially created for the common parts of > > the products based on draco-am355x board family. We have the > > product lines 'pxm2', 'rut' and the base line unfortunately named > > 'draco'! Adding the new capricorn-imx8 board family, the files > > were enhanced without cleanup. > > > > Simplify first EEPROM probe and access that implements both i2c > > with & without driver model. Use abstraction functions for this. > > > > Move all am355x specifics to a new file 'board_am335x'. > > > > Clean-up includes, config checks, maintainer. > > > > Signed-off-by: Enrico Leto > > The problem is that I see: > > > > --- > >rm: + draco-etamin > +(draco-etamin) board/siemens/draco/../common/board.c: In function > 'board_init': > +(draco-etamin) board/siemens/draco/../common/board.c:88:9: error: > implicit declaration of function 'board_nand_cs_init' [-Werror=implicit- > function-declaration] > +(draco-etamin)88 | board_nand_cs_init(); > +(draco-etamin) | ^~ > +(draco-etamin) cc1: all warnings being treated as errors > +(draco-etamin) make[2]: *** [scripts/Makefile.build:257: > +board/siemens/draco/../common/board.o] Error 1 > +(draco-etamin) make[1]: *** [Makefile:1859: board/siemens/draco] Error > +2 > +(draco-etamin) make: *** [Makefile:177: sub-make] Error 2 I'll check why I have not seen this problem by me and fix it. >aarch64: + deneb > +(deneb) WARNING 'ahab-container.img' not found, resulting binary is > +not-functional > +(deneb) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.o: in function > `factoryset_read_eeprom': > +(deneb) > board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read > _eeprom+0x2c): undefined reference to `siemens_ee_read_data' > +(deneb) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read > _eeprom+0xb4): undefined reference to `siemens_ee_read_data' > +(deneb) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read > _eeprom+0x264): undefined reference to `siemens_ee_read_data' > +(deneb) make[1]: *** [Makefile:1766: u-boot] Error 139 > +(deneb) make[1]: *** Deleting file 'u-boot' > +(deneb) make: *** [Makefile:177: sub-make] Error 2 >aarch64: + giedi > +(giedi) WARNING 'ahab-container.img' not found, resulting binary is > +not-functional > +(giedi) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.o: in function > `factoryset_read_eeprom': > +(giedi) > board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read > _eeprom+0x2c): undefined reference to `siemens_ee_read_data' > +(giedi) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read > _eeprom+0xb4): undefined reference to `siemens_ee_read_data' > +(giedi) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read > _eeprom+0x264): undefined reference to `siemens_ee_read_data' > +(giedi) make[1]: *** [Makefile:1766: u-boot] Error 139 > +(giedi) make[1]: *** Deleting file 'u-boot' > +(giedi) make: *** [Makefile:177: sub-make] Error 2 'giedi' & 'deneb' are based on imx8x board. This is another family that are not affected from this patch serie. This patch serie is not the cause of these warnings and will not resolve them. Additional info. We also have everywhere this warning since u-boot version 2020 or 2021. This doesn't affect the u-boot/SPL outputs. The complete boot container incl. 'ahab-container.img' is built separately with the mkimage tool of NXP. On first appearing of this warning we asked NXP. They didn't improve any solution. Maybe there is now a setting to remove this warning. A patch serie is planned for our imx8x boards. > > When building. > > -- > Tom Enrico
RE: [PATCH v4 0/6] board: siemens: clean up subfolders
> -Original Message- > From: Tom Rini > Sent: Thursday, January 18, 2024 4:16 PM > To: Leto, Enrico (SI BP R&D ZG FW CCP) > Cc: u-boot@lists.denx.de; Sverdlin, Alexander (SI BP R&D ZG FW CCP) > > Subject: Re: [PATCH v4 0/6] board: siemens: clean up subfolders > > On Wed, Jan 03, 2024 at 02:31:48PM +0100, Enrico Leto wrote: > > > This serie depends on the serie: > > [PATCH 0/6] siemens,am335x: clean up the draco board family > > Is this not applied already? If not, where is it? Can you please repost it? > Yes, it's applied. I'll remove these lines. > > > > The common folder was initialially created for the common parts of > > the products based on draco-am355x board family. We have the > > product lines 'pxm2', 'rut' and the base line unfortunately named > > 'draco'! Adding the new capricorn-imx8 board family, the files > > were enhanced without cleanup. > > > > Simplify first EEPROM probe and access that implements both i2c > > with & without driver model. Use abstraction functions for this. > > > > Move all am355x specifics to a new file 'board_am335x'. > > > > Clean-up includes, config checks, maintainer. > > > > Signed-off-by: Enrico Leto > > The problem is that I see: > > > > --- > >rm: + draco-etamin > +(draco-etamin) board/siemens/draco/../common/board.c: In function > 'board_init': > +(draco-etamin) board/siemens/draco/../common/board.c:88:9: error: > implicit declaration of function 'board_nand_cs_init' [-Werror=implicit- > function-declaration] > +(draco-etamin)88 | board_nand_cs_init(); > +(draco-etamin) | ^~ > +(draco-etamin) cc1: all warnings being treated as errors > +(draco-etamin) make[2]: *** [scripts/Makefile.build:257: > +board/siemens/draco/../common/board.o] Error 1 > +(draco-etamin) make[1]: *** [Makefile:1859: board/siemens/draco] Error > +2 > +(draco-etamin) make: *** [Makefile:177: sub-make] Error 2 I'll check why I have not seen this problem by me and fix it. >aarch64: + Deneb > +(deneb) WARNING 'ahab-container.img' not found, resulting binary is > +not-functional > +(deneb) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.o: in function > `factoryset_read_eeprom': > +(deneb) > board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read > _eeprom+0x2c): undefined reference to `siemens_ee_read_data' > +(deneb) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read > _eeprom+0xb4): undefined reference to `siemens_ee_read_data' > +(deneb) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read > _eeprom+0x264): undefined reference to `siemens_ee_read_data' > +(deneb) make[1]: *** [Makefile:1766: u-boot] Error 139 > +(deneb) make[1]: *** Deleting file 'u-boot' > +(deneb) make: *** [Makefile:177: sub-make] Error 2 >aarch64: + giedi > +(giedi) WARNING 'ahab-container.img' not found, resulting binary is > +not-functional > +(giedi) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.o: in function > `factoryset_read_eeprom': > +(giedi) > board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read > _eeprom+0x2c): undefined reference to `siemens_ee_read_data' > +(giedi) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read > _eeprom+0xb4): undefined reference to `siemens_ee_read_data' > +(giedi) aarch64-linux-ld.bfd: > board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read > _eeprom+0x264): undefined reference to `siemens_ee_read_data' > +(giedi) make[1]: *** [Makefile:1766: u-boot] Error 139 > +(giedi) make[1]: *** Deleting file 'u-boot' > +(giedi) make: *** [Makefile:177: sub-make] Error 2 'giedi' & 'deneb' are based on imx8x board. This is another family that are not affected from this patch serie. This patch serie is not the cause of these warnings and will not resolve them. Additional info. We also have everywhere this warning since u-boot version 2020 or 2021. This doesn't affect the u-boot/SPL outputs. The complete boot container incl. 'ahab-container.img' is built separately with the mkimage tool of NXP. On first appearing of this warning we asked NXP. They didn't improve any solution. Maybe there is now a setting to remove this warning. A patch serie is planned for our imx8x boards. > > When building. > > -- > Tom
Re: [PATCH v4 0/6] board: siemens: clean up subfolders
On Wed, Jan 03, 2024 at 02:31:48PM +0100, Enrico Leto wrote: > This serie depends on the serie: > [PATCH 0/6] siemens,am335x: clean up the draco board family Is this not applied already? If not, where is it? Can you please repost it? > > The common folder was initialially created for the common parts of > the products based on draco-am355x board family. We have the > product lines 'pxm2', 'rut' and the base line unfortunately named > 'draco'! Adding the new capricorn-imx8 board family, the files > were enhanced without cleanup. > > Simplify first EEPROM probe and access that implements both i2c > with & without driver model. Use abstraction functions for this. > > Move all am355x specifics to a new file 'board_am335x'. > > Clean-up includes, config checks, maintainer. > > Signed-off-by: Enrico Leto The problem is that I see: > --- >rm: + draco-etamin +(draco-etamin) board/siemens/draco/../common/board.c: In function 'board_init': +(draco-etamin) board/siemens/draco/../common/board.c:88:9: error: implicit declaration of function 'board_nand_cs_init' [-Werror=implicit-function-declaration] +(draco-etamin)88 | board_nand_cs_init(); +(draco-etamin) | ^~ +(draco-etamin) cc1: all warnings being treated as errors +(draco-etamin) make[2]: *** [scripts/Makefile.build:257: board/siemens/draco/../common/board.o] Error 1 +(draco-etamin) make[1]: *** [Makefile:1859: board/siemens/draco] Error 2 +(draco-etamin) make: *** [Makefile:177: sub-make] Error 2 aarch64: + deneb +(deneb) WARNING 'ahab-container.img' not found, resulting binary is not-functional +(deneb) aarch64-linux-ld.bfd: board/siemens/capricorn/../common/factoryset.o: in function `factoryset_read_eeprom': +(deneb) board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read_eeprom+0x2c): undefined reference to `siemens_ee_read_data' +(deneb) aarch64-linux-ld.bfd: board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read_eeprom+0xb4): undefined reference to `siemens_ee_read_data' +(deneb) aarch64-linux-ld.bfd: board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read_eeprom+0x264): undefined reference to `siemens_ee_read_data' +(deneb) make[1]: *** [Makefile:1766: u-boot] Error 139 +(deneb) make[1]: *** Deleting file 'u-boot' +(deneb) make: *** [Makefile:177: sub-make] Error 2 aarch64: + giedi +(giedi) WARNING 'ahab-container.img' not found, resulting binary is not-functional +(giedi) aarch64-linux-ld.bfd: board/siemens/capricorn/../common/factoryset.o: in function `factoryset_read_eeprom': +(giedi) board/siemens/capricorn/../common/factoryset.c:149:(.text.factoryset_read_eeprom+0x2c): undefined reference to `siemens_ee_read_data' +(giedi) aarch64-linux-ld.bfd: board/siemens/capricorn/../common/factoryset.c:177:(.text.factoryset_read_eeprom+0xb4): undefined reference to `siemens_ee_read_data' +(giedi) aarch64-linux-ld.bfd: board/siemens/capricorn/../common/factoryset.c:172:(.text.factoryset_read_eeprom+0x264): undefined reference to `siemens_ee_read_data' +(giedi) make[1]: *** [Makefile:1766: u-boot] Error 139 +(giedi) make[1]: *** Deleting file 'u-boot' +(giedi) make: *** [Makefile:177: sub-make] Error 2 When building. -- Tom signature.asc Description: PGP signature
