RE: Please pull NXP i.MX nxp-imx-20200422
> Subject: Re: Please pull NXP i.MX nxp-imx-20200422 > > Hi Peng, > > On Wed, Apr 22, 2020 at 10:54 AM Peng Fan wrote: > > > > Hi Stefano, > > > > Please pull this version nxp-imx-20200422, with patches sent out to ML. > > Based on yours master branch. > > Series looks good: > Reviewed-by: Fabio Estevam > Thanks for the review. > Just some comments: > > - Please try sending the patches more often and in small batches as it is > easier > to review rather then a 24 patches series. ok. I was a bit busy in the past days, not that active. will keep small patchset in future. > - The speed grading logic is becoming too complicated and difficult to scale. > Please improve it in a separate patch if you have a chance. ok. I'll switch to use is_imx6ulx to replace is_imx6ull. There will be a conflict with Marek's fec clock part, I'll resend the patchset based on Marek's patch. Thanks again. Peng. > > Thanks
Re: Please pull NXP i.MX nxp-imx-20200422
Hi Peng, On Wed, Apr 22, 2020 at 10:54 AM Peng Fan wrote: > > Hi Stefano, > > Please pull this version nxp-imx-20200422, with patches sent out to ML. > Based on yours master branch. Series looks good: Reviewed-by: Fabio Estevam Just some comments: - Please try sending the patches more often and in small batches as it is easier to review rather then a 24 patches series. - The speed grading logic is becoming too complicated and difficult to scale. Please improve it in a separate patch if you have a chance. Thanks
RE: Please pull NXP i.MX nxp-imx-20200422
> Subject: Re: Please pull NXP i.MX nxp-imx-20200422 > > Hi Peng, > > On Wed, Apr 22, 2020 at 10:54 AM Peng Fan wrote: > > > > Hi Stefano, > > > > Please pull this version nxp-imx-20200422, with patches sent out to ML. > > Based on yours master branch. > > These 24 patches have just been posted to the list. > > Please allow time for people to review it and only send the pull request after > review has been done Code in downstream tree has been reviewed. Ok, let's wait and see comments from community. Thanks, Peng.
Re: Please pull NXP i.MX nxp-imx-20200422
Hi Peng, On Wed, Apr 22, 2020 at 10:54 AM Peng Fan wrote: > > Hi Stefano, > > Please pull this version nxp-imx-20200422, with patches sent out to ML. > Based on yours master branch. These 24 patches have just been posted to the list. Please allow time for people to review it and only send the pull request after review has been done.
