Re: [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node

2023-02-24 Thread Eugen Hristev 

On 2/23/23 13:28, Mihai Sain wrote:

The PMC_MCK1 clock id for the ebi node is 23.

Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
Signed-off-by: Mihai Sain 
---
  arch/arm/dts/sama7g5.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
index d38090d7dd..a802153af8 100644
--- a/arch/arm/dts/sama7g5.dtsi
+++ b/arch/arm/dts/sama7g5.dtsi
@@ -150,7 +150,7 @@
  0x1 0x0 0x4800 0x800
  0x2 0x0 0x5000 0x800
  0x3 0x0 0x5800 0x800>;
-   clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
+   clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
status = "disabled";
  
  			nand_controller: nand-controller {


Hi Mihai,

It appears PMC_MCK1 = PMC_MAIN(3) + 10 , in Linux.
In U-boot indeed it's 23.

Thanks for fixing it,

Reviewed-by: Eugen Hristev 

PS. I will amend the commit as it appears 4ce85577ac does not exist

Re: [PATCH] ARM: dts: at91: sama7g5: fix clock id for ebi node

2023-02-24 Thread Claudiu.Beznea 
On 23.02.2023 13:28, Mihai Sain wrote:
> The PMC_MCK1 clock id for the ebi node is 23.
> 
> Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
> Signed-off-by: Mihai Sain 

Reviewed-by: Claudiu Beznea 


> ---
>  arch/arm/dts/sama7g5.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
> index d38090d7dd..a802153af8 100644
> --- a/arch/arm/dts/sama7g5.dtsi
> +++ b/arch/arm/dts/sama7g5.dtsi
> @@ -150,7 +150,7 @@
> 0x1 0x0 0x4800 0x800
> 0x2 0x0 0x5000 0x800
> 0x3 0x0 0x5800 0x800>;
> - clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
> + clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
>   status = "disabled";
>  
>   nand_controller: nand-controller {