Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
Hello Fabio, Em qui., 18 de nov. de 2021 às 08:36, Fabio Estevam escreveu: > On Thu, Nov 18, 2021 at 8:33 AM Otavio Salvador > wrote: > > > > Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam > > escreveu: > > > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > > > have the ESAI_TX0 functionality, not ESAI_T0. > > > > > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > > > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. > > > > > > Add an entry for the correct name and still keep the old one to > > > avoid potential breakage. > > > > > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > > > Reported-by: George Makarov > > > Signed-off-by: Fabio Estevam > > > > Have you verified if there is any use of the old name in the three? if > > so, a patch converting it would be good. > > There is no in-tree user of MX6ULL_PAD_CSI_DATA07__ESAI_T0 in U-Boot > and in the kernel. Awesome. Reviewed-by: Otavio Salvador -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
Hi Otavio, On Thu, Nov 18, 2021 at 8:33 AM Otavio Salvador wrote: > > Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam > escreveu: > > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > > have the ESAI_TX0 functionality, not ESAI_T0. > > > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. > > > > Add an entry for the correct name and still keep the old one to > > avoid potential breakage. > > > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > > Reported-by: George Makarov > > Signed-off-by: Fabio Estevam > > Have you verified if there is any use of the old name in the three? if > so, a patch converting it would be good. There is no in-tree user of MX6ULL_PAD_CSI_DATA07__ESAI_T0 in U-Boot and in the kernel.
Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam escreveu: > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may > have the ESAI_TX0 functionality, not ESAI_T0. > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming. > > Add an entry for the correct name and still keep the old one to > avoid potential breakage. > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines") > Reported-by: George Makarov > Signed-off-by: Fabio Estevam Have you verified if there is any use of the old name in the three? if so, a patch converting it would be good. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750