Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board
On 6/11/24 23:42, Tony Dinh wrote:
Hi Dragan,
On Sun, Jun 9, 2024 at 6:07 PM Dragan Simic wrote:
Hello Tony,
Please see a few comments below.
On 2024-06-10 02:34, Tony Dinh wrote:
- Change the spi-max-frequency to 5000 (50 Mhz). According to the
data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in
the DTS to ensure u-boot is consistent with what Linux kernel expected.
- Update GPIO fan to conform to the latest DT binding.
There's no need for the bullet points, plain prose will do fine instead.
I like bullet points :) All my patch descriptions have bullet points
when there are 2 or more different items.
[1]
MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf
Unless you can provide a real, working URL for the datasheet, this
reference
should actually be deleted.
It was my oversight. That should have been this URL:
https://www.macronix.com/Lists/Datasheet/Attachments/8575/MX25L3205D,%203V,%2032Mb,%20v1.5.pdf
I'll wait for Stefan to review the patch and let him decide whether I
should send in a V2 patch or he will modify the commit description.
I've changed the commit message accordingly.
Applied to u-boot-marvell/master
Thanks,
Stefan
Thanks for the comments!
All the best,
Tony
Signed-off-by: Tony Dinh
---
arch/arm/dts/armada-385-thecus-n2350.dts | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts
b/arch/arm/dts/armada-385-thecus-n2350.dts
index 253cf01130..fdaa444e51 100644
--- a/arch/arm/dts/armada-385-thecus-n2350.dts
+++ b/arch/arm/dts/armada-385-thecus-n2350.dts
@@ -2,7 +2,7 @@
/*
* Device Tree file for Thecus N2350 board
*
- * Copyright (C) 2018-2023 Tony Dinh
+ * Copyright (C) 2018-2024 Tony Dinh
* Copyright (C) 2018 Manuel Jung
*/
@@ -143,9 +143,9 @@
fan {
compatible = "gpio-fan";
gpios = < 16 GPIO_ACTIVE_HIGH>;
- gpio-fan,speed-map = <0 0
- 600 1
- 3000 2 >;
+ gpio-fan,speed-map = <0 0>,
+ <600 1>,
+ <3000 2 >;
pinctrl-0 = <_fan>;
pinctrl-names = "default";
};
@@ -415,7 +415,7 @@
compatible = "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <10800>;
+ spi-max-frequency = <5000>;
spi-cpha;
partition@0 {
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de
Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board
Hi Dragan,
On Sun, Jun 9, 2024 at 6:07 PM Dragan Simic wrote:
>
> Hello Tony,
>
> Please see a few comments below.
>
> On 2024-06-10 02:34, Tony Dinh wrote:
> > - Change the spi-max-frequency to 5000 (50 Mhz). According to the
> > data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in
> > the DTS to ensure u-boot is consistent with what Linux kernel expected.
> > - Update GPIO fan to conform to the latest DT binding.
>
> There's no need for the bullet points, plain prose will do fine instead.
I like bullet points :) All my patch descriptions have bullet points
when there are 2 or more different items.
>
> > [1]
> > MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf
>
> Unless you can provide a real, working URL for the datasheet, this
> reference
> should actually be deleted.
It was my oversight. That should have been this URL:
https://www.macronix.com/Lists/Datasheet/Attachments/8575/MX25L3205D,%203V,%2032Mb,%20v1.5.pdf
I'll wait for Stefan to review the patch and let him decide whether I
should send in a V2 patch or he will modify the commit description.
Thanks for the comments!
All the best,
Tony
>
> > Signed-off-by: Tony Dinh
> > ---
> >
> > arch/arm/dts/armada-385-thecus-n2350.dts | 10 +-
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts
> > b/arch/arm/dts/armada-385-thecus-n2350.dts
> > index 253cf01130..fdaa444e51 100644
> > --- a/arch/arm/dts/armada-385-thecus-n2350.dts
> > +++ b/arch/arm/dts/armada-385-thecus-n2350.dts
> > @@ -2,7 +2,7 @@
> > /*
> > * Device Tree file for Thecus N2350 board
> > *
> > - * Copyright (C) 2018-2023 Tony Dinh
> > + * Copyright (C) 2018-2024 Tony Dinh
> > * Copyright (C) 2018 Manuel Jung
> > */
> >
> > @@ -143,9 +143,9 @@
> > fan {
> > compatible = "gpio-fan";
> > gpios = < 16 GPIO_ACTIVE_HIGH>;
> > - gpio-fan,speed-map = <0 0
> > - 600 1
> > - 3000 2 >;
> > + gpio-fan,speed-map = <0 0>,
> > + <600 1>,
> > + <3000 2 >;
> > pinctrl-0 = <_fan>;
> > pinctrl-names = "default";
> > };
> > @@ -415,7 +415,7 @@
> > compatible = "jedec,spi-nor";
> > reg = <0>;
> >
> > - spi-max-frequency = <10800>;
> > + spi-max-frequency = <5000>;
> > spi-cpha;
> >
> > partition@0 {
Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board
Hello Tony,
Please see a few comments below.
On 2024-06-10 02:34, Tony Dinh wrote:
- Change the spi-max-frequency to 5000 (50 Mhz). According to the
data sheet[1], the MX25L3205D max frequency is 86 Mhz. Using 50 Mhz in
the DTS to ensure u-boot is consistent with what Linux kernel expected.
- Update GPIO fan to conform to the latest DT binding.
There's no need for the bullet points, plain prose will do fine instead.
[1]
MX25L3205D-MX25L1605D-MX25L6405D-Macronix-MX25L3205DM2I-12G-datasheet.pdf
Unless you can provide a real, working URL for the datasheet, this
reference
should actually be deleted.
Signed-off-by: Tony Dinh
---
arch/arm/dts/armada-385-thecus-n2350.dts | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts
b/arch/arm/dts/armada-385-thecus-n2350.dts
index 253cf01130..fdaa444e51 100644
--- a/arch/arm/dts/armada-385-thecus-n2350.dts
+++ b/arch/arm/dts/armada-385-thecus-n2350.dts
@@ -2,7 +2,7 @@
/*
* Device Tree file for Thecus N2350 board
*
- * Copyright (C) 2018-2023 Tony Dinh
+ * Copyright (C) 2018-2024 Tony Dinh
* Copyright (C) 2018 Manuel Jung
*/
@@ -143,9 +143,9 @@
fan {
compatible = "gpio-fan";
gpios = < 16 GPIO_ACTIVE_HIGH>;
- gpio-fan,speed-map = < 0 0
- 600 1
- 3000 2 >;
+ gpio-fan,speed-map = < 0 0>,
+ <600 1>,
+ <3000 2 >;
pinctrl-0 = <_fan>;
pinctrl-names = "default";
};
@@ -415,7 +415,7 @@
compatible = "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <10800>;
+ spi-max-frequency = <5000>;
spi-cpha;
partition@0 {
