Re: [PATCH] board: rockchip: Add Pine64 PineTab2
Hi Kever,
On 2024-03-14 07:50, Kever Yang wrote:
>
> On 2024/2/5 01:30, Jonas Karlman wrote:
>> The Pine64 PineTab2 is a tablet computer based on the Rockchip RK3566
>> SoC. The table features 4/8 GB LPDDR4 RAM and 64/128 GB eMMC storage.
>>
>> Features tested on a Pine64 PineTab2 8GB v2.0:
>> - SD-card boot
>> - eMMC boot
>> - SPI Flash boot
>> - USB host
>>
>> Device tree is imported from linux maintainer branch v6.9-armsoc/dts64,
>> commit 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64
>> PineTab2").
>>
>> Signed-off-by: Jonas Karlman
> Reviewed-by: Kever Yang
Thanks, I will send a v2 with small adjustments to bootph flags used in
board u-boot.dtsi and update defconfig to take advantage of the new
ROCKCHIP_COMMON_STACK_ADDR bss and stack addresses.
Regards,
Jonas
>
> Thanks,
> - Kever
>> ---
>> This patch depend on the series "rockchip: rk35xx: Sync device tree with
>> linux v6.8-rc1" [1].
>>
>> [1] https://patchwork.ozlabs.org/cover/1891669/
>> ---
>> arch/arm/dts/Makefile | 2 +
>> arch/arm/dts/rk3566-pinetab2-u-boot.dtsi | 44 +
>> arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi | 3 +
>> arch/arm/dts/rk3566-pinetab2-v0.1.dts | 28 +
>> arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi | 3 +
>> arch/arm/dts/rk3566-pinetab2-v2.0.dts | 48 +
>> arch/arm/dts/rk3566-pinetab2.dtsi | 943 ++
>> board/pine64/quartz64_rk3566/MAINTAINERS | 11 +
>> configs/pinetab2-rk3566_defconfig | 119 +++
>> doc/board/rockchip/rockchip.rst | 1 +
>> 10 files changed, 1202 insertions(+)
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1.dts
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0.dts
>> create mode 100644 arch/arm/dts/rk3566-pinetab2.dtsi
>> create mode 100644 configs/pinetab2-rk3566_defconfig
>>
[snip]
Re: [PATCH] board: rockchip: Add Pine64 PineTab2
On 2024/2/5 01:30, Jonas Karlman wrote:
The Pine64 PineTab2 is a tablet computer based on the Rockchip RK3566
SoC. The table features 4/8 GB LPDDR4 RAM and 64/128 GB eMMC storage.
Features tested on a Pine64 PineTab2 8GB v2.0:
- SD-card boot
- eMMC boot
- SPI Flash boot
- USB host
Device tree is imported from linux maintainer branch v6.9-armsoc/dts64,
commit 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64
PineTab2").
Signed-off-by: Jonas Karlman
Reviewed-by: Kever Yang
Thanks,
- Kever
---
This patch depend on the series "rockchip: rk35xx: Sync device tree with
linux v6.8-rc1" [1].
[1] https://patchwork.ozlabs.org/cover/1891669/
---
arch/arm/dts/Makefile | 2 +
arch/arm/dts/rk3566-pinetab2-u-boot.dtsi | 44 +
arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi | 3 +
arch/arm/dts/rk3566-pinetab2-v0.1.dts | 28 +
arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi | 3 +
arch/arm/dts/rk3566-pinetab2-v2.0.dts | 48 +
arch/arm/dts/rk3566-pinetab2.dtsi | 943 ++
board/pine64/quartz64_rk3566/MAINTAINERS | 11 +
configs/pinetab2-rk3566_defconfig | 119 +++
doc/board/rockchip/rockchip.rst | 1 +
10 files changed, 1202 insertions(+)
create mode 100644 arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1.dts
create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0.dts
create mode 100644 arch/arm/dts/rk3566-pinetab2.dtsi
create mode 100644 configs/pinetab2-rk3566_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 50f35e3db3f0..825fa1cd368a 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -173,6 +173,8 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
dtb-$(CONFIG_ROCKCHIP_RK3568) += \
rk3566-anbernic-rgxx3.dtb \
+ rk3566-pinetab2-v0.1.dtb \
+ rk3566-pinetab2-v2.0.dtb \
rk3566-quartz64-a.dtb \
rk3566-quartz64-b.dtb \
rk3566-radxa-cm3-io.dtb \
diff --git a/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
b/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
new file mode 100644
index ..4aa6ab1c848c
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
@@ -0,0 +1,44 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include "rk356x-u-boot.dtsi"
+
+_dual_io_pins {
+ bootph-all;
+};
+
+ {
+ bootph-all;
+};
+
+ {
+ bootph-pre-ram;
+};
+
+ {
+ bootph-pre-ram;
+
+ regulators {
+ bootph-pre-ram;
+ };
+};
+
+ {
+ cap-mmc-highspeed;
+};
+
+_pwren_l {
+ bootph-all;
+};
+
+ {
+ bootph-pre-ram;
+ u-boot,spl-sfc-no-dma;
+
+ flash@0 {
+ bootph-pre-ram;
+ };
+};
+
+_sd {
+ bootph-pre-ram;
+};
diff --git a/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
b/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
new file mode 100644
index ..061dc3c2c375
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
@@ -0,0 +1,3 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include "rk3566-pinetab2-u-boot.dtsi"
diff --git a/arch/arm/dts/rk3566-pinetab2-v0.1.dts
b/arch/arm/dts/rk3566-pinetab2-v0.1.dts
new file mode 100644
index ..5fe6ca5da9d3
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v0.1.dts
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3566-pinetab2.dtsi"
+
+/ {
+ model = "Pine64 PineTab2 v0.1";
+ compatible = "pine64,pinetab2-v0.1", "pine64,pinetab2",
"rockchip,rk3566";
+};
+
+ {
+ reset-gpios = < RK_PA6 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <_pwren_h _rst_l>;
+};
+
+ {
+ lcd0 {
+ lcd0_rst_l: lcd0-rst-l {
+ rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO _pull_none>;
+ };
+ };
+};
+
+ {
+ vmmc-supply = <_sys>;
+};
diff --git a/arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
b/arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
new file mode 100644
index ..061dc3c2c375
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
@@ -0,0 +1,3 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include "rk3566-pinetab2-u-boot.dtsi"
diff --git a/arch/arm/dts/rk3566-pinetab2-v2.0.dts
b/arch/arm/dts/rk3566-pinetab2-v2.0.dts
new file mode 100644
index ..9349541cbbd0
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v2.0.dts
@@ -0,0 +1,48 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3566-pinetab2.dtsi"
+
+/ {
+ model = "Pine64 PineTab2 v2.0";
+ compatible = "pine64,pinetab2-v2.0", "pine64,pinetab2",
"rockchip,rk3566";
+};
+
+_keys {
+ pinctrl-0 = <_id_det>, <_int_l>;
+
+ event-hall-sensor {
+ debounce-interval = <20>;
+ gpios = < RK_PA6 GPIO_ACTIVE_LOW>;
+
Re: [PATCH] board: rockchip: Add Pine64 PineTab2
Hi Kever,
On 2024-02-05 08:04, Kever Yang wrote:
> Hi Jonas,
>
> On 2024/2/5 01:30, Jonas Karlman wrote:
>> The Pine64 PineTab2 is a tablet computer based on the Rockchip RK3566
>> SoC. The table features 4/8 GB LPDDR4 RAM and 64/128 GB eMMC storage.
>>
>> Features tested on a Pine64 PineTab2 8GB v2.0:
>> - SD-card boot
>> - eMMC boot
>> - SPI Flash boot
>> - USB host
>>
>> Device tree is imported from linux maintainer branch v6.9-armsoc/dts64,
>> commit 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64
>> PineTab2").
>>
>> Signed-off-by: Jonas Karlman
>> ---
>> This patch depend on the series "rockchip: rk35xx: Sync device tree with
>> linux v6.8-rc1" [1].
>>
>> [1] https://patchwork.ozlabs.org/cover/1891669/
>> ---
>> arch/arm/dts/Makefile | 2 +
>> arch/arm/dts/rk3566-pinetab2-u-boot.dtsi | 44 +
>> arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi | 3 +
>> arch/arm/dts/rk3566-pinetab2-v0.1.dts | 28 +
>
> Does this v0.1 version dts really needed? This seems like a test version
> instead of release version hardware?
The initial v0.1 was sent out to community developers and v2.0 is the
production version sold, so both versions exists in the wild.
In current state they could probably share a single DT for U-Boot usage
but in future if panel support is added to U-Boot the two versions does
differ a little bit.
Was safer to just include both device trees.
Regards,
Jonas
>
>
> Thanks,
>
> - Kever
>
>> arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi | 3 +
>> arch/arm/dts/rk3566-pinetab2-v2.0.dts | 48 +
>> arch/arm/dts/rk3566-pinetab2.dtsi | 943 ++
>> board/pine64/quartz64_rk3566/MAINTAINERS | 11 +
>> configs/pinetab2-rk3566_defconfig | 119 +++
>> doc/board/rockchip/rockchip.rst | 1 +
>> 10 files changed, 1202 insertions(+)
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1.dts
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
>> create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0.dts
>> create mode 100644 arch/arm/dts/rk3566-pinetab2.dtsi
>> create mode 100644 configs/pinetab2-rk3566_defconfig
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index 50f35e3db3f0..825fa1cd368a 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -173,6 +173,8 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
>>
>> dtb-$(CONFIG_ROCKCHIP_RK3568) += \
>> rk3566-anbernic-rgxx3.dtb \
>> +rk3566-pinetab2-v0.1.dtb \
>> +rk3566-pinetab2-v2.0.dtb \
>> rk3566-quartz64-a.dtb \
>> rk3566-quartz64-b.dtb \
>> rk3566-radxa-cm3-io.dtb \
>> diff --git a/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
>> b/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
>> new file mode 100644
>> index ..4aa6ab1c848c
>> --- /dev/null
>> +++ b/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
>> @@ -0,0 +1,44 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +
>> +#include "rk356x-u-boot.dtsi"
>> +
>> +_dual_io_pins {
>> +bootph-all;
>> +};
>> +
>> + {
>> +bootph-all;
>> +};
>> +
>> + {
>> +bootph-pre-ram;
>> +};
>> +
>> + {
>> +bootph-pre-ram;
>> +
>> +regulators {
>> +bootph-pre-ram;
>> +};
>> +};
>> +
>> + {
>> +cap-mmc-highspeed;
>> +};
>> +
>> +_pwren_l {
>> +bootph-all;
>> +};
>> +
>> + {
>> +bootph-pre-ram;
>> +u-boot,spl-sfc-no-dma;
>> +
>> +flash@0 {
>> +bootph-pre-ram;
>> +};
>> +};
>> +
>> +_sd {
>> +bootph-pre-ram;
>> +};
>> diff --git a/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
>> b/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
>> new file mode 100644
>> index ..061dc3c2c375
>> --- /dev/null
>> +++ b/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
>> @@ -0,0 +1,3 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +
>> +#include "rk3566-pinetab2-u-boot.dtsi"
>> diff --git a/arch/arm/dts/rk3566-pinetab2-v0.1.dts
>> b/arch/arm/dts/rk3566-pinetab2-v0.1.dts
>> new file mode 100644
>> index ..5fe6ca5da9d3
>> --- /dev/null
>> +++ b/arch/arm/dts/rk3566-pinetab2-v0.1.dts
>> @@ -0,0 +1,28 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +/dts-v1/;
>> +
>> +#include "rk3566-pinetab2.dtsi"
>> +
>> +/ {
>> +model = "Pine64 PineTab2 v0.1";
>> +compatible = "pine64,pinetab2-v0.1", "pine64,pinetab2",
>> "rockchip,rk3566";
>> +};
>> +
>> + {
>> +reset-gpios = < RK_PA6 GPIO_ACTIVE_LOW>;
>> +pinctrl-names = "default";
>> +pinctrl-0 = <_pwren_h _rst_l>;
>> +};
>> +
>> + {
>> +lcd0 {
>> +lcd0_rst_l: lcd0-rst-l {
>> +rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO _pull_none>;
>> +};
>> +};
>> +};
>> +
>> + {
>> +vmmc-supply = <_sys>;
>> +};
>> diff --git a/arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
>>
Re: [PATCH] board: rockchip: Add Pine64 PineTab2
Hi Jonas,
On 2024/2/5 01:30, Jonas Karlman wrote:
The Pine64 PineTab2 is a tablet computer based on the Rockchip RK3566
SoC. The table features 4/8 GB LPDDR4 RAM and 64/128 GB eMMC storage.
Features tested on a Pine64 PineTab2 8GB v2.0:
- SD-card boot
- eMMC boot
- SPI Flash boot
- USB host
Device tree is imported from linux maintainer branch v6.9-armsoc/dts64,
commit 1b7e19448f8f ("arm64: dts: rockchip: Add devicetree for Pine64
PineTab2").
Signed-off-by: Jonas Karlman
---
This patch depend on the series "rockchip: rk35xx: Sync device tree with
linux v6.8-rc1" [1].
[1] https://patchwork.ozlabs.org/cover/1891669/
---
arch/arm/dts/Makefile | 2 +
arch/arm/dts/rk3566-pinetab2-u-boot.dtsi | 44 +
arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi | 3 +
arch/arm/dts/rk3566-pinetab2-v0.1.dts | 28 +
Does this v0.1 version dts really needed? This seems like a test version
instead of release version hardware?
Thanks,
- Kever
arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi | 3 +
arch/arm/dts/rk3566-pinetab2-v2.0.dts | 48 +
arch/arm/dts/rk3566-pinetab2.dtsi | 943 ++
board/pine64/quartz64_rk3566/MAINTAINERS | 11 +
configs/pinetab2-rk3566_defconfig | 119 +++
doc/board/rockchip/rockchip.rst | 1 +
10 files changed, 1202 insertions(+)
create mode 100644 arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3566-pinetab2-v0.1.dts
create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3566-pinetab2-v2.0.dts
create mode 100644 arch/arm/dts/rk3566-pinetab2.dtsi
create mode 100644 configs/pinetab2-rk3566_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 50f35e3db3f0..825fa1cd368a 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -173,6 +173,8 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
dtb-$(CONFIG_ROCKCHIP_RK3568) += \
rk3566-anbernic-rgxx3.dtb \
+ rk3566-pinetab2-v0.1.dtb \
+ rk3566-pinetab2-v2.0.dtb \
rk3566-quartz64-a.dtb \
rk3566-quartz64-b.dtb \
rk3566-radxa-cm3-io.dtb \
diff --git a/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
b/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
new file mode 100644
index ..4aa6ab1c848c
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-u-boot.dtsi
@@ -0,0 +1,44 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include "rk356x-u-boot.dtsi"
+
+_dual_io_pins {
+ bootph-all;
+};
+
+ {
+ bootph-all;
+};
+
+ {
+ bootph-pre-ram;
+};
+
+ {
+ bootph-pre-ram;
+
+ regulators {
+ bootph-pre-ram;
+ };
+};
+
+ {
+ cap-mmc-highspeed;
+};
+
+_pwren_l {
+ bootph-all;
+};
+
+ {
+ bootph-pre-ram;
+ u-boot,spl-sfc-no-dma;
+
+ flash@0 {
+ bootph-pre-ram;
+ };
+};
+
+_sd {
+ bootph-pre-ram;
+};
diff --git a/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
b/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
new file mode 100644
index ..061dc3c2c375
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v0.1-u-boot.dtsi
@@ -0,0 +1,3 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include "rk3566-pinetab2-u-boot.dtsi"
diff --git a/arch/arm/dts/rk3566-pinetab2-v0.1.dts
b/arch/arm/dts/rk3566-pinetab2-v0.1.dts
new file mode 100644
index ..5fe6ca5da9d3
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v0.1.dts
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3566-pinetab2.dtsi"
+
+/ {
+ model = "Pine64 PineTab2 v0.1";
+ compatible = "pine64,pinetab2-v0.1", "pine64,pinetab2",
"rockchip,rk3566";
+};
+
+ {
+ reset-gpios = < RK_PA6 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <_pwren_h _rst_l>;
+};
+
+ {
+ lcd0 {
+ lcd0_rst_l: lcd0-rst-l {
+ rockchip,pins = <0 RK_PA6 RK_FUNC_GPIO _pull_none>;
+ };
+ };
+};
+
+ {
+ vmmc-supply = <_sys>;
+};
diff --git a/arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
b/arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
new file mode 100644
index ..061dc3c2c375
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v2.0-u-boot.dtsi
@@ -0,0 +1,3 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include "rk3566-pinetab2-u-boot.dtsi"
diff --git a/arch/arm/dts/rk3566-pinetab2-v2.0.dts
b/arch/arm/dts/rk3566-pinetab2-v2.0.dts
new file mode 100644
index ..9349541cbbd0
--- /dev/null
+++ b/arch/arm/dts/rk3566-pinetab2-v2.0.dts
@@ -0,0 +1,48 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3566-pinetab2.dtsi"
+
+/ {
+ model = "Pine64 PineTab2 v2.0";
+ compatible = "pine64,pinetab2-v2.0", "pine64,pinetab2",
"rockchip,rk3566";
+};
+
+_keys {
+ pinctrl-0 = <_id_det>, <_int_l>;
+
+ event-hall-sensor {
+
