Re: [PATCH] bootstd: Drop some TODOs
On Thu, Aug 24, 2023 at 07:39:24PM -0600, Simon Glass wrote: > The existing TODOs are done, so remove them. Add another that came up > today. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH] bootstd: Drop some TODOs
Hi Simon, On Fri, Aug 25, 2023 at 5:51 PM Tony Dinh wrote: > > Hi Simon, > > On Fri, Aug 25, 2023 at 4:53 PM Simon Glass wrote: > > > > Hi Tony, > > > > On Fri, 25 Aug 2023 at 14:17, Tony Dinh wrote: > > > > > > Hi Simon, > > > > > > On Thu, Aug 24, 2023 at 6:48 PM Simon Glass wrote: > > > > > > > > The existing TODOs are done, so remove them. Add another that came up > > > > today. > > > > > > > > Signed-off-by: Simon Glass > > > > --- > > > > > > > > doc/develop/bootstd.rst | 4 +--- > > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > > > diff --git a/doc/develop/bootstd.rst b/doc/develop/bootstd.rst > > > > index ec3136535783..3e566e994d6c 100644 > > > > --- a/doc/develop/bootstd.rst > > > > +++ b/doc/develop/bootstd.rst > > > > @@ -752,9 +752,7 @@ To do > > > > > > > > Some things that need to be done to completely replace the distro-boot > > > > scripts: > > > > > > > > -- add bootdev drivers for dhcp, sata, scsi, ide, virtio > > > > > > Good to see SATA finally in bootdev driver! I'm testing bootstd on a > > > couple boards, and have been waiting for SATA bootdev. Any idea, if I > > > should wait for it to be merged to the next branch, or is there an > > > easy way to do it with one of your patches (I can test it on the > > > latest master branch or next branch). > > > > I believe it went in in the last release - see drivers/scsi/scsi_bootdev.c > > > > If you need something else for SATA, PLMK. > > I see. That's scsi_bootdev for the scsi driver. I think we also need > sata_bootdev for drivers/ata/. For example, the Marvell Kirkwood SoC > boards use sata_mv. I took a close look in the drivers/ata/ directory. Most drivers are using ahci scsi, so they are OK. But the following drivers are ahci but not using scsi: fsl_sata.c sata_sil.c sata_mv.c That TODO item should remain and changed to: -- add bootdev driver for sata All the best, Tony > > Thanks, > Tony > > > > > Regards, > > Simon > > > > > > > > > > Thanks, > > > Tony > > > > > > > -- PXE boot for EFI > > > > -- support for loading U-Boot scripts > > > > +- implement extensions (devicetree overlays with add-on boards) > > > > > > > > Other ideas: > > > > > > > > -- > > > > 2.42.0.rc1.204.g551eb34607-goog > > > >
Re: [PATCH] bootstd: Drop some TODOs
Hi Simon, On Fri, Aug 25, 2023 at 4:53 PM Simon Glass wrote: > > Hi Tony, > > On Fri, 25 Aug 2023 at 14:17, Tony Dinh wrote: > > > > Hi Simon, > > > > On Thu, Aug 24, 2023 at 6:48 PM Simon Glass wrote: > > > > > > The existing TODOs are done, so remove them. Add another that came up > > > today. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > doc/develop/bootstd.rst | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/doc/develop/bootstd.rst b/doc/develop/bootstd.rst > > > index ec3136535783..3e566e994d6c 100644 > > > --- a/doc/develop/bootstd.rst > > > +++ b/doc/develop/bootstd.rst > > > @@ -752,9 +752,7 @@ To do > > > > > > Some things that need to be done to completely replace the distro-boot > > > scripts: > > > > > > -- add bootdev drivers for dhcp, sata, scsi, ide, virtio > > > > Good to see SATA finally in bootdev driver! I'm testing bootstd on a > > couple boards, and have been waiting for SATA bootdev. Any idea, if I > > should wait for it to be merged to the next branch, or is there an > > easy way to do it with one of your patches (I can test it on the > > latest master branch or next branch). > > I believe it went in in the last release - see drivers/scsi/scsi_bootdev.c > > If you need something else for SATA, PLMK. I see. That's scsi_bootdev for the scsi driver. I think we also need sata_bootdev for drivers/ata/. For example, the Marvell Kirkwood SoC boards use sata_mv. Thanks, Tony > > Regards, > Simon > > > > > > Thanks, > > Tony > > > > > -- PXE boot for EFI > > > -- support for loading U-Boot scripts > > > +- implement extensions (devicetree overlays with add-on boards) > > > > > > Other ideas: > > > > > > -- > > > 2.42.0.rc1.204.g551eb34607-goog > > >
Re: [PATCH] bootstd: Drop some TODOs
Hi Tony, On Fri, 25 Aug 2023 at 14:17, Tony Dinh wrote: > > Hi Simon, > > On Thu, Aug 24, 2023 at 6:48 PM Simon Glass wrote: > > > > The existing TODOs are done, so remove them. Add another that came up > > today. > > > > Signed-off-by: Simon Glass > > --- > > > > doc/develop/bootstd.rst | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/doc/develop/bootstd.rst b/doc/develop/bootstd.rst > > index ec3136535783..3e566e994d6c 100644 > > --- a/doc/develop/bootstd.rst > > +++ b/doc/develop/bootstd.rst > > @@ -752,9 +752,7 @@ To do > > > > Some things that need to be done to completely replace the distro-boot > > scripts: > > > > -- add bootdev drivers for dhcp, sata, scsi, ide, virtio > > Good to see SATA finally in bootdev driver! I'm testing bootstd on a > couple boards, and have been waiting for SATA bootdev. Any idea, if I > should wait for it to be merged to the next branch, or is there an > easy way to do it with one of your patches (I can test it on the > latest master branch or next branch). I believe it went in in the last release - see drivers/scsi/scsi_bootdev.c If you need something else for SATA, PLMK. Regards, Simon > > Thanks, > Tony > > > -- PXE boot for EFI > > -- support for loading U-Boot scripts > > +- implement extensions (devicetree overlays with add-on boards) > > > > Other ideas: > > > > -- > > 2.42.0.rc1.204.g551eb34607-goog > >
Re: [PATCH] bootstd: Drop some TODOs
Hi Simon, On Thu, Aug 24, 2023 at 6:48 PM Simon Glass wrote: > > The existing TODOs are done, so remove them. Add another that came up > today. > > Signed-off-by: Simon Glass > --- > > doc/develop/bootstd.rst | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/doc/develop/bootstd.rst b/doc/develop/bootstd.rst > index ec3136535783..3e566e994d6c 100644 > --- a/doc/develop/bootstd.rst > +++ b/doc/develop/bootstd.rst > @@ -752,9 +752,7 @@ To do > > Some things that need to be done to completely replace the distro-boot > scripts: > > -- add bootdev drivers for dhcp, sata, scsi, ide, virtio Good to see SATA finally in bootdev driver! I'm testing bootstd on a couple boards, and have been waiting for SATA bootdev. Any idea, if I should wait for it to be merged to the next branch, or is there an easy way to do it with one of your patches (I can test it on the latest master branch or next branch). Thanks, Tony > -- PXE boot for EFI > -- support for loading U-Boot scripts > +- implement extensions (devicetree overlays with add-on boards) > > Other ideas: > > -- > 2.42.0.rc1.204.g551eb34607-goog >
