Re: [PATCH] rmobile: avoid deprecated srec_cat flags

2023-04-19 Thread Marek Vasut

On 4/19/23 18:30, Ralph Siemsen wrote:

On Tue, Apr 18, 2023 at 3:36 PM Marek Vasut  wrote:

I'm afraid this needs some backward compatibility sreccat version check
. Similar to GCC compiler flags presence check. To avoid breaking legacy
users.


I'll revisit this after the rz/n1 work, which is more important.

Also I noticed that srec_cat is being called even when it is not
installed, which of course causes the build to fail. This is curious
since the makefile checks for srec_cat prior to using it.


I have this one on my ToDo too. Basically what I am pondering about is 
whether we can get rid of SREC_CAT and replace it somehow with binman. 
The keyword here is "somehow" right now ... for I have no idea how yet.


Re: [PATCH] rmobile: avoid deprecated srec_cat flags

2023-04-19 Thread Ralph Siemsen
On Tue, Apr 18, 2023 at 3:36 PM Marek Vasut  wrote:
> I'm afraid this needs some backward compatibility sreccat version check
> . Similar to GCC compiler flags presence check. To avoid breaking legacy
> users.

I'll revisit this after the rz/n1 work, which is more important.

Also I noticed that srec_cat is being called even when it is not
installed, which of course causes the build to fail. This is curious
since the makefile checks for srec_cat prior to using it.

Ralph


Re: [PATCH] rmobile: avoid deprecated srec_cat flags

2023-04-18 Thread Marek Vasut

On 4/18/23 20:20, Ralph Siemsen wrote:

The -l-e-constant flag has been deprecated since 2012. [1]
Use the recommended replacement instead.

[1] https://sourceforge.net/p/srecord/code/ci/1.59.D009/

Signed-off-by: Ralph Siemsen 


I'm afraid this needs some backward compatibility sreccat version check 
. Similar to GCC compiler flags presence check. To avoid breaking legacy 
users.