Re: [PATCH] rockchip: rk3399: Add Nanopi M4V2 board support
Hi Shuying Li & Libunko,
Would you be able to resend this patch to uboot mailing list ?
If you are no longer interested, I can resend it if you would like.
Thank you
Chris
On Sun, 18 Oct 2020 at 13:10, Shuying Li wrote:
>
> From: Libunko
>
> Add initial support for Nanopi M4V2 board.
>
> Specification
> - Rockchip RK3399
> - Dual-Channel 4GB LPDDR4
> - SD card slot
> - eMMC socket
> - RTL8211E 1Gbps
> - AP6356S WiFI/BT
> - HDMI In/Out, MIPI DSI/CSI
> - USB 3.0 x4
> - USB Type C power and data
> - GPIO1, GPIO2 expansion ports
> - DC5V/3A
>
> Signed-off-by: Shuying Li
> ---
> arch/arm/dts/Makefile | 1 +
> arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi | 7 +++
> arch/arm/dts/rk3399-nanopi-m4v2.dts | 67 +
> board/rockchip/evb_rk3399/MAINTAINERS | 6 ++
> configs/nanopi-m4v2-rk3399_defconfig| 61 +++
> doc/board/rockchip/rockchip.rst | 1 +
> 6 files changed, 143 insertions(+)
> create mode 100644 arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> create mode 100644 arch/arm/dts/rk3399-nanopi-m4v2.dts
> create mode 100644 configs/nanopi-m4v2-rk3399_defconfig
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index f8f529435b..7e8dfcef88 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -130,6 +130,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
> rk3399-nanopc-t4.dtb \
> rk3399-nanopi-m4.dtb \
> rk3399-nanopi-m4-2gb.dtb \
> + rk3399-nanopi-m4v2.dtb \
> rk3399-nanopi-neo4.dtb \
> rk3399-orangepi.dtb \
> rk3399-pinebook-pro.dtb \
> diff --git a/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> b/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> new file mode 100644
> index 00..ff8e99cb7f
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2020 Shuying Li
> + */
> +
> +#include "rk3399-nanopi4-u-boot.dtsi"
> +#include "rk3399-sdram-lpddr4-100.dtsi"
> diff --git a/arch/arm/dts/rk3399-nanopi-m4v2.dts
> b/arch/arm/dts/rk3399-nanopi-m4v2.dts
> new file mode 100644
> index 00..03d956d2c4
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-nanopi-m4v2.dts
> @@ -0,0 +1,67 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * FriendlyElec NanoPi M4V2 board device tree source
> + *
> + * Copyright (c) 2018 FriendlyElec Computer Tech. Co., Ltd.
> + * (http://www.friendlyarm.com)
> + *
> + * Copyright (c) 2018 Collabora Ltd.
> + * Copyright (c) 2019 Arm Ltd.
> + * Copyright (C) 2020 Shuying Li
> + */
> +
> +/dts-v1/;
> +#include "rk3399-nanopi4.dtsi"
> +
> +/ {
> + model = "FriendlyElec NanoPi M4V2";
> + compatible = "friendlyarm,nanopi-m4v2", "rockchip,rk3399";
> +
> + vdd_5v: vdd-5v {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd_5v";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vcc5v0_core: vcc5v0-core {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_core";
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <_5v>;
> + };
> +
> + vcc5v0_usb1: vcc5v0-usb1 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_usb1";
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <_sys>;
> + };
> +
> + vcc5v0_usb2: vcc5v0-usb2 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_usb2";
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <_sys>;
> + };
> +};
> +
> +_sys {
> + vin-supply = <_core>;
> +};
> +
> +_host {
> + phy-supply = <_usb1>;
> +};
> +
> +_host {
> + phy-supply = <_usb2>;
> +};
> +
> +_typec {
> + regulator-always-on;
> + vin-supply = <_5v>;
> +};
> diff --git a/board/rockchip/evb_rk3399/MAINTAINERS
> b/board/rockchip/evb_rk3399/MAINTAINERS
> index 4c889e06a6..9967d68a88 100644
> --- a/board/rockchip/evb_rk3399/MAINTAINERS
> +++ b/board/rockchip/evb_rk3399/MAINTAINERS
> @@ -49,6 +49,12 @@ S: Maintained
> F: configs/nanopi-m4-2gb-rk3399_defconfig
> F: arch/arm/dts/rk3399-nanopi-m4-2gb-u-boot.dtsi
>
> +NANOPC-M4V2
> +M: Shuying Li
> +S: Maintained
> +F: configs/nanopi-m4v2-rk3399_defconfig
> +F: arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> +
> NANOPI-NEO4
> M: Jagan Teki
> S: Maintained
> diff --git a/configs/nanopi-m4v2-rk3399_defconfig
> b/configs/nanopi-m4v2-rk3399_defconfig
> new file mode 100644
> index 00..d5c58d549f
> --- /dev/null
> +++ b/configs/nanopi-m4v2-rk3399_defconfig
> @@ -0,0 +1,61 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_SYS_TEXT_BASE=0x0020
> +CONFIG_NR_DRAM_BANKS=1
>
Re: [PATCH] rockchip: rk3399: Add Nanopi M4V2 board support
On Fri, 5 Feb 2021 at 16:15, Christopher Obbard wrote: > > Hi! > > I tested this patch, all working well apart from ethernet: > > Model: FriendlyElec NanoPi M4V2 > Net: > Error: ethernet@fe30 address not set. > No ethernet found. > Any tips to get ethernet going ? > > thinking about it, i should try a NanopiM4 V1... right, I had to set ethaddr first in the environment... The vendor u-boot seems to derive a default ethernet address from the serial number. thanks! > > thanks! > > On Sat, 16 Jan 2021 at 12:41, Jamislike wrote: > > > > Hi All, > > Shuying kindly pointed me to his branch: > > > > git clone -b v2020.10.m4v2 https://github.com/Libunko/u-boot.git > > > > What needs to be done to get this into mainline? > > Jam > > > > > > > > > > > > -- > > Sent from: http://u-boot.10912.n7.nabble.com/
Re: [PATCH] rockchip: rk3399: Add Nanopi M4V2 board support
Hi! I tested this patch, all working well apart from ethernet: Model: FriendlyElec NanoPi M4V2 Net: Error: ethernet@fe30 address not set. No ethernet found. Hit any key to stop autoboot: 0 => nfs mdio_register: non unique device name 'ethernet@fe30' mdio_register: non unique device name 'ethernet@fe30' mdio_register: non unique device name 'ethernet@fe30' mdio_register: non unique device name 'ethernet@fe30' No ethernet found. mdio_register: non unique device name 'ethernet@fe30' Any tips to get ethernet going ? thinking about it, i should try a NanopiM4 V1... thanks! On Sat, 16 Jan 2021 at 12:41, Jamislike wrote: > > Hi All, > Shuying kindly pointed me to his branch: > > git clone -b v2020.10.m4v2 https://github.com/Libunko/u-boot.git > > What needs to be done to get this into mainline? > Jam > > > > > > -- > Sent from: http://u-boot.10912.n7.nabble.com/
Re: [PATCH] rockchip: rk3399: Add Nanopi M4V2 board support
Hi All, Shuying kindly pointed me to his branch: git clone -b v2020.10.m4v2 https://github.com/Libunko/u-boot.git What needs to be done to get this into mainline? Jam -- Sent from: http://u-boot.10912.n7.nabble.com/
Re: [PATCH] rockchip: rk3399: Add Nanopi M4V2 board support
Hi Shuying,
I can't find a rk3399-nanopi-m4v2.dts at mainline kernel, does this
a copy of rk3399-nanopi-m4.dts?
What's the difference between m4 and m4v2, is it possible to use
the same dts in U-Boot?
Thanks,
- Kever
On 2020/10/18 下午1:25, Shuying Li wrote:
From: Libunko
Add initial support for Nanopi M4V2 board.
Specification
- Rockchip RK3399
- Dual-Channel 4GB LPDDR4
- SD card slot
- eMMC socket
- RTL8211E 1Gbps
- AP6356S WiFI/BT
- HDMI In/Out, MIPI DSI/CSI
- USB 3.0 x4
- USB Type C power and data
- GPIO1, GPIO2 expansion ports
- DC5V/3A
Signed-off-by: Shuying Li
---
arch/arm/dts/Makefile | 1 +
arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi | 7 +++
arch/arm/dts/rk3399-nanopi-m4v2.dts | 67 +
board/rockchip/evb_rk3399/MAINTAINERS | 6 ++
configs/nanopi-m4v2-rk3399_defconfig| 61 +++
doc/board/rockchip/rockchip.rst | 1 +
6 files changed, 143 insertions(+)
create mode 100644 arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
create mode 100644 arch/arm/dts/rk3399-nanopi-m4v2.dts
create mode 100644 configs/nanopi-m4v2-rk3399_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index f8f529435b..7e8dfcef88 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -130,6 +130,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
rk3399-nanopc-t4.dtb \
rk3399-nanopi-m4.dtb \
rk3399-nanopi-m4-2gb.dtb \
+ rk3399-nanopi-m4v2.dtb \
rk3399-nanopi-neo4.dtb \
rk3399-orangepi.dtb \
rk3399-pinebook-pro.dtb \
diff --git a/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
b/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
new file mode 100644
index 00..ff8e99cb7f
--- /dev/null
+++ b/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2020 Shuying Li
+ */
+
+#include "rk3399-nanopi4-u-boot.dtsi"
+#include "rk3399-sdram-lpddr4-100.dtsi"
diff --git a/arch/arm/dts/rk3399-nanopi-m4v2.dts
b/arch/arm/dts/rk3399-nanopi-m4v2.dts
new file mode 100644
index 00..03d956d2c4
--- /dev/null
+++ b/arch/arm/dts/rk3399-nanopi-m4v2.dts
@@ -0,0 +1,67 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * FriendlyElec NanoPi M4V2 board device tree source
+ *
+ * Copyright (c) 2018 FriendlyElec Computer Tech. Co., Ltd.
+ * (http://www.friendlyarm.com)
+ *
+ * Copyright (c) 2018 Collabora Ltd.
+ * Copyright (c) 2019 Arm Ltd.
+ * Copyright (C) 2020 Shuying Li
+ */
+
+/dts-v1/;
+#include "rk3399-nanopi4.dtsi"
+
+/ {
+ model = "FriendlyElec NanoPi M4V2";
+ compatible = "friendlyarm,nanopi-m4v2", "rockchip,rk3399";
+
+ vdd_5v: vdd-5v {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_5v";
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ vcc5v0_core: vcc5v0-core {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_core";
+ regulator-always-on;
+ regulator-boot-on;
+ vin-supply = <_5v>;
+ };
+
+ vcc5v0_usb1: vcc5v0-usb1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_usb1";
+ regulator-always-on;
+ regulator-boot-on;
+ vin-supply = <_sys>;
+ };
+
+ vcc5v0_usb2: vcc5v0-usb2 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_usb2";
+ regulator-always-on;
+ regulator-boot-on;
+ vin-supply = <_sys>;
+ };
+};
+
+_sys {
+ vin-supply = <_core>;
+};
+
+_host {
+ phy-supply = <_usb1>;
+};
+
+_host {
+ phy-supply = <_usb2>;
+};
+
+_typec {
+ regulator-always-on;
+ vin-supply = <_5v>;
+};
diff --git a/board/rockchip/evb_rk3399/MAINTAINERS
b/board/rockchip/evb_rk3399/MAINTAINERS
index 4c889e06a6..9967d68a88 100644
--- a/board/rockchip/evb_rk3399/MAINTAINERS
+++ b/board/rockchip/evb_rk3399/MAINTAINERS
@@ -49,6 +49,12 @@ S: Maintained
F:configs/nanopi-m4-2gb-rk3399_defconfig
F:arch/arm/dts/rk3399-nanopi-m4-2gb-u-boot.dtsi
+NANOPC-M4V2
+M: Shuying Li
+S: Maintained
+F: configs/nanopi-m4v2-rk3399_defconfig
+F: arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
+
NANOPI-NEO4
M:Jagan Teki
S:Maintained
diff --git a/configs/nanopi-m4v2-rk3399_defconfig
b/configs/nanopi-m4v2-rk3399_defconfig
new file mode 100644
index 00..d5c58d549f
--- /dev/null
+++ b/configs/nanopi-m4v2-rk3399_defconfig
@@ -0,0 +1,61 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SYS_TEXT_BASE=0x0020
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_ENV_OFFSET=0x3F8000
+CONFIG_ROCKCHIP_RK3399=y
+CONFIG_TARGET_EVB_RK3399=y
+CONFIG_DEBUG_UART_BASE=0xFF1A
+CONFIG_DEBUG_UART_CLOCK=2400
+CONFIG_DEFAULT_DEVICE_TREE="rk3399-nanopi-m4v2"
+CONFIG_DEBUG_UART=y
Re: [PATCH] rockchip: rk3399: Add Nanopi M4V2 board support
On Sat, Oct 24, 2020 at 12:17 AM Jagan Teki wrote: > > On Sun, Oct 18, 2020 at 5:39 PM Shuying Li wrote: > > > > From: Libunko > > > > Add initial support for Nanopi M4V2 board. > > > > Specification > > - Rockchip RK3399 > > - Dual-Channel 4GB LPDDR4 > > - SD card slot > > - eMMC socket > > - RTL8211E 1Gbps > > - AP6356S WiFI/BT > > - HDMI In/Out, MIPI DSI/CSI > > - USB 3.0 x4 > > - USB Type C power and data > > - GPIO1, GPIO2 expansion ports > > - DC5V/3A > > > > Signed-off-by: Shuying Li > > --- > > arch/arm/dts/Makefile | 1 + > > arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi | 7 +++ > > arch/arm/dts/rk3399-nanopi-m4v2.dts | 67 + Hope you sync the dts from Linux, if yes please add sha1 on the commit message. The rest looks fine. Reviewed-by: Jagan Teki
Re: [PATCH] rockchip: rk3399: Add Nanopi M4V2 board support
On Sun, Oct 18, 2020 at 5:39 PM Shuying Li wrote:
>
> From: Libunko
>
> Add initial support for Nanopi M4V2 board.
>
> Specification
> - Rockchip RK3399
> - Dual-Channel 4GB LPDDR4
> - SD card slot
> - eMMC socket
> - RTL8211E 1Gbps
> - AP6356S WiFI/BT
> - HDMI In/Out, MIPI DSI/CSI
> - USB 3.0 x4
> - USB Type C power and data
> - GPIO1, GPIO2 expansion ports
> - DC5V/3A
>
> Signed-off-by: Shuying Li
> ---
> arch/arm/dts/Makefile | 1 +
> arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi | 7 +++
> arch/arm/dts/rk3399-nanopi-m4v2.dts | 67 +
> board/rockchip/evb_rk3399/MAINTAINERS | 6 ++
> configs/nanopi-m4v2-rk3399_defconfig| 61 +++
> doc/board/rockchip/rockchip.rst | 1 +
> 6 files changed, 143 insertions(+)
> create mode 100644 arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> create mode 100644 arch/arm/dts/rk3399-nanopi-m4v2.dts
> create mode 100644 configs/nanopi-m4v2-rk3399_defconfig
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index f8f529435b..7e8dfcef88 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -130,6 +130,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3399) += \
> rk3399-nanopc-t4.dtb \
> rk3399-nanopi-m4.dtb \
> rk3399-nanopi-m4-2gb.dtb \
> + rk3399-nanopi-m4v2.dtb \
> rk3399-nanopi-neo4.dtb \
> rk3399-orangepi.dtb \
> rk3399-pinebook-pro.dtb \
> diff --git a/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> b/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> new file mode 100644
> index 00..ff8e99cb7f
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2020 Shuying Li
> + */
> +
> +#include "rk3399-nanopi4-u-boot.dtsi"
> +#include "rk3399-sdram-lpddr4-100.dtsi"
> diff --git a/arch/arm/dts/rk3399-nanopi-m4v2.dts
> b/arch/arm/dts/rk3399-nanopi-m4v2.dts
> new file mode 100644
> index 00..03d956d2c4
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-nanopi-m4v2.dts
> @@ -0,0 +1,67 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * FriendlyElec NanoPi M4V2 board device tree source
> + *
> + * Copyright (c) 2018 FriendlyElec Computer Tech. Co., Ltd.
> + * (http://www.friendlyarm.com)
> + *
> + * Copyright (c) 2018 Collabora Ltd.
> + * Copyright (c) 2019 Arm Ltd.
> + * Copyright (C) 2020 Shuying Li
> + */
> +
> +/dts-v1/;
> +#include "rk3399-nanopi4.dtsi"
> +
> +/ {
> + model = "FriendlyElec NanoPi M4V2";
> + compatible = "friendlyarm,nanopi-m4v2", "rockchip,rk3399";
> +
> + vdd_5v: vdd-5v {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd_5v";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vcc5v0_core: vcc5v0-core {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_core";
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <_5v>;
> + };
> +
> + vcc5v0_usb1: vcc5v0-usb1 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_usb1";
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <_sys>;
> + };
> +
> + vcc5v0_usb2: vcc5v0-usb2 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_usb2";
> + regulator-always-on;
> + regulator-boot-on;
> + vin-supply = <_sys>;
> + };
> +};
> +
> +_sys {
> + vin-supply = <_core>;
> +};
> +
> +_host {
> + phy-supply = <_usb1>;
> +};
> +
> +_host {
> + phy-supply = <_usb2>;
> +};
> +
> +_typec {
> + regulator-always-on;
> + vin-supply = <_5v>;
> +};
> diff --git a/board/rockchip/evb_rk3399/MAINTAINERS
> b/board/rockchip/evb_rk3399/MAINTAINERS
> index 4c889e06a6..9967d68a88 100644
> --- a/board/rockchip/evb_rk3399/MAINTAINERS
> +++ b/board/rockchip/evb_rk3399/MAINTAINERS
> @@ -49,6 +49,12 @@ S: Maintained
> F: configs/nanopi-m4-2gb-rk3399_defconfig
> F: arch/arm/dts/rk3399-nanopi-m4-2gb-u-boot.dtsi
>
> +NANOPC-M4V2
> +M: Shuying Li
> +S: Maintained
> +F: configs/nanopi-m4v2-rk3399_defconfig
> +F: arch/arm/dts/rk3399-nanopi-m4v2-u-boot.dtsi
> +
> NANOPI-NEO4
> M: Jagan Teki
> S: Maintained
> diff --git a/configs/nanopi-m4v2-rk3399_defconfig
> b/configs/nanopi-m4v2-rk3399_defconfig
> new file mode 100644
> index 00..d5c58d549f
> --- /dev/null
> +++ b/configs/nanopi-m4v2-rk3399_defconfig
> @@ -0,0 +1,61 @@
> +CONFIG_ARM=y
> +CONFIG_ARCH_ROCKCHIP=y
> +CONFIG_SYS_TEXT_BASE=0x0020
> +CONFIG_NR_DRAM_BANKS=1
> +CONFIG_ENV_OFFSET=0x3F8000
> +CONFIG_ROCKCHIP_RK3399=y
> +CONFIG_TARGET_EVB_RK3399=y
> +CONFIG_DEBUG_UART_BASE=0xFF1A
> +CONFIG_DEBUG_UART_CLOCK=2400
>
