Re: [PATCH] spi: cadence-quadspi: Fix error message on stuck busy state
On Mon, Oct 30, 2023 at 9:50 PM Jan Kiszka wrote: > > From: Jan Kiszka > > We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since > day 1. > > Signed-off-by: Jan Kiszka > --- Applied to u-boot-spi/master
Re: [PATCH] spi: cadence-quadspi: Fix error message on stuck busy state
On Thu, Dec 14, 2023 at 06:36:37PM +0100, Jan Kiszka wrote:
> On 31.10.23 08:14, Stefan Roese wrote:
> > On 10/30/23 17:20, Jan Kiszka wrote:
> >> From: Jan Kiszka
> >>
> >> We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since
> >> day 1.
> >>
> >> Signed-off-by: Jan Kiszka
> >
> > Reviewed-by: Stefan Roese
> >
> > Thanks,
> > Stefan
> >
> >> ---
> >>
> >> We are unfortunately seeing that message right now, rarely but then
> >> prominently...
> >>
> >> drivers/spi/cadence_qspi_apb.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/spi/cadence_qspi_apb.c
> >> b/drivers/spi/cadence_qspi_apb.c
> >> index 9ce2c0f254f..d033184aa46 100644
> >> --- a/drivers/spi/cadence_qspi_apb.c
> >> +++ b/drivers/spi/cadence_qspi_apb.c
> >> @@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void
> >> *reg_base)
> >> }
> >> /* Timeout, still in busy mode. */
> >> - printf("QSPI: QSPI is still busy after poll for %d times.\n",
> >> - CQSPI_REG_RETRY);
> >> + printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout);
> >> return 0;
> >> }
> >>
> >
> > Viele Grüße,
> > Stefan Roese
> >
>
> Ping.
Added to my dont-forget bundle.
--
Tom
signature.asc
Description: PGP signature
Re: [PATCH] spi: cadence-quadspi: Fix error message on stuck busy state
On 31.10.23 08:14, Stefan Roese wrote:
> On 10/30/23 17:20, Jan Kiszka wrote:
>> From: Jan Kiszka
>>
>> We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since
>> day 1.
>>
>> Signed-off-by: Jan Kiszka
>
> Reviewed-by: Stefan Roese
>
> Thanks,
> Stefan
>
>> ---
>>
>> We are unfortunately seeing that message right now, rarely but then
>> prominently...
>>
>> drivers/spi/cadence_qspi_apb.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/spi/cadence_qspi_apb.c
>> b/drivers/spi/cadence_qspi_apb.c
>> index 9ce2c0f254f..d033184aa46 100644
>> --- a/drivers/spi/cadence_qspi_apb.c
>> +++ b/drivers/spi/cadence_qspi_apb.c
>> @@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void
>> *reg_base)
>> }
>> /* Timeout, still in busy mode. */
>> - printf("QSPI: QSPI is still busy after poll for %d times.\n",
>> - CQSPI_REG_RETRY);
>> + printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout);
>> return 0;
>> }
>>
>
> Viele Grüße,
> Stefan Roese
>
Ping.
Jan
--
Siemens AG, Technology
Linux Expert Center
Re: [PATCH] spi: cadence-quadspi: Fix error message on stuck busy state
On 10/30/23 17:20, Jan Kiszka wrote:
From: Jan Kiszka
We are not iterating CQSPI_REG_RETRY, we are waiting 'timeout' ms, since
day 1.
Signed-off-by: Jan Kiszka
Reviewed-by: Stefan Roese
Thanks,
Stefan
---
We are unfortunately seeing that message right now, rarely but then
prominently...
drivers/spi/cadence_qspi_apb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c
index 9ce2c0f254f..d033184aa46 100644
--- a/drivers/spi/cadence_qspi_apb.c
+++ b/drivers/spi/cadence_qspi_apb.c
@@ -171,8 +171,7 @@ static unsigned int cadence_qspi_wait_idle(void *reg_base)
}
/* Timeout, still in busy mode. */
- printf("QSPI: QSPI is still busy after poll for %d times.\n",
- CQSPI_REG_RETRY);
+ printf("QSPI: QSPI is still busy after poll for %d ms.\n", timeout);
return 0;
}
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de
