Re: [PATCH] usb: musb-new: sunxi: remove unused define

[Sam Edwards]

Hi Marek,


Please add missing commit message and send V2.


Ah, apologies! I had (mistakenly) believed that the summary line would 
be a sufficient commit message for something so trivial.


Instead I did a little research into how this got here and wrote a quick 
explanation of why it's unused. I figure that would be a bit more 
helpful for someone reading the commit history than just reiterating 
that "It's, y'know, unused." :)



Otherwise

Reviewed-by: Marek Vasut 


Thank you for the speedy review!

Cheers,
Sam

Re: [PATCH] usb: musb-new: sunxi: remove unused define

[Marek Vasut]

On 6/8/23 01:16, Sam Edwards wrote:

Signed-off-by: Sam Edwards 
---
  drivers/usb/musb-new/sunxi.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
index 2b954601a0..85d815ad75 100644
--- a/drivers/usb/musb-new/sunxi.c
+++ b/drivers/usb/musb-new/sunxi.c
@@ -81,8 +81,6 @@
   * From usbc/usbc.c
   
**/
  
-#define OFF_SUN6I_AHB_RESET0	0x2c0

-
  struct sunxi_musb_config {
struct musb_hdrc_config *config;
bool has_sram;


Please add missing commit message and send V2.

Otherwise

Reviewed-by: Marek Vasut