Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox
hello Heinrich, On Sun, 21 Aug 2022 at 12:46, Heinrich Schuchardt wrote: > > On 7/22/22 19:42, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > The mtd and synquacer (developerbox) support was dropped from v6[1] > > This patchset re-introduces the support over last v7[2] submission of the > > patchset. > > So this series should have been marked v8? > > > > > All the comments on this code over v5 submission have been addressed. > > Moving forward > > a changelog will be maintained. > > > > [1] > > https://lore.kernel.org/all/20220704051658.1085442-1-sughosh.g...@linaro.org/ > > [2] > > https://lore.kernel.org/all/20220714183913.118505-1-sughosh.g...@linaro.org/ > > How does this series relate to > > [PATCH v8 00/13] FWU: Add FWU Multi Bank Update feature support > https://lore.kernel.org/all/20220817124323.375968-1-sughosh.g...@linaro.org/? > > Is it superseded by that series? > > This series has "FWU metadata on MTD device without GPT" while the other > has "FWU metadata on device with GPT partitioned layout". > > Do we need both? Yes, we need both the patch series. The first series([PATCH v8 00/13] FWU: Add FWU Multi Bank Update feature support) adds support for the feature and for platforms with GPT partitioning layout, and is enabling the feature on the ST DK2 board. The second series is adding support for the feature on MTD partition based devices and enabling the feature on the Synquacer board. -sughosh > > Best regards > > Heinrich > > > > > Jassi Brar (2): > >dt: fwu: developerbox: enable fwu banks and mdata regions > >fwu: DeveloperBox: add support for FWU > > > > Sughosh Ganu (3): > >dt/bindings: Add bindings for FWU Metadata mtd storage > >FWU: Add FWU metadata access driver for MTD storage regions > >FWU: mtd: Add helper functions for accessing FWU metadata > > > > .../synquacer-sc2a11-developerbox-u-boot.dtsi | 22 +- > > board/socionext/developerbox/Makefile | 1 + > > board/socionext/developerbox/developerbox.c | 13 + > > board/socionext/developerbox/fwu_plat.c | 95 ++ > > configs/synquacer_developerbox_defconfig | 13 +- > > doc/board/socionext/developerbox.rst | 96 ++ > > .../firmware/fwu-mdata-mtd.yaml | 38 +++ > > drivers/fwu-mdata/Kconfig | 8 + > > drivers/fwu-mdata/Makefile| 1 + > > drivers/fwu-mdata/fwu_mdata_mtd.c | 308 ++ > > include/configs/synquacer.h | 10 + > > lib/fwu_updates/Makefile | 1 + > > lib/fwu_updates/fwu_mtd.c | 173 ++ > > 13 files changed, 776 insertions(+), 3 deletions(-) > > create mode 100644 board/socionext/developerbox/fwu_plat.c > > create mode 100644 doc/device-tree-bindings/firmware/fwu-mdata-mtd.yaml > > create mode 100644 drivers/fwu-mdata/fwu_mdata_mtd.c > > create mode 100644 lib/fwu_updates/fwu_mtd.c > > >
Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox
On 7/22/22 19:42, jassisinghb...@gmail.com wrote: From: Jassi Brar The mtd and synquacer (developerbox) support was dropped from v6[1] This patchset re-introduces the support over last v7[2] submission of the patchset. So this series should have been marked v8? All the comments on this code over v5 submission have been addressed. Moving forward a changelog will be maintained. [1] https://lore.kernel.org/all/20220704051658.1085442-1-sughosh.g...@linaro.org/ [2] https://lore.kernel.org/all/20220714183913.118505-1-sughosh.g...@linaro.org/ How does this series relate to [PATCH v8 00/13] FWU: Add FWU Multi Bank Update feature support https://lore.kernel.org/all/20220817124323.375968-1-sughosh.g...@linaro.org/? Is it superseded by that series? This series has "FWU metadata on MTD device without GPT" while the other has "FWU metadata on device with GPT partitioned layout". Do we need both? Best regards Heinrich Jassi Brar (2): dt: fwu: developerbox: enable fwu banks and mdata regions fwu: DeveloperBox: add support for FWU Sughosh Ganu (3): dt/bindings: Add bindings for FWU Metadata mtd storage FWU: Add FWU metadata access driver for MTD storage regions FWU: mtd: Add helper functions for accessing FWU metadata .../synquacer-sc2a11-developerbox-u-boot.dtsi | 22 +- board/socionext/developerbox/Makefile | 1 + board/socionext/developerbox/developerbox.c | 13 + board/socionext/developerbox/fwu_plat.c | 95 ++ configs/synquacer_developerbox_defconfig | 13 +- doc/board/socionext/developerbox.rst | 96 ++ .../firmware/fwu-mdata-mtd.yaml | 38 +++ drivers/fwu-mdata/Kconfig | 8 + drivers/fwu-mdata/Makefile| 1 + drivers/fwu-mdata/fwu_mdata_mtd.c | 308 ++ include/configs/synquacer.h | 10 + lib/fwu_updates/Makefile | 1 + lib/fwu_updates/fwu_mtd.c | 173 ++ 13 files changed, 776 insertions(+), 3 deletions(-) create mode 100644 board/socionext/developerbox/fwu_plat.c create mode 100644 doc/device-tree-bindings/firmware/fwu-mdata-mtd.yaml create mode 100644 drivers/fwu-mdata/fwu_mdata_mtd.c create mode 100644 lib/fwu_updates/fwu_mtd.c
Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox
On 7/22/22 19:42, jassisinghb...@gmail.com wrote: From: Jassi Brar The mtd and synquacer (developerbox) support was dropped from v6[1] This patchset re-introduces the support over last v7[2] submission of the patchset. All the comments on this code over v5 submission have been addressed. Moving forward a changelog will be maintained. [1] https://lore.kernel.org/all/20220704051658.1085442-1-sughosh.g...@linaro.org/ [2] https://lore.kernel.org/all/20220714183913.118505-1-sughosh.g...@linaro.org/ This new feature deserves a test that can executed in Gitlab. Preferably we would test on the sandbox. But testing on QEMU using an emulated flash would be another option. Best regards Heinrich Jassi Brar (2): dt: fwu: developerbox: enable fwu banks and mdata regions fwu: DeveloperBox: add support for FWU Sughosh Ganu (3): dt/bindings: Add bindings for FWU Metadata mtd storage FWU: Add FWU metadata access driver for MTD storage regions FWU: mtd: Add helper functions for accessing FWU metadata .../synquacer-sc2a11-developerbox-u-boot.dtsi | 22 +- board/socionext/developerbox/Makefile | 1 + board/socionext/developerbox/developerbox.c | 13 + board/socionext/developerbox/fwu_plat.c | 95 ++ configs/synquacer_developerbox_defconfig | 13 +- doc/board/socionext/developerbox.rst | 96 ++ .../firmware/fwu-mdata-mtd.yaml | 38 +++ drivers/fwu-mdata/Kconfig | 8 + drivers/fwu-mdata/Makefile| 1 + drivers/fwu-mdata/fwu_mdata_mtd.c | 308 ++ include/configs/synquacer.h | 10 + lib/fwu_updates/Makefile | 1 + lib/fwu_updates/fwu_mtd.c | 173 ++ 13 files changed, 776 insertions(+), 3 deletions(-) create mode 100644 board/socionext/developerbox/fwu_plat.c create mode 100644 doc/device-tree-bindings/firmware/fwu-mdata-mtd.yaml create mode 100644 drivers/fwu-mdata/fwu_mdata_mtd.c create mode 100644 lib/fwu_updates/fwu_mtd.c
Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox
Hi Sughosh, On Mon, 25 Jul 2022 at 02:18, Sughosh Ganu wrote: > > hi Jassi, > > On Fri, 22 Jul 2022 at 23:12, wrote: > > > > From: Jassi Brar > > > > The mtd and synquacer (developerbox) support was dropped from v6[1] > > This patchset re-introduces the support over last v7[2] submission of the > > patchset. > > > > All the comments on this code over v5 submission have been addressed. > > Moving forward > > a changelog will be maintained. > > > > [1] > > https://lore.kernel.org/all/20220704051658.1085442-1-sughosh.g...@linaro.org/ > > [2] > > https://lore.kernel.org/all/20220714183913.118505-1-sughosh.g...@linaro.org/ > > > > Jassi Brar (2): > > dt: fwu: developerbox: enable fwu banks and mdata regions > > fwu: DeveloperBox: add support for FWU > > > > Sughosh Ganu (3): > > dt/bindings: Add bindings for FWU Metadata mtd storage > > FWU: Add FWU metadata access driver for MTD storage regions > > FWU: mtd: Add helper functions for accessing FWU metadata > > All the above patches have been authored by Masami Hiramatsu. I think > you should change the author for these patches. > oops... I used the '-c' option to carry over the log from your patches and forgot to update the author. Will do. thanks. > Also, there were a few > more patches from Masami, like the documentation for the feature on > the Synquacer platform, and addition of the tool, mkfwumdata, for > generating the FWU metadata which I do not see in this series. Do you > plan to send those separately? > yes.
Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox
hi Jassi, On Fri, 22 Jul 2022 at 23:12, wrote: > > From: Jassi Brar > > The mtd and synquacer (developerbox) support was dropped from v6[1] > This patchset re-introduces the support over last v7[2] submission of the > patchset. > > All the comments on this code over v5 submission have been addressed. Moving > forward > a changelog will be maintained. > > [1] > https://lore.kernel.org/all/20220704051658.1085442-1-sughosh.g...@linaro.org/ > [2] > https://lore.kernel.org/all/20220714183913.118505-1-sughosh.g...@linaro.org/ > > Jassi Brar (2): > dt: fwu: developerbox: enable fwu banks and mdata regions > fwu: DeveloperBox: add support for FWU > > Sughosh Ganu (3): > dt/bindings: Add bindings for FWU Metadata mtd storage > FWU: Add FWU metadata access driver for MTD storage regions > FWU: mtd: Add helper functions for accessing FWU metadata All the above patches have been authored by Masami Hiramatsu. I think you should change the author for these patches. Also, there were a few more patches from Masami, like the documentation for the feature on the Synquacer platform, and addition of the tool, mkfwumdata, for generating the FWU metadata which I do not see in this series. Do you plan to send those separately? -sughosh > > .../synquacer-sc2a11-developerbox-u-boot.dtsi | 22 +- > board/socionext/developerbox/Makefile | 1 + > board/socionext/developerbox/developerbox.c | 13 + > board/socionext/developerbox/fwu_plat.c | 95 ++ > configs/synquacer_developerbox_defconfig | 13 +- > doc/board/socionext/developerbox.rst | 96 ++ > .../firmware/fwu-mdata-mtd.yaml | 38 +++ > drivers/fwu-mdata/Kconfig | 8 + > drivers/fwu-mdata/Makefile| 1 + > drivers/fwu-mdata/fwu_mdata_mtd.c | 308 ++ > include/configs/synquacer.h | 10 + > lib/fwu_updates/Makefile | 1 + > lib/fwu_updates/fwu_mtd.c | 173 ++ > 13 files changed, 776 insertions(+), 3 deletions(-) > create mode 100644 board/socionext/developerbox/fwu_plat.c > create mode 100644 doc/device-tree-bindings/firmware/fwu-mdata-mtd.yaml > create mode 100644 drivers/fwu-mdata/fwu_mdata_mtd.c > create mode 100644 lib/fwu_updates/fwu_mtd.c > > -- > 2.25.1 >
