Re: [PATCH 00/16] Kconfig: Tidy up the top-level kconfig menu
On Thu, Sep 10, 2020 at 08:21:11PM -0600, Simon Glass wrote: > > At present this menu is pretty messy, with quite a few minor options shown > at the top level. This series creates a few new menus and moves things > around so that the top-level menu is cleaner. > > There is more to do, but this is a start. [snip] > Kconfig | 340 +--- > cmd/Kconfig | 117 -- > common/Kconfig | 505 ++-- > common/Kconfig.boot | 894 +++ > drivers/core/Kconfig | 11 + > dts/Kconfig | 9 - > env/Kconfig | 9 + > tools/Kconfig| 12 + > 8 files changed, 955 insertions(+), 942 deletions(-) > create mode 100644 common/Kconfig.boot > create mode 100644 tools/Kconfig And after a resync of the defconfigs: 555 files changed, 941 insertions(+), 941 deletions(-) and a partial wc -l: 449 Kconfig 697 common/Kconfig 894 common/Kconfig.boot 2190 cmd/Kconfig So in the end, yes, this is I think making things easier to maintain but will cause a few merge hiccups. -- Tom signature.asc Description: PGP signature
Re: [PATCH 00/16] Kconfig: Tidy up the top-level kconfig menu
Hi Tom, On Fri, 11 Sep 2020 at 10:11, Tom Rini wrote: > > On Thu, Sep 10, 2020 at 08:21:11PM -0600, Simon Glass wrote: > > > > > At present this menu is pretty messy, with quite a few minor options shown > > at the top level. This series creates a few new menus and moves things > > around so that the top-level menu is cleaner. > > > > There is more to do, but this is a start. > [snip] > > Kconfig | 340 +--- > > cmd/Kconfig | 117 -- > > common/Kconfig | 505 ++-- > > common/Kconfig.boot | 894 +++ > > drivers/core/Kconfig | 11 + > > dts/Kconfig | 9 - > > env/Kconfig | 9 + > > tools/Kconfig| 12 + > > 8 files changed, 955 insertions(+), 942 deletions(-) > > create mode 100644 common/Kconfig.boot > > create mode 100644 tools/Kconfig > > And after a resync of the defconfigs: > 555 files changed, 941 insertions(+), 941 deletions(-) > and a partial wc -l: >449 Kconfig >697 common/Kconfig >894 common/Kconfig.boot > 2190 cmd/Kconfig > > So in the end, yes, this is I think making things easier to maintain but > will cause a few merge hiccups. Oh dear, I completely forgot about that aspect. Should I add a resync patch at the end, or is it better to do it when reviewed/applied? Regards, Simon
Re: [PATCH 00/16] Kconfig: Tidy up the top-level kconfig menu
On Fri, Sep 11, 2020 at 02:15:50PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 11 Sep 2020 at 10:11, Tom Rini wrote: > > > > On Thu, Sep 10, 2020 at 08:21:11PM -0600, Simon Glass wrote: > > > > > > > > At present this menu is pretty messy, with quite a few minor options shown > > > at the top level. This series creates a few new menus and moves things > > > around so that the top-level menu is cleaner. > > > > > > There is more to do, but this is a start. > > [snip] > > > Kconfig | 340 +--- > > > cmd/Kconfig | 117 -- > > > common/Kconfig | 505 ++-- > > > common/Kconfig.boot | 894 +++ > > > drivers/core/Kconfig | 11 + > > > dts/Kconfig | 9 - > > > env/Kconfig | 9 + > > > tools/Kconfig| 12 + > > > 8 files changed, 955 insertions(+), 942 deletions(-) > > > create mode 100644 common/Kconfig.boot > > > create mode 100644 tools/Kconfig > > > > And after a resync of the defconfigs: > > 555 files changed, 941 insertions(+), 941 deletions(-) > > and a partial wc -l: > >449 Kconfig > >697 common/Kconfig > >894 common/Kconfig.boot > > 2190 cmd/Kconfig > > > > So in the end, yes, this is I think making things easier to maintain but > > will cause a few merge hiccups. > > Oh dear, I completely forgot about that aspect. Should I add a resync > patch at the end, or is it better to do it when reviewed/applied? Don't worry about re-sync patches, those are trivially generated and fail to apply easily. Really I'm fine with most cases not touching defconfigs EXCEPT when we're changing requires / depends stuff. That requires a defconfig change at the same time to not break things. -- Tom signature.asc Description: PGP signature
Re: [PATCH 00/16] Kconfig: Tidy up the top-level kconfig menu
On Thu, Sep 10, 2020 at 08:21:11PM -0600, Simon Glass wrote: > At present this menu is pretty messy, with quite a few minor options shown > at the top level. This series creates a few new menus and moves things > around so that the top-level menu is cleaner. > > There is more to do, but this is a start. > > > Simon Glass (16): > Kconfig: Add a 'Boot options' menu > Kconfig: Move boot menu into common/ > Kconfig: Move boot timing under boot options > Kconfig: Move boot media under boot options > Kconfig: Move autoboot options under boot options > Kconfig: Move CONFIG_BOOTDELAY under autoboot options > Kconfig: Move misc boot options under 'boot options' > Kconfig: Move SUPPORT_RAW_INITRD under boot options > Kconfig: Move DEFAULT_FDT_FILE under boot options > Kconfig: Create a new 'init options' menu > Kconfig: Move startup hooks under init options > Kconfig: MISC_INIT_R and BOARD_LATE_INIT -> start-up hooks > Kconfig: Move VERSION_VARIABLE under environment > Kconfig: Move BOUNCE_BUFFER under driver options > Kconfig: Move BOARD_TYPES under init options > Kconfig: Create a new tools menu > > Kconfig | 340 +--- > cmd/Kconfig | 117 -- > common/Kconfig | 505 ++-- > common/Kconfig.boot | 894 +++ > drivers/core/Kconfig | 11 + > dts/Kconfig | 9 - > env/Kconfig | 9 + > tools/Kconfig| 12 + > 8 files changed, 955 insertions(+), 942 deletions(-) > create mode 100644 common/Kconfig.boot > create mode 100644 tools/Kconfig For the series, applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
