Re: [PATCH 01/20] m68k: Remove CONFIG_FSLDMAFEC
On Wed, 01 Nov 2023 12:28:05 -0400, Tom Rini wrote: > There are no platforms which enable this feature, so remove it. > > Applied to u-boot/next, thanks! -- Tom
Re: [PATCH 01/20] m68k: Remove CONFIG_FSLDMAFEC
Hi Tom, sure, i remove the unused dtsi, patch will follow. Regards, angelo On 06/11/23 5:32 PM, Tom Rini wrote: On Sat, Nov 04, 2023 at 09:58:07PM +0100, Angelo Dureghello wrote: Hi Tom, Reviewed by: Angelo Dureghello Thanks for the cleanup, m68k boards build fine. fsl_mcdmafec driver is still referenced in arch/m68k/dts/mcf54xx.dtsi, (from compatible field) but no board is including it. You can remove the dtsi too if you want. Thanks for the review. I'd appreciate it if you went and did the rest of the cleaning of unused code around here as I'm not familiar with it, I just found this one as part of looking for common.h usage.
Re: [PATCH 01/20] m68k: Remove CONFIG_FSLDMAFEC
On Sat, Nov 04, 2023 at 09:58:07PM +0100, Angelo Dureghello wrote: > Hi Tom, > > Reviewed by: Angelo Dureghello > > > Thanks for the cleanup, m68k boards build fine. > > fsl_mcdmafec driver is still referenced in arch/m68k/dts/mcf54xx.dtsi, > (from compatible field) but no board is including it. > You can remove the dtsi too if you want. Thanks for the review. I'd appreciate it if you went and did the rest of the cleaning of unused code around here as I'm not familiar with it, I just found this one as part of looking for common.h usage. -- Tom signature.asc Description: PGP signature
Re: [PATCH 01/20] m68k: Remove CONFIG_FSLDMAFEC
Hi Tom,
Reviewed by: Angelo Dureghello
Thanks for the cleanup, m68k boards build fine.
fsl_mcdmafec driver is still referenced in arch/m68k/dts/mcf54xx.dtsi,
(from compatible field) but no board is including it.
You can remove the dtsi too if you want.
Regards,
angelo
On 01/11/23 5:28 PM, Tom Rini wrote:
There are no platforms which enable this feature, so remove it.
Signed-off-by: Tom Rini
---
Cc: Angelo Dureghello
---
arch/m68k/include/asm/fsl_mcdmafec.h | 151 --
arch/m68k/include/asm/immap.h| 15 -
arch/m68k/lib/fec.c |4 +-
drivers/dma/Kconfig |1 -
drivers/dma/MCD_dmaApi.c | 1010 ---
drivers/dma/MCD_tasks.c | 2413 --
drivers/dma/MCD_tasksInit.c | 225 ---
drivers/dma/Makefile |1 -
drivers/net/Kconfig |8 -
drivers/net/Makefile |1 -
drivers/net/fsl_mcdmafec.c | 592 ---
include/MCD_dma.h| 369
include/MCD_progCheck.h | 10 -
include/MCD_tasksInit.h | 43 -
14 files changed, 2 insertions(+), 4841 deletions(-)
delete mode 100644 arch/m68k/include/asm/fsl_mcdmafec.h
delete mode 100644 drivers/dma/MCD_dmaApi.c
delete mode 100644 drivers/dma/MCD_tasks.c
delete mode 100644 drivers/dma/MCD_tasksInit.c
delete mode 100644 drivers/net/fsl_mcdmafec.c
delete mode 100644 include/MCD_dma.h
delete mode 100644 include/MCD_progCheck.h
delete mode 100644 include/MCD_tasksInit.h
diff --git a/arch/m68k/include/asm/fsl_mcdmafec.h
b/arch/m68k/include/asm/fsl_mcdmafec.h
deleted file mode 100644
index de6c548fafd7..
--- a/arch/m68k/include/asm/fsl_mcdmafec.h
+++ /dev/null
@@ -1,151 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * fsl_mcdmafec.h -- Multi-channel DMA Fast Ethernet Controller definitions
- *
- * Copyright (C) 2004-2007 Freescale Semiconductor, Inc.
- * TsiChung Liew (tsi-chung.l...@freescale.com)
- */
-
-#ifndef fsl_mcdmafec_h
-#define fsl_mcdmafec_h
-
-/* Re-use of the definitions */
-#include
-
-typedef struct fecdma {
- u32 rsvd0; /* 0x000 */
- u32 eir;/* 0x004 */
- u32 eimr; /* 0x008 */
- u32 rsvd1[6]; /* 0x00C - 0x023 */
- u32 ecr;/* 0x024 */
- u32 rsvd2[6]; /* 0x028 - 0x03F */
- u32 mmfr; /* 0x040 */
- u32 mscr; /* 0x044 */
- u32 rsvd3[7]; /* 0x048 - 0x063 */
- u32 mibc; /* 0x064 */
- u32 rsvd4[7]; /* 0x068 - 0x083 */
- u32 rcr;/* 0x084 */
- u32 rhr;/* 0x088 */
- u32 rsvd5[14]; /* 0x08C - 0x0C3 */
- u32 tcr;/* 0x0C4 */
- u32 rsvd6[7]; /* 0x0C8 - 0x0E3 */
- u32 palr; /* 0x0E4 */
- u32 paur; /* 0x0E8 */
- u32 opd;/* 0x0EC */
- u32 rsvd7[10]; /* 0x0F0 - 0x117 */
- u32 iaur; /* 0x118 */
- u32 ialr; /* 0x11C */
- u32 gaur; /* 0x120 */
- u32 galr; /* 0x124 */
- u32 rsvd8[7]; /* 0x128 - 0x143 */
- u32 tfwr; /* 0x144 */
- u32 rsvd9[14]; /* 0x148 - 0x17F */
- u32 fmc;/* 0x180 */
- u32 rfdr; /* 0x184 */
- u32 rfsr; /* 0x188 */
- u32 rfcr; /* 0x18C */
- u32 rlrfp; /* 0x190 */
- u32 rlwfp; /* 0x194 */
- u32 rfar; /* 0x198 */
- u32 rfrp; /* 0x19C */
- u32 rfwp; /* 0x1A0 */
- u32 tfdr; /* 0x1A4 */
- u32 tfsr; /* 0x1A8 */
- u32 tfcr; /* 0x1AC */
- u32 tlrfp; /* 0x1B0 */
- u32 tlwfp; /* 0x1B4 */
- u32 tfar; /* 0x1B8 */
- u32 tfrp; /* 0x1BC */
- u32 tfwp; /* 0x1C0 */
- u32 frst; /* 0x1C4 */
- u32 ctcwr; /* 0x1C8 */
-} fecdma_t;
-
-struct fec_info_dma {
- int index;
- u32 iobase;
- u32 pinmux;
- u32 miibase;
- int phy_addr;
- int dup_spd;
- char *phy_name;
- int phyname_init;
- cbd_t *rxbd;/* Rx BD */
- cbd_t *txbd;/* Tx BD */
- uint rx_idx;
- uint tx_idx;
- char *txbuf;
- int initialized;
- struct fec_info_dma *next;
- u16 rx_task;/* DMA receive Task Number */
- u16 tx_task;/* DMA Transmit Task Number */
- u16 rx_pri; /* DMA Receive Priority */
- u16 tx_pri; /* DMA Transmit Priority */
- u16 rx_init;/* DMA Receive Initiator */
-
