Re: [PATCH 02/17] net: ipv6: Add IPv6 build options

2022-09-12 Thread Ramon Fried
On Thu, Sep 8, 2022 at 2:59 PM Viacheslav Mitrofanov
 wrote:
>
> Add options to Makefile and Kconfig file to build IPv6
>
> Series-changes: 3
> - Added help for IPv6 support
>
> Signed-off-by: Viacheslav Mitrofanov 
> Reviewed-by: Simon Glass 
> ---
>  net/Kconfig  | 10 ++
>  net/Makefile |  1 +
>  2 files changed, 11 insertions(+)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 52e261884d..24a3cfa5f4 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -174,6 +174,16 @@ config BOOTP_MAX_ROOT_PATH_LEN
> help
>   Select maximal length of option 17 root path.
>
> +config IPV6
> +   bool "IPv6 support"
> +   help
> + Enable IPv6 support. It includes Neighbour Discovery protocol, 
> ICMPv6
> + and auxiliary stuff to make it work. Since it is enabled u-boot
> + network subsystem can get and handle incoming packets and send 
> packets
> + through IPv6 network. It allows to use environment variables such as
> + ip6addr, serverip6. If a u-boot command is capable to parse an IPv6
> + address and find it, it will force using IPv6 in the network stack.
> +
>  endif   # if NET
>
>  config SYS_RX_ETH_BUFFER
> diff --git a/net/Makefile b/net/Makefile
> index 6c812502d3..4ea2a14f27 100644
> --- a/net/Makefile
> +++ b/net/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_DM_MDIO_MUX) += mdio-mux-uclass.o
>  obj-$(CONFIG_NET)  += eth_common.o
>  obj-$(CONFIG_CMD_LINK_LOCAL) += link_local.o
>  obj-$(CONFIG_NET)  += net.o
> +obj-$(CONFIG_IPV6) += net6.o
>  obj-$(CONFIG_CMD_NFS)  += nfs.o
>  obj-$(CONFIG_CMD_PING) += ping.o
>  obj-$(CONFIG_CMD_PCAP) += pcap.o
> --
> 2.25.1
>
Reviewed-by: Ramon Fried 


Re: [PATCH 02/17] net: ipv6: Add IPv6 build options

2022-09-07 Thread Simon Glass
On Tue, 6 Sept 2022 at 09:10, Viacheslav Mitrofanov
 wrote:
>
> Add options to Makefile and Kconfig file to build IPv6
>
> Signed-off-by: Viacheslav Mitrofanov 
> ---
>  net/Kconfig  | 10 ++
>  net/Makefile |  1 +
>  2 files changed, 11 insertions(+)
>

Reviewed-by: Simon Glass 


Re: [PATCH 02/17] net: ipv6: Add IPv6 build options

2022-08-31 Thread Simon Glass
Hi Viacheslav,

On Tue, 30 Aug 2022 at 07:01, Viacheslav Mitrofanov
 wrote:
>
> Add options to Makefile and Kconfig file to build IPv6
>
> Signed-off-by: Viacheslav Mitrofanov 
> ---
>  net/Kconfig  | 4 
>  net/Makefile | 1 +
>  2 files changed, 5 insertions(+)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 52e261884d..568e622de8 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -174,6 +174,10 @@ config BOOTP_MAX_ROOT_PATH_LEN
> help
>   Select maximal length of option 17 root path.
>
> +config IPV6
> +   bool "IPv6 support"
> +   default n

drop that (n is already the default)

also please add lots of help!

> +
>  endif   # if NET
>
>  config SYS_RX_ETH_BUFFER
> diff --git a/net/Makefile b/net/Makefile
> index 6c812502d3..4ea2a14f27 100644
> --- a/net/Makefile
> +++ b/net/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_DM_MDIO_MUX) += mdio-mux-uclass.o
>  obj-$(CONFIG_NET)  += eth_common.o
>  obj-$(CONFIG_CMD_LINK_LOCAL) += link_local.o
>  obj-$(CONFIG_NET)  += net.o
> +obj-$(CONFIG_IPV6) += net6.o
>  obj-$(CONFIG_CMD_NFS)  += nfs.o
>  obj-$(CONFIG_CMD_PING) += ping.o
>  obj-$(CONFIG_CMD_PCAP) += pcap.o
> --
> 2.25.1
>

Regards,
Simon