Re: [PATCH 03/14] soc: add info to identify the J722S SoC family

2024-05-29 Thread Jayesh Choudhary

Hello Andrew,

On 29/05/24 20:36, Andrew Davis wrote:

On 5/29/24 8:24 AM, Jayesh Choudhary wrote:

Include the part number for TI's j722s family of SoC
to identify it during boot.

Signed-off-by: Vaishnav Achath 
Signed-off-by: Jayesh Choudhary 
---
  arch/arm/mach-k3/include/mach/hardware.h | 2 ++
  drivers/soc/soc_ti_k3.c  | 3 +++
  2 files changed, 5 insertions(+)

diff --git a/arch/arm/mach-k3/include/mach/hardware.h 
b/arch/arm/mach-k3/include/mach/hardware.h

index c3aaded8dc..26c5bfcf76 100644
--- a/arch/arm/mach-k3/include/mach/hardware.h
+++ b/arch/arm/mach-k3/include/mach/hardware.h
@@ -55,6 +55,7 @@
  #define JTAG_ID_PARTNO_J7200    0xbb6d
  #define JTAG_ID_PARTNO_J721E    0xbb64
  #define JTAG_ID_PARTNO_J721S2    0xbb75
+#define JTAG_ID_PARTNO_J722S    0xbba0


All the others use tab, you used spaces here. Personally I like spaces
for alignment, but unless you fix all the others, stick with tab for now.


Okay! Will fix it in v2.

-Jayesh




  #define JTAG_ID_PARTNO_J784S4    0xbb80
  #define K3_SOC_ID(id, ID) \
@@ -72,6 +73,7 @@ K3_SOC_ID(am65x, AM65X)
  K3_SOC_ID(j7200, J7200)
  K3_SOC_ID(j721e, J721E)
  K3_SOC_ID(j721s2, J721S2)
+K3_SOC_ID(j722s, J722S)
  #define K3_SEC_MGR_SYS_STATUS    0x44234100
  #define SYS_STATUS_DEV_TYPE_SHIFT    0
diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c
index 0838808515..f948914d21 100644
--- a/drivers/soc/soc_ti_k3.c
+++ b/drivers/soc/soc_ti_k3.c
@@ -47,6 +47,9 @@ static const char *get_family_string(u32 idreg)
  case JTAG_ID_PARTNO_J721S2:
  family = "J721S2";
  break;
+    case JTAG_ID_PARTNO_J722S:
+    family = "J722S";
+    break;
  case JTAG_ID_PARTNO_J784S4:
  family = "J784S4";
  break;


Re: [PATCH 03/14] soc: add info to identify the J722S SoC family

2024-05-29 Thread Andrew Davis

On 5/29/24 8:24 AM, Jayesh Choudhary wrote:

Include the part number for TI's j722s family of SoC
to identify it during boot.

Signed-off-by: Vaishnav Achath 
Signed-off-by: Jayesh Choudhary 
---
  arch/arm/mach-k3/include/mach/hardware.h | 2 ++
  drivers/soc/soc_ti_k3.c  | 3 +++
  2 files changed, 5 insertions(+)

diff --git a/arch/arm/mach-k3/include/mach/hardware.h 
b/arch/arm/mach-k3/include/mach/hardware.h
index c3aaded8dc..26c5bfcf76 100644
--- a/arch/arm/mach-k3/include/mach/hardware.h
+++ b/arch/arm/mach-k3/include/mach/hardware.h
@@ -55,6 +55,7 @@
  #define JTAG_ID_PARTNO_J7200  0xbb6d
  #define JTAG_ID_PARTNO_J721E  0xbb64
  #define JTAG_ID_PARTNO_J721S2 0xbb75
+#define JTAG_ID_PARTNO_J722S0xbba0


All the others use tab, you used spaces here. Personally I like spaces
for alignment, but unless you fix all the others, stick with tab for now.


  #define JTAG_ID_PARTNO_J784S4 0xbb80
  
  #define K3_SOC_ID(id, ID) \

@@ -72,6 +73,7 @@ K3_SOC_ID(am65x, AM65X)
  K3_SOC_ID(j7200, J7200)
  K3_SOC_ID(j721e, J721E)
  K3_SOC_ID(j721s2, J721S2)
+K3_SOC_ID(j722s, J722S)
  
  #define K3_SEC_MGR_SYS_STATUS		0x44234100

  #define SYS_STATUS_DEV_TYPE_SHIFT 0
diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c
index 0838808515..f948914d21 100644
--- a/drivers/soc/soc_ti_k3.c
+++ b/drivers/soc/soc_ti_k3.c
@@ -47,6 +47,9 @@ static const char *get_family_string(u32 idreg)
case JTAG_ID_PARTNO_J721S2:
family = "J721S2";
break;
+   case JTAG_ID_PARTNO_J722S:
+   family = "J722S";
+   break;
case JTAG_ID_PARTNO_J784S4:
family = "J784S4";
break;