Re: [PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace
On Wed, Aug 18, 2021 at 11:02:28AM +0200, Anatolij Gustschin wrote: > On Tue, 17 Aug 2021 17:59:40 -0400 > Tom Rini tr...@konsulko.com wrote: > > > The instances of CONFIG_SYS_I2C_EEPROM_ADDR on these platforms doesn't > > match up with the rest of the EERPOM related defines in U-Boot. Move > > these out of the CONFIG namespace rather than make complex Kconfig > > logic. > > > > Cc: Samuel Egli > > Cc: Anatolij Gustschin > > Cc: Heiko Schocher > > Signed-off-by: Tom Rini > > Reviewed-by: Anatolij Gustschin > > But probably some more cleanup in other board config headers needed, > see comment below. > > ... > > diff --git a/include/configs/draco.h b/include/configs/draco.h > > index 396eb7ded500..7c1f071d99ec 100644 > > --- a/include/configs/draco.h > > +++ b/include/configs/draco.h > > @@ -32,10 +32,6 @@ > > /* I2C Configuration */ > > #define CONFIG_SYS_I2C_SPEED 10 > > > > -#define CONFIG_SYS_I2C_EEPROM_ADDR 0x50 > > -#define EEPROM_ADDR_DDR3 0x90 > > -#define EEPROM_ADDR_CHIP 0x120 > > these defines are also in > > include/configs/etamin.h > include/configs/rastaban.h > include/configs/thuban.h Yes, it would be good for the board maintainers to follow up with more clean-up and migrate some siemens-specific symbols to Kconfig. I'm trying to not get too far off track and focus on just getting symbols in to Kconfig or out of CONFIG namespace right now. Thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace
On Tue, 17 Aug 2021 17:59:40 -0400 Tom Rini tr...@konsulko.com wrote: > The instances of CONFIG_SYS_I2C_EEPROM_ADDR on these platforms doesn't > match up with the rest of the EERPOM related defines in U-Boot. Move > these out of the CONFIG namespace rather than make complex Kconfig > logic. > > Cc: Samuel Egli > Cc: Anatolij Gustschin > Cc: Heiko Schocher > Signed-off-by: Tom Rini Reviewed-by: Anatolij Gustschin But probably some more cleanup in other board config headers needed, see comment below. ... > diff --git a/include/configs/draco.h b/include/configs/draco.h > index 396eb7ded500..7c1f071d99ec 100644 > --- a/include/configs/draco.h > +++ b/include/configs/draco.h > @@ -32,10 +32,6 @@ > /* I2C Configuration */ > #define CONFIG_SYS_I2C_SPEED 10 > > -#define CONFIG_SYS_I2C_EEPROM_ADDR 0x50 > -#define EEPROM_ADDR_DDR3 0x90 > -#define EEPROM_ADDR_CHIP 0x120 these defines are also in include/configs/etamin.h include/configs/rastaban.h include/configs/thuban.h -- Anatolij
Re: [PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace
Hello Tom, On 17.08.21 23:59, Tom Rini wrote: > The instances of CONFIG_SYS_I2C_EEPROM_ADDR on these platforms doesn't > match up with the rest of the EERPOM related defines in U-Boot. Move > these out of the CONFIG namespace rather than make complex Kconfig > logic. > > Cc: Samuel Egli > Cc: Anatolij Gustschin > Cc: Heiko Schocher > Signed-off-by: Tom Rini > --- > board/siemens/common/board.c | 3 ++- > board/siemens/draco/board.c | 12 > include/configs/draco.h | 4 > 3 files changed, 10 insertions(+), 9 deletions(-) Reviewed-by: Heiko Schocher Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
