Re: [PATCH 2/2] rockchip: rk3399: Update stack and bss addresses
Hi Quentin, On 2024-02-12 12:51, Quentin Schulz wrote: > Hi Jonas, > > On 2/12/24 12:08, Jonas Karlman wrote: >> Hi Quentin, >> >> On 2024-02-12 11:37, Quentin Schulz wrote: >>> Hi Jonas, >>> >>> On 2/12/24 01:59, Jonas Karlman wrote: With the stack and text base used by U-Boot SPL and proper on RK3399 there is a high likelihood of overlapping when U-Boot proper + FDT nears 1 MiB in size. Currently the following memory layout is used: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0030 (@3 MiB): U-Boot proper init stack - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0040 (@4 MiB): U-Boot SPL bss - 0x0200 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE SPL load TF-A, U-Boot proper and optional OPTEE after SPL stack has relocated, meaning that there is room for close to 2 MiB (@2-4 MiB). However, the initial stack used by U-Boot proper is limiting the size of U-Boot proper + FDT to below 1 MiB (@2-3 MiB). Instead change to use the following memory layout: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0080 (@8 MiB): U-Boot proper init stack (changed) - 0x0200 (@32 MiB): U-Boot SPL bss (changed) - 0x0400 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE This should leave room for loading and running a U-Boot proper close to 6 MiB (@2-8 MiB) in size. When U-Boot proper has relocated is should be possible to use @2-132 MiB and @164 MiB+ for scripts, kernel etc. With the moved SPL reloc stack it is also possible to use a much larger malloc area in SPL, e.g. using default SPL_STACK_R_MALLOC_SIMPLE_LEN. Signed-off-by: Jonas Karlman >>> >>> Do we not need to update memory addresses in the environment as well? >> >> The addresses in environment is to my knowledge only used in U-Boot >> proper after relocation. And at that time we should be free to use @2+ >> MiB up to somewhere close to gd ram_top/relocaddr. The optional Rockchip >> OPTEE blobb may occupy @132-164 MiB, but I do not think loading OPTEE >> blobs works as-is, so that may not be a big issue. >> > > Upstream OP-TEE OS seems to support RK3399, c.f. > https://github.com/OP-TEE/optee_os/blob/master/core/arch/arm/plat-rockchip/platform_rk3399.c > > I cannot say whether it works, I have no knowledge of any of our > customers using it (but that predates my joining Theobroma, so maybe > long time customers do use it?). However, we do use an upstream-based > OP-TEE OS for one of our PX30-based boards, so I would say Rockchip's > OP-TEE OS is not the only option so we shouldn't just disregard this > location in RAM... especially since ramdisk_addr_r starts at 96MiB. But > since we're not changing that location people who would have this > issue, would have encountered the issue by now already (provided they > load a ramdisk bigger than 36MiB). So let's ignore that one actually :) See my other mail, upstream OP-TEE OS seem to use @768 MiB and should not cause issues. Anyone trying to use Rockchip's OP-TEE OS blobs will get an error from binman, so trying to get that working will already involve customization. > >> So to my knowledge we do not need to update any of the memory addresses >> in the environment as well. >> >>> >>> scriptaddr=0x0050 >>> >>> This is at 5MiB if I'm not mistaken? >>> >>> Basically everything in include/configs/rk3399_common.h in >>> ENV_MEM_LAYOUT_SETTINGS needs to be updated to be located after 164MiB? >>> >>> Did I misunderstand something? I find it weird the current values seems >>> to be located after U-Boot SPL bss and that e.g. >>> >>> kernel_addr_r=0x0208 >>> >>> is at 32.5MiB, and with U-Boot SPL reloc stack currently at 64MiB... a >>> 31.5+MiB kernel Image would mess up the data there? (what do we need it >>> for BTW once in U-boot proper after relocation?). >> >> After SPL has jumped to TF-A and U-boot proper any memory used by SPL >> can be overwritten/used for something else. >> >> My understanding is as follow: >> - SPL always need access to bss >> - SPL need access to init stack until it has relocated to reloc stack >> - SPL will load FIT images using the reloc stack, at this time only >>SPL code, bss and reloc stack matters >> - U-boot proper will use its init stack until it has relocated to end >>of memory. Until U-Boot proper has relocated it will use init stack >> - We could use same memory position for init stack for SPL and proper, >>e.g. SPL_SHARES_INIT_SP_ADDR=y without any issue >> - After U-Boot proper has relocated we should be free to use @2+ MiB >>up to where U-Boot proper was relocated. >> > > Not sure how
Re: [PATCH 2/2] rockchip: rk3399: Update stack and bss addresses
On 2024-02-12 14:15, Jerome Forissier wrote: > On 2/12/24 12:51, Quentin Schulz wrote: >> Hi Jonas, >> >> On 2/12/24 12:08, Jonas Karlman wrote: >>> Hi Quentin, >>> >>> On 2024-02-12 11:37, Quentin Schulz wrote: Hi Jonas, On 2/12/24 01:59, Jonas Karlman wrote: > With the stack and text base used by U-Boot SPL and proper on RK3399 > there is a high likelihood of overlapping when U-Boot proper + FDT nears > 1 MiB in size. > > Currently the following memory layout is used: > - 0x (@0 MiB): U-Boot SPL text base > - 0x0004 (@256 KiB): TF-A > - 0x0020 (@2 MiB): U-Boot proper text base > - 0x0030 (@3 MiB): U-Boot proper init stack > - 0x0040 (@4 MiB): U-Boot SPL init stack > - 0x0040 (@4 MiB): U-Boot SPL bss > - 0x0200 (@64 MiB): U-Boot SPL reloc stack > - 0x0840 (@132 MiB): optional OPTEE > > SPL load TF-A, U-Boot proper and optional OPTEE after SPL stack has > relocated, meaning that there is room for close to 2 MiB (@2-4 MiB). > However, the initial stack used by U-Boot proper is limiting the size > of U-Boot proper + FDT to below 1 MiB (@2-3 MiB). > > Instead change to use the following memory layout: > - 0x (@0 MiB): U-Boot SPL text base > - 0x0004 (@256 KiB): TF-A > - 0x0020 (@2 MiB): U-Boot proper text base > - 0x0040 (@4 MiB): U-Boot SPL init stack > - 0x0080 (@8 MiB): U-Boot proper init stack (changed) > - 0x0200 (@32 MiB): U-Boot SPL bss (changed) > - 0x0400 (@64 MiB): U-Boot SPL reloc stack > - 0x0840 (@132 MiB): optional OPTEE > > This should leave room for loading and running a U-Boot proper close > to 6 MiB (@2-8 MiB) in size. When U-Boot proper has relocated is should > be possible to use @2-132 MiB and @164 MiB+ for scripts, kernel etc. > > With the moved SPL reloc stack it is also possible to use a much larger > malloc area in SPL, e.g. using default SPL_STACK_R_MALLOC_SIMPLE_LEN. > > Signed-off-by: Jonas Karlman Do we not need to update memory addresses in the environment as well? >>> >>> The addresses in environment is to my knowledge only used in U-Boot >>> proper after relocation. And at that time we should be free to use @2+ >>> MiB up to somewhere close to gd ram_top/relocaddr. The optional Rockchip >>> OPTEE blobb may occupy @132-164 MiB, but I do not think loading OPTEE >>> blobs works as-is, so that may not be a big issue. >>> >> >> Upstream OP-TEE OS seems to support RK3399, c.f. >> https://github.com/OP-TEE/optee_os/blob/master/core/arch/arm/plat-rockchip/platform_rk3399.c > > It does indeed. I run the quarterly release tests on a RockPi4B. We record > which > platforms have been tested in the commit description for each release tag. For > example, see [1]. > > In the configuration I test, OP-TEE is loaded at 0x3000 and uses 32MB (for > some reason the Linux DT reserves 36MB but I don't think it matters much). > > [1] > https://github.com/OP-TEE/optee_os/commit/18b424c23aa5a798dfe2e4d20b4bde3919dc4e99 > Great, I did a quick test run with OP-TEE on my ROCK 4SE and seem to work, see short boot log below. Also good to know that it runs at @768 MiB, we should be able to use @2-768 MiB for loading kernel, initrd etc in U-Boot proper with open source OP-TEE. --- U-Boot SPL 2024.04-rc1 (Feb 12 2024 - 20:39:20 +) Trying to boot from MMC2 ## Checking hash(es) for config config-1 ... OK ## Checking hash(es) for Image atf-1 ... sha256+ OK ## Checking hash(es) for Image u-boot ... sha256+ OK ## Checking hash(es) for Image fdt-1 ... sha256+ OK ## Checking hash(es) for Image atf-2 ... sha256+ OK ## Checking hash(es) for Image atf-3 ... sha256+ OK ## Checking hash(es) for Image atf-4 ... sha256+ OK load_simple_fit: Skip load 'atf-5': image size is 0! ## Checking hash(es) for Image tee-1 ... sha256+ OK NOTICE: BL31: v2.10.2(release): NOTICE: BL31: Built : 20:23:10, Feb 12 2024 INFO:GICv3 with legacy support detected. INFO:ARM GICv3 driver initialized in EL3 INFO:Maximum SPI INTID supported: 287 INFO:plat_rockchip_pmu_init(1624): pd status 3e INFO:BL31: Initializing runtime services INFO:BL31: Initializing BL32 I/TC: I/TC: No non-secure external DT I/TC: OP-TEE version: Unknown_4.1 (gcc version 10.5.0 (Ubuntu 10.5.0-1ubuntu1~22.04)) #2 Mon Feb 12 20:37:33 UTC 2024 aarch64 I/TC: WARNING: This OP-TEE configuration might be insecure! I/TC: WARNING: Please check https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html I/TC: Primary CPU initializing I/TC: GIC redistributor base address not provided I/TC: Assuming default GIC group status and modifier I/TC: Primary CPU switching to normal world boot INFO:BL31: Preparing for EL3 exit to normal world INFO:Entry point address = 0x20 INFO:SPSR = 0x3c9 U-Boot 2024.04-rc1 (Feb 12 2024 - 20:39:20 +) SoC: Rockchip rk3399 Reset cause: POR
Re: [PATCH 2/2] rockchip: rk3399: Update stack and bss addresses
On 2/12/24 12:51, Quentin Schulz wrote: > Hi Jonas, > > On 2/12/24 12:08, Jonas Karlman wrote: >> Hi Quentin, >> >> On 2024-02-12 11:37, Quentin Schulz wrote: >>> Hi Jonas, >>> >>> On 2/12/24 01:59, Jonas Karlman wrote: With the stack and text base used by U-Boot SPL and proper on RK3399 there is a high likelihood of overlapping when U-Boot proper + FDT nears 1 MiB in size. Currently the following memory layout is used: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0030 (@3 MiB): U-Boot proper init stack - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0040 (@4 MiB): U-Boot SPL bss - 0x0200 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE SPL load TF-A, U-Boot proper and optional OPTEE after SPL stack has relocated, meaning that there is room for close to 2 MiB (@2-4 MiB). However, the initial stack used by U-Boot proper is limiting the size of U-Boot proper + FDT to below 1 MiB (@2-3 MiB). Instead change to use the following memory layout: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0080 (@8 MiB): U-Boot proper init stack (changed) - 0x0200 (@32 MiB): U-Boot SPL bss (changed) - 0x0400 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE This should leave room for loading and running a U-Boot proper close to 6 MiB (@2-8 MiB) in size. When U-Boot proper has relocated is should be possible to use @2-132 MiB and @164 MiB+ for scripts, kernel etc. With the moved SPL reloc stack it is also possible to use a much larger malloc area in SPL, e.g. using default SPL_STACK_R_MALLOC_SIMPLE_LEN. Signed-off-by: Jonas Karlman >>> >>> Do we not need to update memory addresses in the environment as well? >> >> The addresses in environment is to my knowledge only used in U-Boot >> proper after relocation. And at that time we should be free to use @2+ >> MiB up to somewhere close to gd ram_top/relocaddr. The optional Rockchip >> OPTEE blobb may occupy @132-164 MiB, but I do not think loading OPTEE >> blobs works as-is, so that may not be a big issue. >> > > Upstream OP-TEE OS seems to support RK3399, c.f. > https://github.com/OP-TEE/optee_os/blob/master/core/arch/arm/plat-rockchip/platform_rk3399.c It does indeed. I run the quarterly release tests on a RockPi4B. We record which platforms have been tested in the commit description for each release tag. For example, see [1]. In the configuration I test, OP-TEE is loaded at 0x3000 and uses 32MB (for some reason the Linux DT reserves 36MB but I don't think it matters much). [1] https://github.com/OP-TEE/optee_os/commit/18b424c23aa5a798dfe2e4d20b4bde3919dc4e99 -- Jerome
Re: [PATCH 2/2] rockchip: rk3399: Update stack and bss addresses
Hi Jonas, On 2/12/24 12:08, Jonas Karlman wrote: Hi Quentin, On 2024-02-12 11:37, Quentin Schulz wrote: Hi Jonas, On 2/12/24 01:59, Jonas Karlman wrote: With the stack and text base used by U-Boot SPL and proper on RK3399 there is a high likelihood of overlapping when U-Boot proper + FDT nears 1 MiB in size. Currently the following memory layout is used: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0030 (@3 MiB): U-Boot proper init stack - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0040 (@4 MiB): U-Boot SPL bss - 0x0200 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE SPL load TF-A, U-Boot proper and optional OPTEE after SPL stack has relocated, meaning that there is room for close to 2 MiB (@2-4 MiB). However, the initial stack used by U-Boot proper is limiting the size of U-Boot proper + FDT to below 1 MiB (@2-3 MiB). Instead change to use the following memory layout: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0080 (@8 MiB): U-Boot proper init stack (changed) - 0x0200 (@32 MiB): U-Boot SPL bss (changed) - 0x0400 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE This should leave room for loading and running a U-Boot proper close to 6 MiB (@2-8 MiB) in size. When U-Boot proper has relocated is should be possible to use @2-132 MiB and @164 MiB+ for scripts, kernel etc. With the moved SPL reloc stack it is also possible to use a much larger malloc area in SPL, e.g. using default SPL_STACK_R_MALLOC_SIMPLE_LEN. Signed-off-by: Jonas Karlman Do we not need to update memory addresses in the environment as well? The addresses in environment is to my knowledge only used in U-Boot proper after relocation. And at that time we should be free to use @2+ MiB up to somewhere close to gd ram_top/relocaddr. The optional Rockchip OPTEE blobb may occupy @132-164 MiB, but I do not think loading OPTEE blobs works as-is, so that may not be a big issue. Upstream OP-TEE OS seems to support RK3399, c.f. https://github.com/OP-TEE/optee_os/blob/master/core/arch/arm/plat-rockchip/platform_rk3399.c I cannot say whether it works, I have no knowledge of any of our customers using it (but that predates my joining Theobroma, so maybe long time customers do use it?). However, we do use an upstream-based OP-TEE OS for one of our PX30-based boards, so I would say Rockchip's OP-TEE OS is not the only option so we shouldn't just disregard this location in RAM... especially since ramdisk_addr_r starts at 96MiB. But since we're not changing that location people who would have this issue, would have encountered the issue by now already (provided they load a ramdisk bigger than 36MiB). So let's ignore that one actually :) So to my knowledge we do not need to update any of the memory addresses in the environment as well. scriptaddr=0x0050 This is at 5MiB if I'm not mistaken? Basically everything in include/configs/rk3399_common.h in ENV_MEM_LAYOUT_SETTINGS needs to be updated to be located after 164MiB? Did I misunderstand something? I find it weird the current values seems to be located after U-Boot SPL bss and that e.g. kernel_addr_r=0x0208 is at 32.5MiB, and with U-Boot SPL reloc stack currently at 64MiB... a 31.5+MiB kernel Image would mess up the data there? (what do we need it for BTW once in U-boot proper after relocation?). After SPL has jumped to TF-A and U-boot proper any memory used by SPL can be overwritten/used for something else. My understanding is as follow: - SPL always need access to bss - SPL need access to init stack until it has relocated to reloc stack - SPL will load FIT images using the reloc stack, at this time only SPL code, bss and reloc stack matters - U-boot proper will use its init stack until it has relocated to end of memory. Until U-Boot proper has relocated it will use init stack - We could use same memory position for init stack for SPL and proper, e.g. SPL_SHARES_INIT_SP_ADDR=y without any issue - After U-Boot proper has relocated we should be free to use @2+ MiB up to where U-Boot proper was relocated. Not sure how Falcon boot fit in all of this and whether it makes use of the environment variable (likely in the SPL binary itself). Was this from experience and/or is there some literature in U-Boot git repo already? Couldn't find much in the 5min I looked for it :) Thanks for the taking the time to explain this, much appreciated. Side question, what about making those values the default for RK3399 instead of having it in each defconfig? This could grow quickly out of hands to move this to the Kconfig symbol itself, so not sure it's that interesting to the project, but raising this anyway. Agree, was trying to define these as defaults in soc Kconfig,
Re: [PATCH 2/2] rockchip: rk3399: Update stack and bss addresses
Hi Quentin, On 2024-02-12 11:37, Quentin Schulz wrote: > Hi Jonas, > > On 2/12/24 01:59, Jonas Karlman wrote: >> With the stack and text base used by U-Boot SPL and proper on RK3399 >> there is a high likelihood of overlapping when U-Boot proper + FDT nears >> 1 MiB in size. >> >> Currently the following memory layout is used: >> - 0x (@0 MiB): U-Boot SPL text base >> - 0x0004 (@256 KiB): TF-A >> - 0x0020 (@2 MiB): U-Boot proper text base >> - 0x0030 (@3 MiB): U-Boot proper init stack >> - 0x0040 (@4 MiB): U-Boot SPL init stack >> - 0x0040 (@4 MiB): U-Boot SPL bss >> - 0x0200 (@64 MiB): U-Boot SPL reloc stack >> - 0x0840 (@132 MiB): optional OPTEE >> >> SPL load TF-A, U-Boot proper and optional OPTEE after SPL stack has >> relocated, meaning that there is room for close to 2 MiB (@2-4 MiB). >> However, the initial stack used by U-Boot proper is limiting the size >> of U-Boot proper + FDT to below 1 MiB (@2-3 MiB). >> >> Instead change to use the following memory layout: >> - 0x (@0 MiB): U-Boot SPL text base >> - 0x0004 (@256 KiB): TF-A >> - 0x0020 (@2 MiB): U-Boot proper text base >> - 0x0040 (@4 MiB): U-Boot SPL init stack >> - 0x0080 (@8 MiB): U-Boot proper init stack (changed) >> - 0x0200 (@32 MiB): U-Boot SPL bss (changed) >> - 0x0400 (@64 MiB): U-Boot SPL reloc stack >> - 0x0840 (@132 MiB): optional OPTEE >> >> This should leave room for loading and running a U-Boot proper close >> to 6 MiB (@2-8 MiB) in size. When U-Boot proper has relocated is should >> be possible to use @2-132 MiB and @164 MiB+ for scripts, kernel etc. >> >> With the moved SPL reloc stack it is also possible to use a much larger >> malloc area in SPL, e.g. using default SPL_STACK_R_MALLOC_SIMPLE_LEN. >> >> Signed-off-by: Jonas Karlman > > Do we not need to update memory addresses in the environment as well? The addresses in environment is to my knowledge only used in U-Boot proper after relocation. And at that time we should be free to use @2+ MiB up to somewhere close to gd ram_top/relocaddr. The optional Rockchip OPTEE blobb may occupy @132-164 MiB, but I do not think loading OPTEE blobs works as-is, so that may not be a big issue. So to my knowledge we do not need to update any of the memory addresses in the environment as well. > > scriptaddr=0x0050 > > This is at 5MiB if I'm not mistaken? > > Basically everything in include/configs/rk3399_common.h in > ENV_MEM_LAYOUT_SETTINGS needs to be updated to be located after 164MiB? > > Did I misunderstand something? I find it weird the current values seems > to be located after U-Boot SPL bss and that e.g. > > kernel_addr_r=0x0208 > > is at 32.5MiB, and with U-Boot SPL reloc stack currently at 64MiB... a > 31.5+MiB kernel Image would mess up the data there? (what do we need it > for BTW once in U-boot proper after relocation?). After SPL has jumped to TF-A and U-boot proper any memory used by SPL can be overwritten/used for something else. My understanding is as follow: - SPL always need access to bss - SPL need access to init stack until it has relocated to reloc stack - SPL will load FIT images using the reloc stack, at this time only SPL code, bss and reloc stack matters - U-boot proper will use its init stack until it has relocated to end of memory. Until U-Boot proper has relocated it will use init stack - We could use same memory position for init stack for SPL and proper, e.g. SPL_SHARES_INIT_SP_ADDR=y without any issue - After U-Boot proper has relocated we should be free to use @2+ MiB up to where U-Boot proper was relocated. > > Side question, what about making those values the default for RK3399 > instead of having it in each defconfig? This could grow quickly out of > hands to move this to the Kconfig symbol itself, so not sure it's that > interesting to the project, but raising this anyway. Agree, was trying to define these as defaults in soc Kconfig, but that rearranged some values in other defconfigs so I avoided doing that in this series. Also touching each defconfig helped me ping board maintainers of the change. Hopefully a follow-up series can move these, and other options, into soc Kconfig. Regards, Jonas > > Cheers, > Quentin
Re: [PATCH 2/2] rockchip: rk3399: Update stack and bss addresses
Hi Jonas, On 2/12/24 01:59, Jonas Karlman wrote: With the stack and text base used by U-Boot SPL and proper on RK3399 there is a high likelihood of overlapping when U-Boot proper + FDT nears 1 MiB in size. Currently the following memory layout is used: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0030 (@3 MiB): U-Boot proper init stack - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0040 (@4 MiB): U-Boot SPL bss - 0x0200 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE SPL load TF-A, U-Boot proper and optional OPTEE after SPL stack has relocated, meaning that there is room for close to 2 MiB (@2-4 MiB). However, the initial stack used by U-Boot proper is limiting the size of U-Boot proper + FDT to below 1 MiB (@2-3 MiB). Instead change to use the following memory layout: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2 MiB): U-Boot proper text base - 0x0040 (@4 MiB): U-Boot SPL init stack - 0x0080 (@8 MiB): U-Boot proper init stack (changed) - 0x0200 (@32 MiB): U-Boot SPL bss (changed) - 0x0400 (@64 MiB): U-Boot SPL reloc stack - 0x0840 (@132 MiB): optional OPTEE This should leave room for loading and running a U-Boot proper close to 6 MiB (@2-8 MiB) in size. When U-Boot proper has relocated is should be possible to use @2-132 MiB and @164 MiB+ for scripts, kernel etc. With the moved SPL reloc stack it is also possible to use a much larger malloc area in SPL, e.g. using default SPL_STACK_R_MALLOC_SIMPLE_LEN. Signed-off-by: Jonas Karlman Do we not need to update memory addresses in the environment as well? scriptaddr=0x0050 This is at 5MiB if I'm not mistaken? Basically everything in include/configs/rk3399_common.h in ENV_MEM_LAYOUT_SETTINGS needs to be updated to be located after 164MiB? Did I misunderstand something? I find it weird the current values seems to be located after U-Boot SPL bss and that e.g. kernel_addr_r=0x0208 is at 32.5MiB, and with U-Boot SPL reloc stack currently at 64MiB... a 31.5+MiB kernel Image would mess up the data there? (what do we need it for BTW once in U-boot proper after relocation?). Side question, what about making those values the default for RK3399 instead of having it in each defconfig? This could grow quickly out of hands to move this to the Kconfig symbol itself, so not sure it's that interesting to the project, but raising this anyway. Cheers, Quentin
