Re: [PATCH 4/4] rockchip: rk3399: regenerate defconfigs
Hi Chen-Yu, On 2/10/24 07:32, Chen-Yu Tsai wrote: [Some people who received this message don't often get email from w...@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Chen-Yu Tsai Regenerate RK3399 defconfigs after adding imply statements. Signed-off-by: Chen-Yu Tsai --- configs/chromebook_bob_defconfig | 2 -- configs/chromebook_kevin_defconfig| 2 -- configs/firefly-rk3399_defconfig | 2 -- configs/nanopi-r4s-rk3399_defconfig | 2 -- configs/pinebook-pro-rk3399_defconfig | 2 -- configs/pinephone-pro-rk3399_defconfig| 2 -- configs/puma-rk3399_defconfig | 2 -- Reviewed-by: Quentin Schulz Thanks, Quentin
Re: [PATCH 4/4] rockchip: rk3399: regenerate defconfigs
On Sun, Feb 11, 2024 at 3:49 AM Jonas Karlman wrote: > > Hi Chen-Yu, > > On 2024-02-10 07:32, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > > > Regenerate RK3399 defconfigs after adding imply statements. > > > > Signed-off-by: Chen-Yu Tsai > > --- > > configs/chromebook_bob_defconfig | 2 -- > > configs/chromebook_kevin_defconfig| 2 -- > > configs/firefly-rk3399_defconfig | 2 -- > > configs/nanopi-r4s-rk3399_defconfig | 2 -- > > configs/pinebook-pro-rk3399_defconfig | 2 -- > > configs/pinephone-pro-rk3399_defconfig| 2 -- > > configs/puma-rk3399_defconfig | 2 -- > > configs/roc-pc-mezzanine-rk3399_defconfig | 2 -- > > configs/roc-pc-rk3399_defconfig | 2 -- > > configs/rock-4c-plus-rk3399_defconfig | 3 --- > > configs/rock-4se-rk3399_defconfig | 3 --- > > configs/rock-pi-4-rk3399_defconfig| 3 --- > > configs/rock-pi-4c-rk3399_defconfig | 3 --- > > configs/rock-pi-n10-rk3399pro_defconfig | 1 - > > configs/rock960-rk3399_defconfig | 1 - > > configs/rockpro64-rk3399_defconfig| 2 -- > > 16 files changed, 34 deletions(-) > > > > [snip] > > > diff --git a/configs/rock-4c-plus-rk3399_defconfig > > b/configs/rock-4c-plus-rk3399_defconfig > > index 18525c8bf504..12587b1eba10 100644 > > --- a/configs/rock-4c-plus-rk3399_defconfig > > +++ b/configs/rock-4c-plus-rk3399_defconfig > > @@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x30 > > CONFIG_ENV_OFFSET=0x3F8000 > > CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-4c-plus" > > -CONFIG_OF_LIBFDT_OVERLAY=y > > This patch seems to also remove a few OF_LIBFDT_OVERLAY, guessing this > was unintentional? Yeah, that was unintentional. I have a local patch that enables OF_LIBFDT_OVERLAY for ARCH_ROCKCHIP by default. > If you are re-spinning this series, please also include change to: > - add CONFIG_MISC=y to ficus-rk3399_defconfig, its required for efuse I suppose we should just also imply CONFIG_MISC. > - drop CONFIG_ROCKCHIP_OTP=y from nanopi-r4s-rk3399_defconfig, soc have > efuse or otp and on rk3399 it is efuse Will add a cleanup. > And possible also drop CONFIG_NET_RANDOM_ETHADDR=y from: > - evb-rk3399_defconfig > - ficus-rk3399_defconfig > - khadas-edge-captain-rk3399_defconfig > - khadas-edge-v-rk3399_defconfig > now that these boards will have proper ethaddr. Will add a separate cleanup. ChenYu
Re: [PATCH 4/4] rockchip: rk3399: regenerate defconfigs
Hi Chen-Yu, On 2024-02-10 07:32, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > Regenerate RK3399 defconfigs after adding imply statements. > > Signed-off-by: Chen-Yu Tsai > --- > configs/chromebook_bob_defconfig | 2 -- > configs/chromebook_kevin_defconfig| 2 -- > configs/firefly-rk3399_defconfig | 2 -- > configs/nanopi-r4s-rk3399_defconfig | 2 -- > configs/pinebook-pro-rk3399_defconfig | 2 -- > configs/pinephone-pro-rk3399_defconfig| 2 -- > configs/puma-rk3399_defconfig | 2 -- > configs/roc-pc-mezzanine-rk3399_defconfig | 2 -- > configs/roc-pc-rk3399_defconfig | 2 -- > configs/rock-4c-plus-rk3399_defconfig | 3 --- > configs/rock-4se-rk3399_defconfig | 3 --- > configs/rock-pi-4-rk3399_defconfig| 3 --- > configs/rock-pi-4c-rk3399_defconfig | 3 --- > configs/rock-pi-n10-rk3399pro_defconfig | 1 - > configs/rock960-rk3399_defconfig | 1 - > configs/rockpro64-rk3399_defconfig| 2 -- > 16 files changed, 34 deletions(-) > [snip] > diff --git a/configs/rock-4c-plus-rk3399_defconfig > b/configs/rock-4c-plus-rk3399_defconfig > index 18525c8bf504..12587b1eba10 100644 > --- a/configs/rock-4c-plus-rk3399_defconfig > +++ b/configs/rock-4c-plus-rk3399_defconfig > @@ -8,7 +8,6 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x30 > CONFIG_ENV_OFFSET=0x3F8000 > CONFIG_DEFAULT_DEVICE_TREE="rk3399-rock-4c-plus" > -CONFIG_OF_LIBFDT_OVERLAY=y This patch seems to also remove a few OF_LIBFDT_OVERLAY, guessing this was unintentional? If you are re-spinning this series, please also include change to: - add CONFIG_MISC=y to ficus-rk3399_defconfig, its required for efuse - drop CONFIG_ROCKCHIP_OTP=y from nanopi-r4s-rk3399_defconfig, soc have efuse or otp and on rk3399 it is efuse And possible also drop CONFIG_NET_RANDOM_ETHADDR=y from: - evb-rk3399_defconfig - ficus-rk3399_defconfig - khadas-edge-captain-rk3399_defconfig - khadas-edge-v-rk3399_defconfig now that these boards will have proper ethaddr. Regards, Jonas
