Re: [PATCH V2 00/14] ARM: stm32: Fix Avenger96
On 4/1/20 11:15 AM, Patrick DELAUNAY wrote: > Hi Marek, Hi, >> From: Marek Vasut >> Sent: mardi 31 mars 2020 18:59 >> >> On 3/31/20 5:22 PM, Patrick DELAUNAY wrote: >>> Hi Marek, >> >> Hi, >> From: Marek Vasut Sent: mardi 31 mars 2020 02:49 This series fixes the Avenger96 board. Since there are way too many patches floating around on the ML and because I found various other details that needed fixing, I decided to bundle the whole set of fixes into this >> series. This should go into current release, otherwise the board doesn't even boot. This V2 is also roughly synchronized with the Linux V2 series fixing very much the same issues. >>> >>> Do you expect all these paches in v2020.04 ? so in 5 days. >> >> Yes, the timing is bad, but this is fixing real bugs and is isolated to one >> (two) >> boards. > > Ok, I will prepare pull request asap. Thank you. Let me know if you have a tree so I can check it. [...] ARM: dts: stm32: Add missing ethernet PHY reset on AV96 ARM: dts: stm32: Repair PMIC configuration on AV96 >> >> This fixes PMIC settings, so you do want this, otherwise the board is >> unstable. > > I will take even if I have remark on buck1 min voltage and buck2 > configuration (regulator-active-discharge) I will double-check those and possibly send a subsequent patch. ARM: dts: stm32: Adjust PLL4 settings on AV96 >> >> This one can probably wait, although it would make sense to put it in. > > Not yet review by AV96 upstreamer... I prefer wait. Fine by me. ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board >> >> This one can wait for next. >> >> [...] > > I am preparing the branch stm/master and the pull request. Thanks ! -- Best regards, Marek Vasut
RE: [PATCH V2 00/14] ARM: stm32: Fix Avenger96
Hi Marek, > From: Marek Vasut > Sent: mardi 31 mars 2020 18:59 > > On 3/31/20 5:22 PM, Patrick DELAUNAY wrote: > > Hi Marek, > > Hi, > > >> From: Marek Vasut > >> Sent: mardi 31 mars 2020 02:49 > >> > >> This series fixes the Avenger96 board. Since there are way too many > >> patches floating around on the ML and because I found various other > >> details that needed fixing, I decided to bundle the whole set of fixes > >> into this > series. > >> > >> This should go into current release, otherwise the board doesn't even boot. > >> This V2 is also roughly synchronized with the Linux V2 series fixing > >> very much the same issues. > > > > Do you expect all these paches in v2020.04 ? so in 5 days. > > Yes, the timing is bad, but this is fixing real bugs and is isolated to one > (two) > boards. Ok, I will prepare pull request asap. [...] > > But for the rest of the serie, I prefer wait v2020.04 merge window and > > end of reviews (on U-Boot side and on Linux kernel side). > > > >> ARM: dts: stm32: Add QSPI NOR on AV96 > > This one you need to have working env storage. Yes I miss this point, but only for stm32mp15_dhcom_basic_defconfig NO issue for stm32mp15_basic_defconfig, the configuration for EV96 until now. I will take it. > >> ARM: dts: stm32: Use DT alias for the configuration EEPROM > >> ARM: dts: stm32: Add configuration EEPROM on AV96 OK, that fixes but only if stm32mp15_dhcom_basic_defconfig is used. > This one you need , otherwise ethernet MAC doesn't get correct MAC address. > > >> ARM: dts: stm32: Add alternate pinmux for ethernet RGMII OK > >> ARM: dts: stm32: Repair ethernet operation on AV96 No impact (as not supported by driver), I will take it. > This actually fixes ethernet. > > >> ARM: dts: stm32: Add missing ethernet PHY reset on AV96 > >> ARM: dts: stm32: Repair PMIC configuration on AV96 > > This fixes PMIC settings, so you do want this, otherwise the board is > unstable. I will take even if I have remark on buck1 min voltage and buck2 configuration (regulator-active-discharge) > >> ARM: dts: stm32: Adjust PLL4 settings on AV96 > > This one can probably wait, although it would make sense to put it in. Not yet review by AV96 upstreamer... I prefer wait. > >> ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board > > This one can wait for next. > > [...] I am preparing the branch stm/master and the pull request. Thanks Patrick
Re: [PATCH V2 00/14] ARM: stm32: Fix Avenger96
On 3/31/20 5:22 PM, Patrick DELAUNAY wrote: > Hi Marek, Hi, >> From: Marek Vasut >> Sent: mardi 31 mars 2020 02:49 >> >> This series fixes the Avenger96 board. Since there are way too many patches >> floating around on the ML and because I found various other details that >> needed >> fixing, I decided to bundle the whole set of fixes into this series. >> >> This should go into current release, otherwise the board doesn't even boot. >> This V2 is also roughly synchronized with the Linux V2 series fixing very >> much >> the same issues. > > Do you expect all these paches in v2020.04 ? so in 5 days. Yes, the timing is bad, but this is fixing real bugs and is isolated to one (two) boards. > I think I can prepare a pull request with bugfix to solve regression, but it > seems late for all the serie. > > For me: >> ARM: dts: stm32: Repair SD1 pre-reloc pinmux DT node on AV96 > > It is clearly a regression since u-boot-stm32-20190717 / v2020.01-rc1 ! > > The next 4 patches of the serie could be also applied without issue >> ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins >> ARM: dts: stm32: Repair SDMMC1 operation on AV96 >> ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 >> ARM: dts: stm32: Repair SDMMC2 operation > > But for the rest of the serie, I prefer wait v2020.04 merge window and end of > reviews > (on U-Boot side and on Linux kernel side). > >> ARM: dts: stm32: Add QSPI NOR on AV96 This one you need to have working env storage. >> ARM: dts: stm32: Use DT alias for the configuration EEPROM >> ARM: dts: stm32: Add configuration EEPROM on AV96 This one you need , otherwise ethernet MAC doesn't get correct MAC address. >> ARM: dts: stm32: Add alternate pinmux for ethernet RGMII >> ARM: dts: stm32: Repair ethernet operation on AV96 This actually fixes ethernet. >> ARM: dts: stm32: Add missing ethernet PHY reset on AV96 >> ARM: dts: stm32: Repair PMIC configuration on AV96 This fixes PMIC settings, so you do want this, otherwise the board is unstable. >> ARM: dts: stm32: Adjust PLL4 settings on AV96 This one can probably wait, although it would make sense to put it in. >> ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board This one can wait for next. [...]
RE: [PATCH V2 00/14] ARM: stm32: Fix Avenger96
Hi Marek,
> From: Marek Vasut
> Sent: mardi 31 mars 2020 02:49
>
> This series fixes the Avenger96 board. Since there are way too many patches
> floating around on the ML and because I found various other details that
> needed
> fixing, I decided to bundle the whole set of fixes into this series.
>
> This should go into current release, otherwise the board doesn't even boot.
> This V2 is also roughly synchronized with the Linux V2 series fixing very much
> the same issues.
Do you expect all these paches in v2020.04 ? so in 5 days.
I think I can prepare a pull request with bugfix to solve regression, but it
seems late for all the serie.
For me:
> ARM: dts: stm32: Repair SD1 pre-reloc pinmux DT node on AV96
It is clearly a regression since u-boot-stm32-20190717 / v2020.01-rc1 !
The next 4 patches of the serie could be also applied without issue
> ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
> ARM: dts: stm32: Repair SDMMC1 operation on AV96
> ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
> ARM: dts: stm32: Repair SDMMC2 operation
But for the rest of the serie, I prefer wait v2020.04 merge window and end of
reviews
(on U-Boot side and on Linux kernel side).
> ARM: dts: stm32: Add QSPI NOR on AV96
> ARM: dts: stm32: Use DT alias for the configuration EEPROM
> ARM: dts: stm32: Add configuration EEPROM on AV96
> ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
> ARM: dts: stm32: Repair ethernet operation on AV96
> ARM: dts: stm32: Add missing ethernet PHY reset on AV96
> ARM: dts: stm32: Repair PMIC configuration on AV96
> ARM: dts: stm32: Adjust PLL4 settings on AV96
> ARM: dts: stm32: Split AV96 into DHCOR SoM and AV96 board
>
> arch/arm/dts/Makefile | 3 +-
> arch/arm/dts/stm32mp157-pinctrl.dtsi | 96 +
> arch/arm/dts/stm32mp157a-avenger96.dts| 365 +-
> arch/arm/dts/stm32mp15xx-dhcom.dtsi | 6 +-
> .../stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 80
> arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts | 211 ++ ...oot.dtsi
> => stm32mp15xx-dhcor-u-boot.dtsi} | 80 +---
> arch/arm/dts/stm32mp15xx-dhcor.dtsi | 231 +++
> board/dhelectronics/dh_stm32mp1/board.c | 15 +-
> doc/board/st/stm32mp1.rst | 8 +-
> 10 files changed, 645 insertions(+), 450 deletions(-) create mode 100644
> arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
> create mode 100644 arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts
> rename arch/arm/dts/{stm32mp157a-avenger96-u-boot.dtsi => stm32mp15xx-
> dhcor-u-boot.dtsi} (73%) create mode 100644 arch/arm/dts/stm32mp15xx-
> dhcor.dtsi
>
> Cc: Patrick Delaunay
> Cc: Patrice Chotard
Regards
> --
> 2.25.1
