Re: [PATCH V2 07/17] board: ti: j721e: Disable probing of daughtercards

2021-11-12 Thread Sinthu Raja M
Hi Tom,

On Mon, Nov 8, 2021 at 9:22 PM Tom Rini  wrote:
>
> On Tue, Nov 02, 2021 at 07:35:48PM +0530, Sinthu Raja wrote:
> > From: Sinthu Raja 
> >
> > j721e-sk doesn't have any daughter cards, so disable daughter
> > card probing inside board_late_init() and spl_board_init() for
> > j721e-sk.
> >
> > Signed-off-by: Sinthu Raja 
> > ---
> >
> > Changes in V2:
> > * J721E EAIK board name is changed to J721E SK, rename all occurrences of 
> > eaik
> > to sk.
> >
> >  board/ti/j721e/evm.c | 9 ++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> > index 9d4609cfe9..cb491ad950 100644
> > --- a/board/ti/j721e/evm.c
> > +++ b/board/ti/j721e/evm.c
> > @@ -434,7 +434,8 @@ int board_late_init(void)
> >   setup_serial();
> >
> >   /* Check for and probe any plugged-in daughtercards */
> > - probe_daughtercards();
> > + if (!board_is_j721e_sk())
> > + probe_daughtercards();
>
> This should be a positive check for the board(s) which can even have
> daughtercards.

Agreed, will update as positive check.

Regards
Sinthu Raja
>
> --
> Tom



-- 
With Regards
Sinthu Raja


Re: [PATCH V2 07/17] board: ti: j721e: Disable probing of daughtercards

2021-11-08 Thread Tom Rini
On Tue, Nov 02, 2021 at 07:35:48PM +0530, Sinthu Raja wrote:
> From: Sinthu Raja 
> 
> j721e-sk doesn't have any daughter cards, so disable daughter
> card probing inside board_late_init() and spl_board_init() for
> j721e-sk.
> 
> Signed-off-by: Sinthu Raja 
> ---
> 
> Changes in V2:
> * J721E EAIK board name is changed to J721E SK, rename all occurrences of 
> eaik 
> to sk.
> 
>  board/ti/j721e/evm.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
> index 9d4609cfe9..cb491ad950 100644
> --- a/board/ti/j721e/evm.c
> +++ b/board/ti/j721e/evm.c
> @@ -434,7 +434,8 @@ int board_late_init(void)
>   setup_serial();
>  
>   /* Check for and probe any plugged-in daughtercards */
> - probe_daughtercards();
> + if (!board_is_j721e_sk())
> + probe_daughtercards();

This should be a positive check for the board(s) which can even have
daughtercards.

-- 
Tom


signature.asc
Description: PGP signature