Re: [PATCH V4 01/14] env: Complete generic support for writable list
On 2/2/23 14:51, Jan Kiszka wrote: On 02.02.23 13:48, Marek Vasut wrote: On 2/2/23 09:07, Jan Kiszka wrote: From: Jan Kiszka This completes what 890feecaab72 started by selecting ENV_APPEND and loading the default env before any other sources. This ensures that load operations pick up all non-writable vars from the default env and only permitted parts from other locations according to the regular priorities. With this change, boards only need to define the list of writable variables but no longer have to provide a custom env_get_location implementation. CC: Joe Hershberger CC: Marek Vasut CC: Stefan Herbrechtsmeier Signed-off-by: Jan Kiszka Reviewed-by: Marek Vasut Maybe just send this one as a separate patch, so it can go in separately from this series. In fact, patch 1 and 2 are foundations and could be picked independently of rest if preferred. I don't mind waiting for the whole but I can also split if it helps the maintainer(s). I suspect splitting off the u-boot (env) and other core parts from the iot2050 into separate series would make it easier to apply to the right tree. Just note down the dependencies in the commit message under --- or in cover letter, if there are any.
Re: [PATCH V4 01/14] env: Complete generic support for writable list
On 02.02.23 13:48, Marek Vasut wrote: > On 2/2/23 09:07, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This completes what 890feecaab72 started by selecting ENV_APPEND and >> loading the default env before any other sources. This ensures that load >> operations pick up all non-writable vars from the default env and only >> permitted parts from other locations according to the regular >> priorities. >> >> With this change, boards only need to define the list of writable >> variables but no longer have to provide a custom env_get_location >> implementation. >> >> CC: Joe Hershberger >> CC: Marek Vasut >> CC: Stefan Herbrechtsmeier >> Signed-off-by: Jan Kiszka >> Reviewed-by: Marek Vasut > > Maybe just send this one as a separate patch, so it can go in separately > from this series. In fact, patch 1 and 2 are foundations and could be picked independently of rest if preferred. I don't mind waiting for the whole but I can also split if it helps the maintainer(s). Jan -- Siemens AG, Technology Competence Center Embedded Linux
Re: [PATCH V4 01/14] env: Complete generic support for writable list
On 2/2/23 09:07, Jan Kiszka wrote: From: Jan Kiszka This completes what 890feecaab72 started by selecting ENV_APPEND and loading the default env before any other sources. This ensures that load operations pick up all non-writable vars from the default env and only permitted parts from other locations according to the regular priorities. With this change, boards only need to define the list of writable variables but no longer have to provide a custom env_get_location implementation. CC: Joe Hershberger CC: Marek Vasut CC: Stefan Herbrechtsmeier Signed-off-by: Jan Kiszka Reviewed-by: Marek Vasut Maybe just send this one as a separate patch, so it can go in separately from this series.
